fix(interfaces): read interfaces and addresses from the gateway's status page #23

Merged
christianmanivong merged 2 commits from fix/interfaces-from-cardpage into main 2026-11-12 15:20:08 +00:00
Owner

The interfaces page of a VMG4005-B50A showed wan, lan and two Wi-Fi radios, all up at 1000 Mbit/s, with 192.168.1.1/24 on the LAN. The gateway is a VDSL bridge without Wi-Fi, and its LAN is a /29.

Cause. get_interfaces returned a fixed set, and get_interfaces_ip hard-coded /24. Both read WanIp, LanIp and MacAddress from getBasicInformation, which this firmware does not send. The LAN address was therefore just the hostname the driver connected to.

Fix. Both now read the DAL's cardpage_status (a GET answers sealed, like a PUT, and is decrypted):

  • WanLanInfo gives the IP interfaces by their own names (br0, atm0.1, ptm0.2), with status, MAC and the IPv4 addresses with their netmask.
  • LanInfo gives the Ethernet ports (eth1, "LAN1"), with status, MAC and speed.
  • A speed or MTU the gateway does not report is 0 (unknown).
  • IPv6 is not read yet: no gateway seen so far had it on.

Checked read-only against the live gateway: br0 192.168.1.1/29, eth1 1000 Mbit/s, atm0.1 and ptm0.2 down, no Wi-Fi.

The tests that pinned the invented interfaces are gone. tests/test_interfaces.py uses the gateway's real answer, cut down to the fields read.

The interfaces page of a VMG4005-B50A showed `wan`, `lan` and two Wi-Fi radios, all up at 1000 Mbit/s, with `192.168.1.1/24` on the LAN. The gateway is a VDSL bridge without Wi-Fi, and its LAN is a /29. **Cause.** `get_interfaces` returned a fixed set, and `get_interfaces_ip` hard-coded /24. Both read `WanIp`, `LanIp` and `MacAddress` from `getBasicInformation`, which this firmware does not send. The LAN address was therefore just the hostname the driver connected to. **Fix.** Both now read the DAL's `cardpage_status` (a GET answers sealed, like a PUT, and is decrypted): - `WanLanInfo` gives the IP interfaces by their own names (`br0`, `atm0.1`, `ptm0.2`), with status, MAC and the IPv4 addresses with their netmask. - `LanInfo` gives the Ethernet ports (`eth1`, "LAN1"), with status, MAC and speed. - A speed or MTU the gateway does not report is 0 (unknown). - IPv6 is not read yet: no gateway seen so far had it on. Checked read-only against the live gateway: br0 192.168.1.1/29, eth1 1000 Mbit/s, atm0.1 and ptm0.2 down, no Wi-Fi. The tests that pinned the invented interfaces are gone. `tests/test_interfaces.py` uses the gateway's real answer, cut down to the fields read.
christianmanivong added 1 commit 2026-11-12 15:14:35 +00:00
fix(interfaces): read interfaces and addresses from the gateway's status page
driver / standard (pull_request) Failing after 15s
driver / lint (pull_request) Successful in 13s
driver / types (pull_request) Successful in 59s
driver / test (3.13) (pull_request) Successful in 52s
driver / test (3.12) (pull_request) Successful in 56s
driver / lowest (pull_request) Successful in 25s
driver / build (pull_request) Successful in 27s
driver / security (pull_request) Successful in 54s
CI / driver (pull_request) Failing after 2m1s
driver / publish (pull_request) Skipped
ec76c1d6e8
get_interfaces reported a fixed set: wan, lan and two Wi-Fi radios, all
up at 1000 Mbit/s, the LAN with the WAN's MAC. get_interfaces_ip gave
both a /24, the LAN's address being the hostname the driver connected
to. getBasicInformation carries none of WanIp, LanIp or MacAddress on a
VMG4005-B50A, a VDSL bridge without Wi-Fi whose LAN is a /29, and the
gateway showed all of the invented values.

Both now read the DAL's cardpage_status, which a GET answers sealed like
a PUT: the IP interfaces in WanLanInfo (br0, atm0.1, ptm0.2) with their
status, MAC and netmask, the Ethernet ports in LanInfo (eth1) with their
speed. A speed or MTU the gateway does not report is 0, unknown. IPv6
addresses are not read yet: no gateway seen so far had IPv6 on.
christianmanivong added 1 commit 2026-11-12 15:17:47 +00:00
refactor(interfaces): build each interface and address set in its own function
driver / lint (pull_request) Successful in 14s
driver / standard (pull_request) Successful in 16s
driver / types (pull_request) Successful in 1m1s
driver / test (3.13) (pull_request) Successful in 49s
driver / test (3.12) (pull_request) Successful in 59s
driver / lowest (pull_request) Successful in 27s
driver / build (pull_request) Successful in 25s
driver / security (pull_request) Successful in 58s
CI / driver (pull_request) Successful in 2m4s
driver / publish (pull_request) Skipped
094cfa9c3e
The quality ratchet counted get_interfaces at 15: both loop bodies and the
address loop now sit in _ip_interface, _ethernet_port and _ipv4_addresses.
christianmanivong merged commit ca67c08736 into main 2026-11-12 15:20:08 +00:00
christianmanivong deleted branch fix/interfaces-from-cardpage 2026-11-12 15:20:08 +00:00
Sign in to join this conversation.