Priority: P3 (important, not urgent): wrong facts on every poll, nothing breaks.
get_facts takes SerialNumber, HostName, SystemUpTime and MacAddress from getBasicInformation. On a VMG4005-B50A (V5.17(ABQA.3.1)C0) that answer only carries ModelName, SoftwareVersion, CurrentLanguage, AvailableLanguages, RememberPassword and FWUpgradeProgressST. So the serial number is empty, the uptime is 0, and the hostname is the IP the driver connected to.
The DAL's cardpage_status (read since #23) has DeviceInfo.SerialNumber, DeviceInfo.UpTime and DeviceInfo.ModelName. The hostname needs another source.
The test fixture MOCK_BASIC_INFO in tests/test_zyxel.py invents these fields too, so it should be replaced by the real answer. get_wan_status reads the same invented fields and should be checked in the same pass.
Priority: P3 (important, not urgent): wrong facts on every poll, nothing breaks.
`get_facts` takes `SerialNumber`, `HostName`, `SystemUpTime` and `MacAddress` from `getBasicInformation`. On a VMG4005-B50A (V5.17(ABQA.3.1)C0) that answer only carries `ModelName`, `SoftwareVersion`, `CurrentLanguage`, `AvailableLanguages`, `RememberPassword` and `FWUpgradeProgressST`. So the serial number is empty, the uptime is 0, and the hostname is the IP the driver connected to.
The DAL's `cardpage_status` (read since #23) has `DeviceInfo.SerialNumber`, `DeviceInfo.UpTime` and `DeviceInfo.ModelName`. The hostname needs another source.
The test fixture `MOCK_BASIC_INFO` in `tests/test_zyxel.py` invents these fields too, so it should be replaced by the real answer. `get_wan_status` reads the same invented fields and should be checked in the same pass.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Priority: P3 (important, not urgent): wrong facts on every poll, nothing breaks.
get_factstakesSerialNumber,HostName,SystemUpTimeandMacAddressfromgetBasicInformation. On a VMG4005-B50A (V5.17(ABQA.3.1)C0) that answer only carriesModelName,SoftwareVersion,CurrentLanguage,AvailableLanguages,RememberPasswordandFWUpgradeProgressST. So the serial number is empty, the uptime is 0, and the hostname is the IP the driver connected to.The DAL's
cardpage_status(read since #23) hasDeviceInfo.SerialNumber,DeviceInfo.UpTimeandDeviceInfo.ModelName. The hostname needs another source.The test fixture
MOCK_BASIC_INFOintests/test_zyxel.pyinvents these fields too, so it should be replaced by the real answer.get_wan_statusreads the same invented fields and should be checked in the same pass.