fix(facts): read serial number and uptime from the status page #28

Merged
christianmanivong merged 1 commits from fix/facts-from-status-page into main 2026-11-12 16:22:03 +00:00
Owner

Closes #27

get_facts read SerialNumber and SystemUpTime from getBasicInformation, which a VMG4005-B50A (V5.17(ABQA.3.1)C0) does not send, and reported serial_number: '' and uptime: 0. The gateway has both in DeviceInfo of the DAL's cardpage_status, the answer the interfaces are read from (#23).

  • get_facts reads cardpage_status once and takes the interfaces, serial number and uptime from it (_interfaces(page) is shared with get_interfaces)
  • model and firmware stay with getBasicInformation, which carries them
  • a status page without DeviceInfo reports "" and 0 (unknown); one that cannot be read makes get_facts raise, as before

Tests: tests/test_facts.py with that gateway's answers; 94 passed, ruff, mypy and the standard's ratchet clean.

Closes #27 `get_facts` read `SerialNumber` and `SystemUpTime` from `getBasicInformation`, which a VMG4005-B50A (V5.17(ABQA.3.1)C0) does not send, and reported `serial_number: ''` and `uptime: 0`. The gateway has both in `DeviceInfo` of the DAL's `cardpage_status`, the answer the interfaces are read from (#23). - `get_facts` reads `cardpage_status` once and takes the interfaces, serial number and uptime from it (`_interfaces(page)` is shared with `get_interfaces`) - model and firmware stay with `getBasicInformation`, which carries them - a status page without `DeviceInfo` reports `""` and `0` (unknown); one that cannot be read makes `get_facts` raise, as before Tests: `tests/test_facts.py` with that gateway's answers; 94 passed, ruff, mypy and the standard's ratchet clean.
christianmanivong added 1 commit 2026-11-12 16:19:09 +00:00
fix(facts): read serial number and uptime from the status page
driver / lint (pull_request) Successful in 20s
driver / standard (pull_request) Successful in 20s
driver / types (pull_request) Successful in 1m8s
driver / test (3.13) (pull_request) Successful in 58s
driver / test (3.12) (pull_request) Successful in 1m6s
driver / lowest (pull_request) Successful in 26s
driver / build (pull_request) Successful in 36s
driver / security (pull_request) Successful in 1m5s
CI / driver (pull_request) Successful in 2m23s
driver / publish (pull_request) Skipped
1fda222d56
get_facts read SerialNumber and SystemUpTime from getBasicInformation,
which a VMG4005-B50A does not send, and reported "" and 0. The gateway
has both in DeviceInfo of the DAL's cardpage_status, the answer the
interfaces are read from. get_facts now reads that answer once and takes
the interfaces, serial number and uptime from it. Model and firmware stay
with getBasicInformation, which does carry them.

Closes #27
christianmanivong merged commit 23dbfb7650 into main 2026-11-12 16:22:03 +00:00
christianmanivong deleted branch fix/facts-from-status-page 2026-11-12 16:22:03 +00:00
Sign in to join this conversation.