dc24dd636b6146caaca89b053b7faff5e429c60a
163
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
dc24dd636b |
test(system-identity): compare the identity's keys only
driver / build (pull_request) Successful in 30s
driver / security (pull_request) Successful in 1m4s
CI / driver (pull_request) Successful in 2m44s
driver / standard (pull_request) Successful in 15s
driver / types (pull_request) Successful in 58s
driver / test (3.12) (pull_request) Successful in 1m10s
driver / test (3.13) (pull_request) Successful in 1m6s
driver / lowest (pull_request) Successful in 37s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 14s
napalm-device-types reads the system firmware in the same round trip (bios_vendor, bios_version, bios_date). The driver only carries the command across, so its test checks the identity it reads and passes against napalm-device-types with and without the firmware. NetOrk/netork#2518 |
||
|
|
eff6af8b45 |
Merge pull request 'fix(system): set_hostname writes /etc/hosts through a mktemp file in /etc (#66)' (#67) from fix/hosts-tempfile-2446 into main
driver / lint (push) Successful in 13s
driver / test (3.13) (push) Successful in 54s
driver / lowest (push) Successful in 29s
driver / build (push) Successful in 29s
driver / security (push) Successful in 54s
driver / publish (push) Skipped
driver / types (push) Successful in 50s
driver / test (3.12) (push) Successful in 1m0s
driver / standard (push) Successful in 14s
CI / driver (push) Successful in 2m21s
|
||
|
|
a421a595d4 |
Merge remote-tracking branch 'origin/main' into fix/hosts-tempfile-2446
driver / build (pull_request) Successful in 25s
driver / security (pull_request) Successful in 57s
CI / driver (pull_request) Successful in 2m23s
driver / standard (pull_request) Successful in 14s
driver / types (pull_request) Successful in 50s
driver / test (3.12) (pull_request) Successful in 58s
driver / test (3.13) (pull_request) Successful in 58s
driver / lowest (pull_request) Successful in 31s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 13s
|
||
|
|
6fccd7a8f0 |
Merge pull request 'fix(system): set_hostname quotes the name in its root commands (#64)' (#65) from fix/hostname-quote-2456 into main
driver / lint (push) Successful in 12s
driver / test (3.13) (push) Successful in 52s
driver / lowest (push) Successful in 30s
driver / build (push) Successful in 29s
driver / security (push) Successful in 1m1s
driver / publish (push) Skipped
driver / types (push) Successful in 55s
driver / test (3.12) (push) Successful in 1m0s
driver / standard (push) Successful in 15s
CI / driver (push) Successful in 2m28s
|
||
|
|
610d6f1093 |
chore(ratchet): set_hostname is a line shorter (#66)
driver / lowest (pull_request) Successful in 29s
driver / build (pull_request) Successful in 28s
driver / security (pull_request) Successful in 1m3s
CI / driver (pull_request) Successful in 16m53s
driver / standard (pull_request) Successful in 14m29s
driver / lint (pull_request) Successful in 13s
driver / types (pull_request) Successful in 58s
driver / test (3.12) (pull_request) Successful in 1m7s
driver / test (3.13) (pull_request) Successful in 56s
driver / publish (pull_request) Skipped
The mktemp write of /etc/hosts made set_hostname one line shorter, and the quality ratchet fails on a baseline entry that is no longer reached (stale). Lowered with napalm-standard ratchet --write. |
||
|
|
66828a9564 |
test(time-sync): follow napalm-device-types 4.36.0, which keeps DHCP's servers
driver / lowest (pull_request) Successful in 28s
driver / build (pull_request) Successful in 25s
driver / security (pull_request) Successful in 54s
CI / driver (pull_request) Successful in 2m3s
driver / standard (pull_request) Successful in 16s
driver / types (pull_request) Successful in 51s
driver / test (3.13) (pull_request) Successful in 53s
driver / test (3.12) (pull_request) Successful in 1m0s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 13s
napalm-device-types 4.36.0 (released after main's last CI run) changed PosixTimeSyncMixin: get_time_sync() reports DHCP-provided servers apart (dhcp_ntp_servers), and configure_time_sync() no longer comments out the DHCP client's chrony sourcedir; it gives back one that 4.35.0 took out (NetOrk/netork#2380). CI installs the newest release, so five time-sync tests failed on every branch. The tests now expect that behaviour, read DHCP's servers apart, and check that a node 4.35.0 aligned gets its DHCP sourcedir back. The floor moves to 4.36.0, so the lowest-versions job tests the same behaviour; README, CHANGELOG and the module docstring say what a write leaves alone. |
||
|
|
83d1ef780e |
test(time-sync): follow napalm-device-types 4.36.0, which keeps DHCP's servers
napalm-device-types 4.36.0 (released after main's last CI run) changed PosixTimeSyncMixin: get_time_sync() reports DHCP-provided servers apart (dhcp_ntp_servers), and configure_time_sync() no longer comments out the DHCP client's chrony sourcedir; it gives back one that 4.35.0 took out (NetOrk/netork#2380). CI installs the newest release, so five time-sync tests failed on every branch. The tests now expect that behaviour, read DHCP's servers apart, and check that a node 4.35.0 aligned gets its DHCP sourcedir back. The floor moves to 4.36.0, so the lowest-versions job tests the same behaviour; README, CHANGELOG and the module docstring say what a write leaves alone. |
||
|
|
a67e8492ee |
fix(system): set_hostname writes /etc/hosts through a mktemp file in /etc (#66)
driver / build (pull_request) Successful in 34s
driver / security (pull_request) Successful in 1m7s
CI / driver (pull_request) Failing after 2m48s
driver / standard (pull_request) Failing after 18s
driver / types (pull_request) Successful in 1m1s
driver / test (3.12) (pull_request) Failing after 1m8s
driver / test (3.13) (pull_request) Failing after 57s
driver / lowest (pull_request) Successful in 35s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 17s
The new /etc/hosts was written as root to the fixed /tmp/_netork_hosts and moved over /etc/hosts. A local user could create that file (or a symlink) beforehand: root's write went into the user's file, and the user owned /etc/hosts afterwards (NetOrk/netork#2446). The file is now made with mktemp beside the target (/etc/.hosts.XXXXXX, root's directory, same filesystem), written, set to 644 and moved into place; a failed step removes it. |
||
|
|
a13cd0202f |
fix(system): set_hostname quotes the name in its root commands (#64)
driver / build (pull_request) Successful in 30s
driver / security (pull_request) Successful in 1m19s
CI / driver (pull_request) Failing after 2m58s
driver / standard (pull_request) Successful in 18s
driver / types (pull_request) Successful in 57s
driver / test (3.12) (pull_request) Failing after 1m6s
driver / test (3.13) (pull_request) Failing after 1m6s
driver / lowest (pull_request) Successful in 35s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 15s
`postconf -e 'myhostname = <fqdn>'`, `hostname '<name>'` and the /etc/pve/nodes move put the name between single quotes of their own, so a name with a single quote ended them and the rest ran as root (NetOrk/netork#2456). Each value is now passed through shlex.quote. /etc/hostname, /etc/hosts and /etc/mailname were already written through base64. |
||
|
|
042b21d3d9 |
Merge pull request 'feat(time-sync): servers and zone on Proxmox VE and Backup Server' (#63) from feature/time-sync-2365 into main
driver / lint (push) Successful in 14s
driver / test (3.13) (push) Successful in 56s
driver / lowest (push) Successful in 30s
driver / build (push) Successful in 29s
driver / security (push) Successful in 57s
driver / publish (push) Skipped
driver / types (push) Successful in 56s
driver / test (3.12) (push) Successful in 1m4s
driver / standard (push) Successful in 14s
CI / driver (push) Successful in 2m28s
|
||
|
|
410d34bdee |
feat(time-sync): servers and zone on Proxmox VE and Backup Server
driver / lowest (pull_request) Successful in 32s
driver / build (pull_request) Successful in 31s
driver / security (pull_request) Successful in 1m11s
CI / driver (pull_request) Successful in 2m41s
driver / standard (pull_request) Successful in 14s
driver / lint (pull_request) Successful in 14s
driver / types (pull_request) Successful in 56s
driver / test (3.12) (pull_request) Successful in 1m2s
driver / test (3.13) (pull_request) Successful in 59s
driver / publish (pull_request) Skipped
netOrk keeps one list of NTP servers and a time zone per site and aligns a device that differs (NetOrk/netork#2360, #2365). Both drivers now implement napalm-device-types' TimeSyncMixin (4.35.0) and write both values. Neither API keeps time servers: /nodes/{node}/time knows only the zone, and both products run chrony on Debian. The servers are therefore PosixTimeSyncMixin's, over the driver's existing SSH session (run_command, root): read from chrony's configuration, written to /etc/chrony/sources.d/netork.sources with every other source commented out, then a reload or a restart of chrony. The zone is read with them from the host (timedatectl: the zone the clock really runs in), and from GET /nodes/{node}/time only where the host names none. It is written through PUT /nodes/{node}/time rather than timedatectl set-timezone: Proxmox's own call validates the name and keeps /etc/timezone, which its web UI and API show, in step with /etc/localtime. One device is one node: in a PVE cluster every node has its own clock, and only the node this connection resolved is read and written. get_ntp_servers() read GET /nodes/{node}/ntp, a path Proxmox VE does not have, so it always reported no servers. It now reports what get_time_sync() reads, on the backup server too. |
||
|
|
aeb12eae00 |
Merge pull request 'feat(running-backups): what a restart of a PVE node, a guest or a PBS would abort' (#62) from feature/running-backups-2318 into main
driver / lint (push) Successful in 14s
driver / test (3.13) (push) Successful in 1m9s
driver / lowest (push) Successful in 34s
driver / build (push) Successful in 31s
driver / security (push) Successful in 1m4s
driver / publish (push) Skipped
driver / types (push) Successful in 1m19s
driver / test (3.12) (push) Successful in 1m15s
driver / standard (push) Successful in 16s
CI / driver (push) Successful in 2m30s
|
||
|
|
3877a5425a |
feat(running-backups): what a restart of a PVE node, a guest or a PBS would abort
driver / lowest (pull_request) Successful in 31s
driver / build (pull_request) Successful in 26s
driver / security (pull_request) Successful in 54s
CI / driver (pull_request) Successful in 2m10s
driver / lint (pull_request) Successful in 13s
driver / standard (pull_request) Successful in 14s
driver / types (pull_request) Successful in 54s
driver / test (3.13) (pull_request) Successful in 1m2s
driver / test (3.12) (pull_request) Successful in 1m5s
driver / publish (pull_request) Skipped
netOrk holds a host's restart after patching while a backup runs on it, and a guest's restart while its hypervisor is backing it up (NetOrk/netork#2318). It asks right before the restart, so both drivers answer get_running_backups() from napalm-device-types 4.34.0: - PVE: the node's active vzdump tasks, each with the guests it is taking now (its own guest, or for a job the guests locked for their backup), and a guest locked without a task on its own, since the task list can lag and a lock can outlive its task. - PBS: the running backup, sync, verify, gc, prune and tape tasks; a restore or housekeeping is no backup. A failed read raises, so netOrk reads it as "not checked", never as "none". |
||
|
|
b1252878a5 |
Merge pull request 'feat(log-sources): which logs a PVE or PBS node writes' (#61) from feature/log-sources-2049 into main
driver / lint (push) Successful in 13s
driver / test (3.13) (push) Successful in 1m10s
driver / lowest (push) Successful in 44s
driver / build (push) Successful in 40s
driver / security (push) Successful in 1m11s
driver / publish (push) Skipped
driver / types (push) Successful in 57s
driver / test (3.12) (push) Successful in 1m10s
driver / standard (push) Successful in 16s
CI / driver (push) Successful in 2m36s
|
||
|
|
9c16586028 |
feat(log-sources): which logs a PVE or PBS node writes
driver / build (pull_request) Successful in 27s
driver / security (pull_request) Successful in 52s
CI / driver (pull_request) Successful in 2m16s
driver / standard (pull_request) Successful in 14s
driver / types (pull_request) Successful in 59s
driver / test (3.13) (pull_request) Successful in 1m10s
driver / test (3.12) (pull_request) Successful in 1m14s
driver / lowest (pull_request) Successful in 34s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 13s
Both drivers mix in napalm-device-types' LogSourcesMixin (4.30.0) and carry its command over the exec path, which runs as root either way. Refs NetOrk/netork#2049 |
||
|
|
1f88f50f15 |
Merge pull request 'feat(scheduled-jobs): scheduled jobs on Proxmox VE and Backup Server (#56)' (#59) from feature/scheduled-jobs into main
driver / lint (push) Successful in 20s
driver / test (3.13) (push) Successful in 1m15s
driver / lowest (push) Successful in 34s
driver / build (push) Successful in 31s
driver / security (push) Successful in 1m5s
driver / publish (push) Skipped
driver / types (push) Successful in 1m20s
driver / test (3.12) (push) Successful in 1m26s
driver / standard (push) Successful in 20s
CI / driver (push) Successful in 2m40s
Reviewed-on: #59 |
||
|
|
25363ac7b0 |
chore(scheduled-jobs): require napalm-device-types 4.27.0
driver / lowest (pull_request) Successful in 33s
driver / build (pull_request) Successful in 25s
driver / security (pull_request) Successful in 55s
CI / driver (pull_request) Successful in 2m12s
driver / lint (pull_request) Successful in 12s
driver / standard (pull_request) Successful in 15s
driver / types (pull_request) Successful in 53s
driver / test (3.13) (pull_request) Successful in 1m1s
driver / test (3.12) (pull_request) Successful in 1m6s
driver / publish (pull_request) Skipped
4.26.0 went out with the sshd drop-in change; the scheduled-jobs contract is in 4.27.0. |
||
|
|
4e7e29b598 |
docs(scheduled-jobs): a vzdump line only runs because of pmxcfs (#56)
driver / lowest (pull_request) Failing after 19s
driver / security (pull_request) Failing after 43s
driver / build (pull_request) Successful in 35s
CI / driver (pull_request) Failing after 1m35s
driver / standard (pull_request) Successful in 18s
driver / lint (pull_request) Successful in 15s
driver / test (3.12) (pull_request) Failing after 17s
driver / types (pull_request) Failing after 30s
driver / test (3.13) (pull_request) Failing after 15s
driver / publish (pull_request) Skipped
The guard is not about the link: napalm-device-types now writes the file a link names. /etc/cron.d/vzdump points into /etc/pve, the cluster file system, where installing a file with a mode and owner is not safe. Refs #56 |
||
|
|
dce794644c |
feat(scheduled-jobs): scheduled jobs on Proxmox VE and Backup Server (#56)
driver / build (pull_request) Successful in 33s
driver / security (pull_request) Failing after 37s
CI / driver (pull_request) Failing after 1m12s
driver / standard (pull_request) Successful in 19s
driver / types (pull_request) Failing after 28s
driver / test (3.13) (pull_request) Failing after 15s
driver / test (3.12) (pull_request) Failing after 17s
driver / lowest (pull_request) Failing after 19s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 15s
Both drivers mix in napalm-device-types' PosixScheduledJobsMixin over the node's root SSH session: get_scheduled_jobs reads cron, run-parts, anacron and every systemd timer in one round trip; manage_scheduled_job enables, disables or runs one now; put_ and delete_scheduled_job write and remove an application's own job. What Proxmox ships is platform, so it is only switched and run: pve-* units, pvesr.timer and /etc/cron.d/vzdump on Proxmox VE, proxmox-backup* units on a backup server. A vzdump cron line is only run, because the file is a link into /etc/pve and rewriting it would replace the link with a plain file. Backup jobs (/cluster/backup), replication and a backup server's verify, prune, sync and GC jobs run in Proxmox's own daemons and stay with the backup features. Requires napalm-device-types 4.26.0. Closes #56 |
||
|
|
d369f1ad76 |
Merge pull request 'chore(release): 0.10.0' (#58) from chore/release-0.10.0 into main
driver / lint (push) Successful in 15s
driver / test (3.13) (push) Successful in 1m12s
driver / lowest (push) Successful in 34s
driver / build (push) Successful in 33s
driver / security (push) Successful in 1m25s
driver / publish (push) Successful in 58s
driver / types (push) Successful in 1m13s
driver / test (3.12) (push) Successful in 1m21s
driver / standard (push) Successful in 19s
CI / driver (push) Successful in 4m20s
|
||
|
|
ff5018a3b4 |
chore(release): 0.10.0
driver / build (pull_request) Successful in 37s
driver / security (pull_request) Successful in 1m18s
CI / driver (pull_request) Successful in 3m5s
driver / standard (pull_request) Successful in 19s
driver / types (pull_request) Successful in 1m8s
driver / test (3.12) (pull_request) Successful in 1m10s
driver / test (3.13) (pull_request) Successful in 1m7s
driver / lowest (pull_request) Successful in 1m10s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 13s
|
||
|
|
ced34c35ba |
Merge pull request 'feat(clusters): name the backup server behind a pbs storage (#55)' (#57) from fix/pbs-storage-ref into main
driver / lint (push) Successful in 13s
driver / test (3.13) (push) Successful in 1m4s
driver / lowest (push) Successful in 40s
driver / build (push) Successful in 51s
driver / security (push) Successful in 1m17s
driver / publish (push) Skipped
driver / types (push) Successful in 54s
driver / test (3.12) (push) Successful in 1m8s
driver / standard (push) Successful in 15s
CI / driver (push) Successful in 2m37s
|
||
|
|
44b260b2c4 |
feat(clusters): name the backup server behind a pbs storage (#55)
driver / lowest (pull_request) Successful in 31s
driver / security (pull_request) Successful in 1m4s
driver / build (pull_request) Successful in 50s
CI / driver (pull_request) Successful in 3m31s
driver / lint (pull_request) Successful in 1m25s
driver / standard (pull_request) Successful in 1m26s
driver / types (pull_request) Successful in 2m17s
driver / test (3.13) (pull_request) Successful in 1m0s
driver / test (3.12) (pull_request) Successful in 1m15s
driver / publish (pull_request) Skipped
get_clusters() lists a pbs storage like any other, so nothing told an application which Proxmox Backup Server and datastore it writes to. Each pbs storage now carries ClusterStorageDict.backup_server (napalm-device-types 4.25.0): server, port, datastore, namespace and fingerprint from /storage, never the password or encryption key. An unreadable /storage leaves it None; other storages carry no such key. This was step 6 of #52 and was left out there. |
||
|
|
983553cf11 |
Merge pull request 'chore(release): 0.9.0' (#54) from chore/release-0.9.0 into main
driver / lint (push) Successful in 14s
driver / test (3.13) (push) Successful in 1m1s
driver / lowest (push) Successful in 32s
driver / build (push) Successful in 25s
driver / security (push) Successful in 59s
driver / publish (push) Successful in 25s
driver / types (push) Successful in 56s
driver / test (3.12) (push) Successful in 1m5s
driver / standard (push) Successful in 14s
CI / driver (push) Successful in 2m44s
|
||
|
|
0bb25a0c86 |
chore(release): 0.9.0
driver / lowest (pull_request) Successful in 30s
driver / build (pull_request) Successful in 25s
driver / security (pull_request) Successful in 53s
CI / driver (pull_request) Successful in 2m30s
driver / standard (pull_request) Successful in 14s
driver / lint (pull_request) Successful in 13s
driver / types (pull_request) Successful in 1m4s
driver / test (3.12) (pull_request) Successful in 1m9s
driver / test (3.13) (pull_request) Successful in 1m0s
driver / publish (pull_request) Skipped
|
||
|
|
c040dfdaa2 |
Merge pull request 'feat(pbs): Proxmox Backup Server as entry point proxmox_backup (#52)' (#53) from feat/proxmox-backup into main
driver / lint (push) Successful in 14s
driver / test (3.13) (push) Successful in 1m1s
driver / lowest (push) Successful in 34s
driver / build (push) Successful in 25s
driver / security (push) Successful in 59s
driver / publish (push) Skipped
driver / types (push) Successful in 58s
driver / test (3.12) (push) Successful in 1m8s
driver / standard (push) Successful in 14s
CI / driver (push) Successful in 2m15s
|
||
|
|
2b2cd9b867 |
feat(pbs): Proxmox Backup Server as entry point proxmox_backup (#52)
driver / lowest (pull_request) Successful in 31s
driver / build (pull_request) Successful in 30s
driver / security (pull_request) Successful in 1m0s
CI / driver (pull_request) Successful in 2m20s
driver / lint (pull_request) Successful in 14s
driver / standard (pull_request) Successful in 16s
driver / types (pull_request) Successful in 1m5s
driver / test (3.13) (pull_request) Successful in 1m4s
driver / test (3.12) (pull_request) Successful in 1m10s
driver / publish (pull_request) Skipped
A second driver in this package, ProxmoxBackupDriver. Its API and web UI are on 8007, not on PVE's 8006, and its node is always localhost; open() proves the login with GET /version, so a bad token fails there. Roles: BackupServerDriver (napalm-device-types 4.25.0) first, then StorageDriver for the disks and ZFS pools the server manages. It reads datastores, the backup groups of every namespace with their newest snapshot, a group's snapshots, the GC, verify, prune, sync and tape jobs with how their last run ended, and the remotes without their secrets; it starts garbage collection and jobs, verifies, protects and deletes snapshots, and follows the tasks. As a host it reports facts, interfaces, CPU and memory, disks, pools, its pbs-subscription and the same packages, updates, host readers and sshd hardening as a PVE node. A privilege-separated token without an ACL entry gets an empty list from PBS, not a refusal, so every read checks /access/permissions and raises PermissionError. A removable datastore that is not mounted is reported as unmounted and left out of the group listing. The fixture is what a PBS 4.2 answered, sanitised; groups, snapshots and jobs it did not have yet follow the API schema. |
||
|
|
0b5f82cc02 |
refactor: share connection and Debian host code for a second product (#52)
Proxmox Backup Server speaks the same REST dialect, logs in the same way and runs on Debian too, so what a second driver needs moves out of ProxmoxDriver first: - napalm_proxmox._base: the connection (proxmoxer service PVE or PBS, each with its port), the token split, the SSH session, run_command, the node helpers and the DMI read. - napalm_proxmox.host_mixin: packages and APT updates, the subscription, restart and shutdown through the API, root file writes and the transports of the host readers (kernel, listening sockets, identity, systemd, host status, apt's proxy). The PVE driver behaves as before; what it hands proxmoxer is pinned by tests first, and it now names service="PVE" explicitly. get_packages is split so the dpkg line parser stands alone; get_facts and get_packages leave the quality baseline. |
||
|
|
a4c220d2e3 |
Merge pull request 'feat(ssh): harden the node's sshd through a run_command channel (#50)' (#51) from feat/ssh-hardening into main
driver / lint (push) Successful in 14s
driver / lowest (push) Successful in 32s
driver / test (3.13) (push) Successful in 1m6s
driver / build (push) Successful in 26s
driver / security (push) Successful in 1m5s
driver / publish (push) Skipped
driver / test (3.12) (push) Failing after 5s
driver / types (push) Successful in 1m1s
driver / standard (push) Successful in 15s
CI / driver (push) Failing after 1m56s
|
||
|
|
8521cff935 |
Merge remote-tracking branch 'origin/main' into feat/ssh-hardening
driver / build (pull_request) Successful in 35s
driver / security (pull_request) Successful in 1m16s
CI / driver (pull_request) Successful in 3m4s
driver / standard (pull_request) Successful in 20s
driver / test (3.12) (pull_request) Successful in 1m25s
driver / types (pull_request) Successful in 1m27s
driver / test (3.13) (pull_request) Successful in 1m11s
driver / lowest (pull_request) Successful in 35s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 17s
|
||
|
|
321cef3426 |
Merge pull request 'fix(lldp): read lldpd through the shared parser and raise on failure' (#46) from fix/lldp-keyvalue into main
driver / lint (push) Successful in 22s
driver / test (3.13) (push) Successful in 1m7s
driver / lowest (push) Successful in 39s
driver / build (push) Failing after 7s
driver / security (push) Successful in 1m27s
driver / publish (push) Skipped
driver / types (push) Successful in 1m7s
driver / test (3.12) (push) Successful in 1m13s
driver / standard (push) Successful in 22s
CI / driver (push) Failing after 3m24s
|
||
|
|
d4ed73c52b |
Merge remote-tracking branch 'origin/main' into feat/ssh-hardening
driver / build (pull_request) Successful in 33s
driver / security (pull_request) Successful in 1m9s
CI / driver (pull_request) Successful in 3m7s
driver / standard (pull_request) Successful in 16s
driver / types (pull_request) Successful in 1m22s
driver / test (3.12) (pull_request) Successful in 1m27s
driver / test (3.13) (pull_request) Successful in 1m12s
driver / lowest (pull_request) Successful in 39s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 16s
|
||
|
|
7259c842e3 |
Merge remote-tracking branch 'origin/main' into fix/lldp-keyvalue
driver / lowest (pull_request) Successful in 31s
driver / build (pull_request) Successful in 30s
driver / security (pull_request) Successful in 1m9s
CI / driver (pull_request) Successful in 2m44s
driver / standard (pull_request) Successful in 16s
driver / types (pull_request) Successful in 58s
driver / test (3.12) (pull_request) Successful in 1m6s
driver / test (3.13) (pull_request) Successful in 57s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 12s
|
||
|
|
a73dcf79fe |
Merge pull request 'fix: SSH only with the given credentials, quote the snippet path (#48, #47)' (#49) from fix/bugs-2026-11-02b into main
driver / lint (push) Failing after 7s
driver / test (3.13) (push) Successful in 1m7s
driver / lowest (push) Successful in 35s
driver / build (push) Successful in 37s
driver / security (push) Successful in 1m9s
driver / publish (push) Skipped
driver / types (push) Successful in 1m12s
driver / test (3.12) (push) Successful in 1m17s
driver / standard (push) Successful in 17s
CI / driver (push) Failing after 2m50s
|
||
|
|
ef1900c32a |
feat(ssh): harden the node's sshd through a run_command channel (#50)
driver / build (pull_request) Successful in 34s
driver / security (pull_request) Successful in 1m13s
CI / driver (pull_request) Successful in 2m55s
driver / standard (pull_request) Successful in 19s
driver / types (pull_request) Successful in 1m13s
driver / test (3.12) (pull_request) Successful in 1m23s
driver / lowest (pull_request) Successful in 44s
driver / test (3.13) (pull_request) Successful in 1m23s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 15s
A Proxmox node runs Debian's stock OpenSSH, so OpenSshServerMixin works there as on a plain Linux host. What it needed was run_command: an exec channel on the node's SSH session, via napalm-device-types' run_on_transport. The USES_SSH comment said there was no SSH session; it now says what the flag means to netOrk. |
||
|
|
4ffe93fe4c |
Merge remote-tracking branch 'origin/main' into fix/lldp-keyvalue
driver / lowest (pull_request) Failing after 18s
driver / security (pull_request) Failing after 37s
driver / build (pull_request) Successful in 33s
CI / driver (pull_request) Failing after 1m39s
driver / standard (pull_request) Successful in 18s
driver / lint (pull_request) Successful in 15s
driver / test (3.12) (pull_request) Failing after 17s
driver / types (pull_request) Failing after 27s
driver / test (3.13) (pull_request) Failing after 15s
driver / publish (pull_request) Skipped
# Conflicts: # README.md # tests/test_misc.py |
||
|
|
dffb19e3df |
fix(vm-provision): quote the cloud-init snippet path in its root command
driver / build (pull_request) Successful in 33s
driver / security (pull_request) Successful in 1m21s
CI / driver (pull_request) Successful in 3m1s
driver / standard (pull_request) Successful in 17s
driver / types (pull_request) Successful in 1m4s
driver / test (3.12) (pull_request) Successful in 1m8s
driver / test (3.13) (pull_request) Successful in 1m4s
driver / lowest (pull_request) Successful in 39s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 14s
_write_snippet put the snippet storage's path and the snippet's file name unquoted into the command that writes the snippet as root on the node; a space, ; or $(...) in either was acted on by the shell. Both now go through shlex.quote, and a file name that is not one plain name (a path, a shell character) is refused before anything runs. Closes #47 |
||
|
|
b3fe5009c8 |
fix(ssh): log in only with the credentials the driver is given
paramiko's look_for_keys and allow_agent stayed at their default True, so the node login also tried every key in the running process's own ~/.ssh and any SSH agent it could reach. The driver standard lets a driver authenticate only with what it was handed; both are now False on every connect. Closes #48 |
||
|
|
b368ad9856 |
Merge pull request 'fix: quote the cloud image URL, raise when a node command cannot run (#43, #17)' (#45) from fix/bugs-2026-11-02 into main
driver / lint (push) Successful in 17s
driver / lowest (push) Successful in 34s
driver / test (3.13) (push) Successful in 1m8s
driver / build (push) Successful in 29s
driver / security (push) Successful in 1m13s
driver / publish (push) Skipped
driver / types (push) Successful in 1m15s
driver / test (3.12) (push) Successful in 1m26s
driver / standard (push) Successful in 17s
CI / driver (push) Successful in 3m7s
|
||
|
|
f93daa381e |
fix(lldp): read lldpd through the shared parser and raise on failure
driver / security (pull_request) Failing after 45s
driver / build (pull_request) Successful in 35s
CI / driver (pull_request) Failing after 1m43s
driver / standard (pull_request) Successful in 18s
driver / types (pull_request) Failing after 29s
driver / test (3.12) (pull_request) Failing after 20s
driver / test (3.13) (pull_request) Failing after 17s
driver / lowest (pull_request) Failing after 18s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 16s
lldpcli's text was read with 2>/dev/null || true, so lldpd not running, lldpctl missing or the command not running at all came back as a node without neighbours. Capabilities were lldpd's symbols lower-cased (tel, wlan, docsis) rather than NAPALM's names. The node now runs napalm-device-types' LLDPCTL_KEYVALUE_COMMAND, whose output carries lldpctl's exit status; parse_lldpctl_keyvalue raises on a failure, an empty answer raises too, and the lldp_neighbors projections give NAPALM's capability names and the chassis MAC. The module is under strict mypy now; the floor on napalm-device-types rises to 4.24.0. Closes #44 |
||
|
|
daf1b519eb |
fix(ssh): raise when a node command cannot run, drop the execute call
driver / build (pull_request) Successful in 40s
driver / security (pull_request) Successful in 1m15s
CI / driver (pull_request) Successful in 2m53s
driver / standard (pull_request) Successful in 18s
driver / types (pull_request) Successful in 1m10s
driver / test (3.12) (pull_request) Successful in 1m9s
driver / test (3.13) (pull_request) Successful in 1m4s
driver / lowest (pull_request) Successful in 35s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 16s
_exec_ssh_command returned "" on any failure (no SSH credential, a
refused login or host key, an unreachable node, a timeout), so a
getter that could not look read like one that found nothing; on
API-token-only nodes get_snmp_config answered None and the SSH-backed
getters empty lists on every poll. It now raises ConnectionException
with the cause (SshHostKeyMismatch as it is), and refuses before
connecting when there is neither a password nor a usable key.
It returned stderr when stdout was empty; output is stdout now. It
first posted every command to /nodes/{node}/execute, which runs a
batch of API calls rather than a shell; that dead round trip is gone.
The key types, the key before the password, the host-key check and the
single connect path were done in
|
||
|
|
bfba804ec2 |
fix(vm-provision): quote the image URL in the node's root commands
The cloud-image download put image_url, hand-wrapped in single quotes, and the cache path built from its basename unquoted into commands that run as root on the node: a quote, $(...), ; or space in a URL from a release feed was acted on by the shell. The URL and every path built from it now go through shlex.quote (exists check, wget, mv, checksum, rm, unpack, qm importdisk), and the cache file name keeps only the characters Proxmox keeps in a content file name, as the import volume name already did. The checksum algorithm is checked against the ones Proxmox knows, since it is part of the command name. The file-name helpers move to image_names.py; vm_provision_mixin.py would otherwise cross the 1000-line limit. _download_cloud_image drops below 50 lines, so its baseline entry goes. Closes #43 |
||
|
|
6a8132e234 |
Merge pull request 'fix: name the VM a failed create_vm_from_cloud_init leaves behind (#28)' (#41) from fix/half-built-vm-28 into main
driver / lint (push) Successful in 16s
driver / test (3.13) (push) Successful in 1m11s
driver / lowest (push) Successful in 46s
driver / build (push) Successful in 30s
driver / security (push) Successful in 1m13s
driver / publish (push) Skipped
driver / types (push) Successful in 1m2s
driver / test (3.12) (push) Successful in 1m21s
driver / standard (push) Successful in 16s
CI / driver (push) Successful in 2m40s
|
||
|
|
3233ee24a0 |
chore(deps): floor napalm-device-types at 4.23.0
driver / lowest (pull_request) Successful in 43s
driver / build (pull_request) Successful in 32s
driver / security (pull_request) Successful in 1m14s
CI / driver (pull_request) Successful in 2m47s
driver / standard (pull_request) Successful in 21s
driver / lint (pull_request) Successful in 24s
driver / types (pull_request) Successful in 1m12s
driver / test (3.13) (pull_request) Successful in 1m9s
driver / test (3.12) (pull_request) Successful in 1m21s
driver / publish (pull_request) Skipped
4.23.0 is on PyPI with everything this branch uses; the git pre-install in CI is no longer needed. |
||
|
|
0f1918f230 |
Merge remote-tracking branch 'origin/main' into fix/half-built-vm-28
# Conflicts: # CHANGELOG.md # tests/quality_baseline.json |
||
|
|
a8d73d95b4 |
Merge pull request 'fix: twelve open bugs, set_vlan uplink first (#37, #30, #23, #22, #21, #20, #19, #18, #17, #15, #12, #3)' (#40) from fix/bugs-2026-11 into main
driver / lint (push) Successful in 14s
driver / lowest (push) Successful in 37s
driver / test (3.13) (push) Successful in 1m24s
driver / build (push) Successful in 28s
driver / security (push) Successful in 1m17s
driver / publish (push) Skipped
driver / types (push) Successful in 1m27s
driver / test (3.12) (push) Successful in 1m43s
driver / standard (push) Successful in 17s
CI / driver (push) Successful in 3m33s
|
||
|
|
8dad7c3767 |
Merge pull request 'feat: HA state, backups and votes in get_clusters(); migrate_vm, preflight, maintenance' (#42) from feat/vm-lifecycle into main
driver / lint (push) Successful in 16s
driver / test (3.13) (push) Successful in 1m18s
driver / lowest (push) Successful in 1m0s
driver / build (push) Successful in 38s
driver / security (push) Successful in 1m31s
driver / publish (push) Skipped
driver / types (push) Successful in 1m12s
driver / test (3.12) (push) Successful in 1m20s
driver / standard (push) Successful in 18s
CI / driver (push) Successful in 3m16s
|
||
|
|
0704d9a102 |
feat: HA state, backups and votes in get_clusters(); migrate_vm, preflight, maintenance
driver / lowest (pull_request) Successful in 33s
driver / build (pull_request) Successful in 33s
driver / security (pull_request) Successful in 1m27s
CI / driver (pull_request) Successful in 3m4s
driver / standard (pull_request) Successful in 14s
driver / lint (pull_request) Successful in 13s
driver / types (pull_request) Successful in 1m3s
driver / test (3.12) (pull_request) Successful in 1m10s
driver / test (3.13) (pull_request) Successful in 1m3s
driver / publish (pull_request) Skipped
get_clusters() reads /cluster/ha/* (PVE 8 and 9), /cluster/backup with pool members, the newest backup per guest on each backup storage (PBS included) and /cluster/config/nodes votes; each read is best-effort. migrate_vm() moves a guest of the connected node and follows the task (HA-managed guests through the HA manager), raising with the task log's ERROR lines; get_vm_migration_preflight() maps PVE's own pre-flight; set_node_maintenance() runs ha-manager over SSH. Part of NetOrk/netork#1820 (stage 7: #759, #760, #761). |
||
|
|
61821cd607 |
fix: name the VM a failed create_vm_from_cloud_init leaves behind
driver / lowest (pull_request) Failing after 5s
driver / build (pull_request) Successful in 31s
driver / security (pull_request) Successful in 1m9s
CI / driver (pull_request) Failing after 2m49s
driver / standard (pull_request) Successful in 19s
driver / lint (pull_request) Successful in 15s
driver / types (pull_request) Successful in 1m5s
driver / test (3.12) (pull_request) Failing after 1m6s
driver / test (3.13) (pull_request) Failing after 58s
driver / publish (pull_request) Skipped
A failure after the VM shell existed (disk import, NIC or snippet config, start) raised without the VMID, so the caller could not remove the half-built VM and it stayed on the node. It now raises napalm-device-types' VMProvisionIncomplete with vmid and node, the failure as its cause. A failure before the shell exists raises as before. The NIC config strings are built by a helper of their own, which keeps create_vm_from_cloud_init within its quality baseline. Closes #28 |
||
|
|
8ef880b73b |
fix(hostname): refuse to rename a clustered node
driver / build (pull_request) Successful in 38s
driver / security (pull_request) Successful in 1m20s
CI / driver (pull_request) Successful in 3m12s
driver / standard (pull_request) Successful in 18s
driver / types (pull_request) Successful in 1m20s
driver / test (3.12) (pull_request) Successful in 1m26s
driver / lowest (pull_request) Successful in 43s
driver / test (3.13) (pull_request) Successful in 1m21s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 15s
The rename moves /etc/pve/nodes/<old> while the node still runs as <old>, which Proxmox does not support for a cluster member. set_hostname now checks for a corosync.conf first and raises before touching anything on a member, or when the check cannot be read; a single node renames as before. The check is the file, not `pvecm status`: pvecm decides membership by /etc/pve/corosync.conf itself, and its status also fails on a member whose corosync is down. /etc/corosync/corosync.conf covers a member whose /etc/pve is not mounted. Closes #21 |