feat(clusters): name the backup server behind a pbs storage (#55) #57

Merged
christianmanivong merged 1 commits from fix/pbs-storage-ref into main 2026-11-03 04:13:53 +00:00
Owner

Closes #55. Part of NetOrk/netork#1918 (step 6 of #52, which was left out there).

get_clusters() fills ClusterStorageDict.backup_server for each pbs storage from /storage: server, port, datastore, namespace, fingerprint, never the password or encryption key. An unreadable /storage leaves it None; other storages carry no such key (the existing storage tests are unchanged).

Checks

  • pytest: 603 passed (4 new in tests/test_clusters.py::TestBackupServerRef).
  • ruff, mypy --strict (only the known device-types-from-source notes), napalm-standard check, ratchet: clean.

Not checked live against a PVE yet; netOrk's link stage reads it from the real cluster on its first poll.

Closes #55. Part of NetOrk/netork#1918 (step 6 of #52, which was left out there). `get_clusters()` fills `ClusterStorageDict.backup_server` for each `pbs` storage from `/storage`: server, port, datastore, namespace, fingerprint, never the password or encryption key. An unreadable `/storage` leaves it `None`; other storages carry no such key (the existing storage tests are unchanged). ## Checks - `pytest`: 603 passed (4 new in `tests/test_clusters.py::TestBackupServerRef`). - ruff, `mypy --strict` (only the known device-types-from-source notes), `napalm-standard check`, ratchet: clean. Not checked live against a PVE yet; netOrk's link stage reads it from the real cluster on its first poll.
christianmanivong added the
prio
P2
enhancement
labels 2026-11-03 03:26:10 +00:00
christianmanivong added 1 commit 2026-11-03 03:26:10 +00:00
feat(clusters): name the backup server behind a pbs storage (#55)
driver / lint (pull_request) Successful in 1m25s
driver / standard (pull_request) Successful in 1m26s
driver / types (pull_request) Successful in 2m17s
driver / test (3.13) (pull_request) Successful in 1m0s
driver / test (3.12) (pull_request) Successful in 1m15s
driver / lowest (pull_request) Successful in 31s
driver / security (pull_request) Successful in 1m4s
driver / build (pull_request) Successful in 50s
CI / driver (pull_request) Successful in 3m31s
driver / publish (pull_request) Skipped
44b260b2c4
get_clusters() lists a pbs storage like any other, so nothing told an
application which Proxmox Backup Server and datastore it writes to.
Each pbs storage now carries ClusterStorageDict.backup_server
(napalm-device-types 4.25.0): server, port, datastore, namespace and
fingerprint from /storage, never the password or encryption key. An
unreadable /storage leaves it None; other storages carry no such key.

This was step 6 of #52 and was left out there.
christianmanivong merged commit ced34c35ba into main 2026-11-03 04:13:53 +00:00
christianmanivong deleted branch fix/pbs-storage-ref 2026-11-03 04:13:53 +00:00
Sign in to join this conversation.