LLDP: a failed lldpcli read returns {}, and capabilities carry lldpd's symbols instead of NAPALM's names #44

Closed
opened 2026-11-02 07:49:24 +00:00 by christianmanivong · 0 comments
Owner

What happens

napalm_proxmox/lldp_mixin.py parses lldpcli's text output itself:

  1. Every failure reads as "no neighbours" (lines 35 and 54):
    raw = self._exec_ssh_command("lldpcli show neighbors summary 2>/dev/null || true")
    
  2. Capabilities are lldpd's own symbols lower-cased (line 95: cap = m_cap.group(1).lower()), so a phone is tel, an access point wlan, a cable modem docsis — NAPALM's names are telephone, wlan-access-point, docsis-cable-device.

napalm-linux and napalm-openwrt read lldpctl -f keyvalue through the shared parser parse_lldpctl_keyvalue and its projections (napalm-device-types 4.24.0, NAPALM/napalm-device-types#78), which raise on a failed read and map capabilities to NAPALM's names.

Expected

The Proxmox driver uses LLDPCTL_KEYVALUE_COMMAND, parse_lldpctl_keyvalue and the projections lldp_neighbors / lldp_neighbors_detail; a failed read raises, {} only when lldpctl ran and listed no neighbour. Test-first: lldpctl failing raises; a neighbour with capability Tel reports telephone.

Priority: P3 — wrong capability names and a silently empty topology on PVE nodes.

Found during the bug sweep of 2026-11-02.

## What happens `napalm_proxmox/lldp_mixin.py` parses lldpcli's text output itself: 1. Every failure reads as "no neighbours" (lines 35 and 54): ```python raw = self._exec_ssh_command("lldpcli show neighbors summary 2>/dev/null || true") ``` 2. Capabilities are lldpd's own symbols lower-cased (line 95: `cap = m_cap.group(1).lower()`), so a phone is `tel`, an access point `wlan`, a cable modem `docsis` — NAPALM's names are `telephone`, `wlan-access-point`, `docsis-cable-device`. napalm-linux and napalm-openwrt read `lldpctl -f keyvalue` through the shared parser `parse_lldpctl_keyvalue` and its projections (napalm-device-types 4.24.0, NAPALM/napalm-device-types#78), which raise on a failed read and map capabilities to NAPALM's names. ## Expected The Proxmox driver uses `LLDPCTL_KEYVALUE_COMMAND`, `parse_lldpctl_keyvalue` and the projections `lldp_neighbors` / `lldp_neighbors_detail`; a failed read raises, `{}` only when lldpctl ran and listed no neighbour. Test-first: lldpctl failing raises; a neighbour with capability `Tel` reports `telephone`. Priority: P3 — wrong capability names and a silently empty topology on PVE nodes. Found during the bug sweep of 2026-11-02.
christianmanivong added the
prio
P3
bug
labels 2026-11-02 07:49:24 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-proxmox#44