Fix routines as templates; deprecate run_device_action #33

New Issue

2026-10-14T08:22:57Z

christianmanivong commented

2026-10-14 08:22:57 +00:00

run_device_action(action) is a string dispatch that drivers fill with the application's remediations: fix_snmp (eight drivers), fix_apt_proxy, fix_docker_permissions, install_lldpd, install_auc. Their values are hard-coded in the drivers (rocommunity public, sysContact netork@localhost, a firewall rule for the caller's /24).

Change: one template per purpose. The template runs declared steps in order and stops at the first failure; a driver implements the steps, or overrides the whole method when its device does it in one call (OPNsense). Every value comes from the caller.

Today	Template
`fix_snmp`	`configure_snmp_agent(settings: SnmpAgentSettingsDict)`
`fix_apt_proxy`	`configure_package_proxy(url)`
`fix_docker_permissions`	`grant_container_engine_access(user)`
`install_lldpd`, `install_auc`	`ensure_package(name)`

Add SnmpAgentSettingsDict (community, allowed sources, contact, location), FixStepDict and FixResultDict. The mixins are mixed in by drivers, not by role bases, so hasattr stays truthful. Deprecate run_device_action and DeviceActionResultDict.

Replaces #14.

Part of NetOrk/netork#1105. Plan: NAPALM/napalm-device-types docs/STRUCTURE.md (branch docs/structure-plan).

Prio P3.

`run_device_action(action)` is a string dispatch that drivers fill with the application's remediations: `fix_snmp` (eight drivers), `fix_apt_proxy`, `fix_docker_permissions`, `install_lldpd`, `install_auc`. Their values are hard-coded in the drivers (`rocommunity public`, `sysContact netork@localhost`, a firewall rule for the caller's /24). **Change:** one template per purpose. The template runs declared steps in order and stops at the first failure; a driver implements the steps, or overrides the whole method when its device does it in one call (OPNsense). Every value comes from the caller. | Today | Template | |---|---| | `fix_snmp` | `configure_snmp_agent(settings: SnmpAgentSettingsDict)` | | `fix_apt_proxy` | `configure_package_proxy(url)` | | `fix_docker_permissions` | `grant_container_engine_access(user)` | | `install_lldpd`, `install_auc` | `ensure_package(name)` | Add `SnmpAgentSettingsDict` (community, allowed sources, contact, location), `FixStepDict` and `FixResultDict`. The mixins are mixed in by drivers, not by role bases, so `hasattr` stays truthful. Deprecate `run_device_action` and `DeviceActionResultDict`. Replaces #14. Part of NetOrk/netork#1105. Plan: NAPALM/napalm-device-types `docs/STRUCTURE.md` (branch `docs/structure-plan`). Prio P3.

christianmanivong referenced this issue from NAPALM/napalm-linux

2026-10-14 08:22:58 +00:00

Fix actions become template steps; drop apt_proxy_url, the sudo hint and apt_update_upgrade #27

christianmanivong referenced this issue from NAPALM/napalm-bsd

2026-10-14 08:22:58 +00:00

fix_snmp becomes the SNMP template's steps #12

christianmanivong referenced this issue

2026-10-14 08:23:27 +00:00

docs: a structure that keeps device-types vendor- and product-agnostic #37

christianmanivong referenced this issue

2026-10-14 08:23:27 +00:00

Linux userland helpers shared by linux, proxmox and openwrt (snmpd, lldpctl, apk, package names) #13