Agnostic structure: drop the run_device_action wrapper #3

New Issue

2026-10-14T08:58:53Z

christianmanivong commented

2026-10-14 08:58:53 +00:00

What this driver has to change for the agnostic structure (NAPALM/napalm-device-types docs/STRUCTURE.md (NAPALM/napalm-device-types#37), epic NetOrk/netork#1105).

run_device_action (play, pause, stop, next/previous, set_volume:N, toggle_mute) returns {success, action, message} instead of DeviceActionResultDict. These are media controls, not fixes; the typed methods (play(), set_volume(), …) already exist. Drop the wrapper when run_device_action is deprecated (NAPALM/napalm-device-types#33).

Size: small. Needs: NAPALM/napalm-device-types#33.

Prio P3.

What this driver has to change for the agnostic structure (NAPALM/napalm-device-types `docs/STRUCTURE.md` (NAPALM/napalm-device-types#37), epic NetOrk/netork#1105). - `run_device_action` (play, pause, stop, next/previous, `set_volume:N`, toggle_mute) returns `{success, action, message}` instead of `DeviceActionResultDict`. These are media controls, not fixes; the typed methods (`play()`, `set_volume()`, …) already exist. Drop the wrapper when `run_device_action` is deprecated (NAPALM/napalm-device-types#33). Size: small. Needs: NAPALM/napalm-device-types#33. Prio P3.

christianmanivong referenced this issue from a commit

2026-10-17 06:39:32 +00:00

refactor!: drop run_device_action; the media controls are methods (0.2.0)

christianmanivong referenced a pull request that will close this issue

2026-10-17 06:39:32 +00:00

refactor!: drop run_device_action; the media controls are methods (0.2.0) #4

christianmanivong closed this issue

2026-10-17 06:51:53 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: NAPALM/napalm-sonos#3