NAPALM/napalm-openwrt
1
0 Fork 0
Code Issues 8 Pull Requests Actions 1 Packages Projects Releases Wiki Activity

get_lldp_neighbors starts lldpd and rewrites its configuration on every poll #8

New Issue
Open
opened 2026-10-14 08:58:50 +00:00 by christianmanivong · 0 comments
christianmanivong commented 2026-10-14 08:58:50 +00:00
Owner
Copy link
Copy source

_get_lldp_table (lldp_mixin.py ~66-78) runs /etc/init.d/lldpd enable; start and _lldpd_fix_interface(), which may uci delete/uci commit and restart lldpd. It runs inside get_lldp_neighbors, which the application calls on every poll. A getter must not change the device.

Fix: read only. Starting and configuring lldpd belongs to ensure_package plus a configuration step with interfaces from the caller (NAPALM/napalm-device-types#33).

Prio P3: every poll can restart lldpd.

`_get_lldp_table` (`lldp_mixin.py` ~66-78) runs `/etc/init.d/lldpd enable; start` and `_lldpd_fix_interface()`, which may `uci delete`/`uci commit` and restart lldpd. It runs inside `get_lldp_neighbors`, which the application calls on every poll. A getter must not change the device. Fix: read only. Starting and configuring lldpd belongs to `ensure_package` plus a configuration step with interfaces from the caller (NAPALM/napalm-device-types#33). Prio P3: every poll can restart lldpd.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Something is broken
 enhancement
New feature or request
 tech-debt
Refactoring / cleanup / deferred debt
prio
P0
Road blocker: blocks other work, drop everything
prio
P1
Critical
prio
P2
Important and urgent
prio
P3
Important, not urgent
prio
P4
Neither important nor urgent
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
christianmanivong
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-openwrt#8