get_facts read SerialNumber and SystemUpTime from getBasicInformation, which a VMG4005-B50A (V5.17(ABQA.3.1)C0) does not send, and reported serial_number: '' and uptime: 0. The gateway has both in DeviceInfo of the DAL's cardpage_status, the answer the interfaces are read from (#23).
get_facts reads cardpage_status once and takes the interfaces, serial number and uptime from it (_interfaces(page) is shared with get_interfaces)
model and firmware stay with getBasicInformation, which carries them
a status page without DeviceInfo reports "" and 0 (unknown); one that cannot be read makes get_facts raise, as before
Tests: tests/test_facts.py with that gateway's answers; 94 passed, ruff, mypy and the standard's ratchet clean.
Closes #27
`get_facts` read `SerialNumber` and `SystemUpTime` from `getBasicInformation`, which a VMG4005-B50A (V5.17(ABQA.3.1)C0) does not send, and reported `serial_number: ''` and `uptime: 0`. The gateway has both in `DeviceInfo` of the DAL's `cardpage_status`, the answer the interfaces are read from (#23).
- `get_facts` reads `cardpage_status` once and takes the interfaces, serial number and uptime from it (`_interfaces(page)` is shared with `get_interfaces`)
- model and firmware stay with `getBasicInformation`, which carries them
- a status page without `DeviceInfo` reports `""` and `0` (unknown); one that cannot be read makes `get_facts` raise, as before
Tests: `tests/test_facts.py` with that gateway's answers; 94 passed, ruff, mypy and the standard's ratchet clean.
get_facts read SerialNumber and SystemUpTime from getBasicInformation,
which a VMG4005-B50A does not send, and reported "" and 0. The gateway
has both in DeviceInfo of the DAL's cardpage_status, the answer the
interfaces are read from. get_facts now reads that answer once and takes
the interfaces, serial number and uptime from it. Model and firmware stay
with getBasicInformation, which does carry them.
Closes#27
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #27
get_factsreadSerialNumberandSystemUpTimefromgetBasicInformation, which a VMG4005-B50A (V5.17(ABQA.3.1)C0) does not send, and reportedserial_number: ''anduptime: 0. The gateway has both inDeviceInfoof the DAL'scardpage_status, the answer the interfaces are read from (#23).get_factsreadscardpage_statusonce and takes the interfaces, serial number and uptime from it (_interfaces(page)is shared withget_interfaces)getBasicInformation, which carries themDeviceInforeports""and0(unknown); one that cannot be read makesget_factsraise, as beforeTests:
tests/test_facts.pywith that gateway's answers; 94 passed, ruff, mypy and the standard's ratchet clean.