Merge pull request 'feat(provisioning): accept cpu_type, and refuse one that cannot be honoured' (#2) from feat/vm-cpu-type into main

napalm_vmware/provisioning.py

@@ -147,9 +147,14 @@ class VmwareProvisioningMixin:
         ssh_public_keys: list[str] | None = None,
         disk_resize_gb: int | None = None,
         storage: str | None = None,
+        cpu_type: str | None = None,
         download_timeout: int = 300,
         timeout: int = 180,
     ) -> VMProvisionResultDict:
+        if cpu_type is not None:
+            # CPU compatibility is a cluster setting here (EVC), not a per-VM
+            # one, and there is no get_vm_cpu_types() that could offer a model.
+            raise ValueError(f"VMware cannot give a single VM a CPU type ({cpu_type!r})")
         self._check_nics(nics)
         try:
             vmdk, image_size = ImageCache(self._image_cache_dir).vmdk(

tests/test_provisioning.py

@@ -141,6 +141,17 @@ class TestCreate:
             _create(driver)
         staged.discard.assert_called_once_with("vm-99")
 
+    def test_no_cpu_type_is_the_normal_case(self, driver, staged):
+        assert _create(driver, cpu_type=None)["vmid"] == "uuid-99"
+
+    def test_a_cpu_type_is_refused_before_anything_happens(self, driver, staged):
+        """VMware sets CPU compatibility per cluster (EVC), not per VM, so a
+        requested model cannot be honoured -- and is not silently dropped."""
+        with pytest.raises(ValueError, match="CPU type"):
+            _create(driver, cpu_type="host")
+        staged.cache.return_value.vmdk.assert_not_called()
+        staged.import_ovf.assert_not_called()
+
     def test_placement_refusal_is_a_runtime_error(self, driver, staged):
         with patch.object(prov, "choose_placement", side_effect=ValueError("no host")):
             with pytest.raises(RuntimeError, match="no host"):