NAPALM/napalm-vmware
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

feat(provisioning): accept cpu_type, and refuse one that cannot be honoured #2

Open
christianmanivong wants to merge 1 commits from feat/vm-cpu-type into main
pull from: feat/vm-cpu-type
merge into: :main
Conversation 0 Commits 1 Files Changed 2
+16
christianmanivong commented 2026-10-04 10:03:10 +00:00
Owner
Copy Link
Copy Source

Follows the cpu_type argument added to create_vm_from_cloud_init in NAPALM/napalm-device-types feat/vm-cpu-type (NetOrk/netork#494).

VMware sets CPU compatibility per cluster (EVC), not per VM, and this driver offers no get_vm_cpu_types(), so None is the only value it accepts. Any other value raises ValueError before the image is fetched, rather than being silently dropped.

Follows the `cpu_type` argument added to `create_vm_from_cloud_init` in NAPALM/napalm-device-types `feat/vm-cpu-type` (https://git.netork.io/NetOrk/netork/issues/494). VMware sets CPU compatibility per cluster (EVC), not per VM, and this driver offers no `get_vm_cpu_types()`, so `None` is the only value it accepts. Any other value raises `ValueError` before the image is fetched, rather than being silently dropped.
christianmanivong added 1 commit 2026-10-04 10:03:10 +00:00
feat(provisioning): accept cpu_type, and refuse one that cannot be honoured 4b4410741f 
napalm_device_types' create_vm_from_cloud_init gained cpu_type, the CPU model
a new VM gets (netork#494). VMware sets CPU compatibility per cluster (EVC),
not per VM, and this driver has no get_vm_cpu_types() to offer a model, so
None is the only value it can honour. Anything else raises ValueError before
the image is fetched rather than being dropped silently.
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feat/vm-cpu-type:feat/vm-cpu-type
git checkout feat/vm-cpu-type
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
christianmanivong
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-vmware#2