feat(provisioning): accept cpu_type, and refuse one that cannot be honoured #2

2026-10-04T10:03:10Z

christianmanivong commented

2026-10-04 10:03:10 +00:00

Follows the cpu_type argument added to create_vm_from_cloud_init in NAPALM/napalm-device-types feat/vm-cpu-type (NetOrk/netork#494).

VMware sets CPU compatibility per cluster (EVC), not per VM, and this driver offers no get_vm_cpu_types(), so None is the only value it accepts. Any other value raises ValueError before the image is fetched, rather than being silently dropped.

Follows the `cpu_type` argument added to `create_vm_from_cloud_init` in NAPALM/napalm-device-types `feat/vm-cpu-type` (https://git.netork.io/NetOrk/netork/issues/494). VMware sets CPU compatibility per cluster (EVC), not per VM, and this driver offers no `get_vm_cpu_types()`, so `None` is the only value it accepts. Any other value raises `ValueError` before the image is fetched, rather than being silently dropped.

christianmanivong added 1 commit 2026-10-04 10:03:10 +00:00

feat(provisioning): accept cpu_type, and refuse one that cannot be honoured 4b4410741f

napalm_device_types' create_vm_from_cloud_init gained cpu_type, the CPU model
a new VM gets (netork#494). VMware sets CPU compatibility per cluster (EVC),
not per VM, and this driver has no get_vm_cpu_types() to offer a model, so
None is the only value it can honour. Anything else raises ValueError before
the image is fetched rather than being dropped silently.

christianmanivong merged commit b5bc04ec83 into main

2026-10-04 15:42:17 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: NAPALM/napalm-vmware#2