NAPALM/napalm-hpe-aruba-procurve
1
0 Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

use napalm-device-types helpers; remove dead _detect_management_vlan #6

New Issue
Open
opened 2026-10-06 17:31:30 +00:00 by christianmanivong · 1 comment
christianmanivong commented 2026-10-06 17:31:30 +00:00
Owner
Copy link
Copy source
  • MAC normalisation. parsers.py:19 procurve_mac_to_std re-implements napalm_device_types.normalize_mac, but returns the input unchanged when it is invalid. The base returns it lowercased.
  • Dead code. ProcurveDriver._detect_management_vlan (procurve.py:1216) has no caller.
  • LLDP read twice. api_client.py:393 and :407 both GET lldp/remote-device and project it separately. The detail call ignores its interface filter (procurve.py:569). This folds into NAPALM/napalm-device-types#10.
  • Port sort. The natural port sort at procurve.py:483 copies lag.py _port_order; see NAPALM/napalm-device-types#11.

Prio P4.

From the NetOrk function index (NetOrk/netork#670); every location was checked against the current code. Paths are relative to each driver repo.

- **MAC normalisation.** `parsers.py`:19 `procurve_mac_to_std` re-implements `napalm_device_types.normalize_mac`, but returns the input unchanged when it is invalid. The base returns it lowercased. - **Dead code.** `ProcurveDriver._detect_management_vlan` (`procurve.py`:1216) has no caller. - **LLDP read twice.** `api_client.py`:393 and :407 both GET `lldp/remote-device` and project it separately. The detail call ignores its `interface` filter (`procurve.py`:569). This folds into NAPALM/napalm-device-types#10. - **Port sort.** The natural port sort at `procurve.py`:483 copies `lag.py` `_port_order`; see NAPALM/napalm-device-types#11. Prio P4. From the NetOrk function index (NetOrk/netork#670); every location was checked against the current code. Paths are relative to each driver repo.
christianmanivong commented 2026-10-14 08:59:08 +00:00
Author
Owner
Copy link
Copy source

Under NAPALM/napalm-device-types docs/STRUCTURE.md (NAPALM/napalm-device-types#37) shared CLI helpers do not go into napalm-device-types; agnostic helpers such as add_lag_interfaces may still be used. Removing _detect_management_vlan is part of NAPALM/napalm-hpe-aruba-procurve#12.

Under NAPALM/napalm-device-types `docs/STRUCTURE.md` (NAPALM/napalm-device-types#37) shared CLI helpers do not go into napalm-device-types; agnostic helpers such as `add_lag_interfaces` may still be used. Removing `_detect_management_vlan` is part of NAPALM/napalm-hpe-aruba-procurve#12.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Something is broken
 enhancement
New feature or request
 tech-debt
Refactoring / cleanup / deferred debt
prio
P0
Road blocker: blocks other work, drop everything
prio
P1
Critical
prio
P2
Important and urgent
prio
P3
Important, not urgent
prio
P4
Neither important nor urgent
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
christianmanivong
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-hpe-aruba-procurve#6