NAPALM/napalm-hpe-aruba-procurve
1
0 Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Agnostic structure: SNMP profile and fix_snmp template #12

New Issue
Open
opened 2026-10-14 08:58:52 +00:00 by christianmanivong · 2 comments
christianmanivong commented 2026-10-14 08:58:52 +00:00
Owner
Copy link
Copy source

What this driver has to change for the agnostic structure (NAPALM/napalm-device-types docs/STRUCTURE.md (NAPALM/napalm-device-types#37), epic NetOrk/netork#1105).

  • get_health_metrics (~1302-1356) goes; SNMP_HEALTH_PROFILE declares uptime, the CPU OIDs as a fallback list (_HP_CPU_STAT, then _HP_CPU_STAT_OLD) and memory in bytes (NAPALM/napalm-device-types#32). The private import of _ucd_metrics goes. Only 32-bit IF counters are read today; the application uses HC first.
  • run_device_action("fix_snmp") becomes configure_snmp_agent(settings) (NAPALM/napalm-device-types#33); snmp-server community "public" manager restricted takes community, contact, location and sources from settings, and success is an exact match. The temporary SSH session from REST stays (device communication); api_client.configure_snmp_community (unused) could make it unnecessary.
  • Dead code: _detect_management_vlan (also #6), configure_snmp_community. get_device_warnings returns [] and goes.
  • Fingerprint: comware is H3C, not ProCurve (possible false positive).
  • Note on #6: shared CLI helpers do not go into napalm-device-types under the new structure.

Size: medium. Needs: NAPALM/napalm-device-types#32, NAPALM/napalm-device-types#33.

Prio P3.

What this driver has to change for the agnostic structure (NAPALM/napalm-device-types `docs/STRUCTURE.md` (NAPALM/napalm-device-types#37), epic NetOrk/netork#1105). - `get_health_metrics` (~1302-1356) goes; `SNMP_HEALTH_PROFILE` declares uptime, the CPU OIDs as a fallback list (`_HP_CPU_STAT`, then `_HP_CPU_STAT_OLD`) and memory in bytes (NAPALM/napalm-device-types#32). The private import of `_ucd_metrics` goes. Only 32-bit IF counters are read today; the application uses HC first. - `run_device_action("fix_snmp")` becomes `configure_snmp_agent(settings)` (NAPALM/napalm-device-types#33); `snmp-server community "public" manager restricted` takes community, contact, location and sources from `settings`, and success is an exact match. The temporary SSH session from REST stays (device communication); `api_client.configure_snmp_community` (unused) could make it unnecessary. - Dead code: `_detect_management_vlan` (also #6), `configure_snmp_community`. `get_device_warnings` returns `[]` and goes. - Fingerprint: `comware` is H3C, not ProCurve (possible false positive). - Note on #6: shared CLI helpers do not go into napalm-device-types under the new structure. Size: medium. Needs: NAPALM/napalm-device-types#32, NAPALM/napalm-device-types#33. Prio P3.
christianmanivong commented 2026-10-18 12:44:03 +00:00
Author
Owner
Copy link
Copy source

Status 2026-10-18, checked against the pin on NetOrk/netork main.

Done: SNMP_HEALTH_PROFILE replaces get_health_metrics (memory fixed live); configure_snmp_agent(settings) replaces fix_snmp (0.3.0/0.4.0); _detect_management_vlan is gone.

Rest:

  • api_client.configure_snmp_community (unused) is still there.
  • get_device_warnings returns [] and can go.
  • Fingerprint comware (H3C) is still a ProCurve rule (procurve.py:107).
Status 2026-10-18, checked against the pin on NetOrk/netork main. **Done:** `SNMP_HEALTH_PROFILE` replaces `get_health_metrics` (memory fixed live); `configure_snmp_agent(settings)` replaces `fix_snmp` (0.3.0/0.4.0); `_detect_management_vlan` is gone. **Rest:** - `api_client.configure_snmp_community` (unused) is still there. - `get_device_warnings` returns `[]` and can go. - Fingerprint `comware` (H3C) is still a ProCurve rule (`procurve.py:107`).
christianmanivong commented 2026-10-18 12:55:07 +00:00
Author
Owner
Copy link
Copy source

Reboot: netOrk no longer falls back to sending /sbin/reboot through _send_command (NetOrk/netork#1162) — on this CLI the command never existed, and the reboot was reported done anyway. Until this driver implements reboot_host() (napalm-device-types HostRebootMixin) with its own CLI command and prompts, netOrk does not offer a reboot for it. Needs a test on real hardware.

Likely command: reload (confirm y, possibly "save configuration?").

**Reboot:** netOrk no longer falls back to sending `/sbin/reboot` through `_send_command` (NetOrk/netork#1162) — on this CLI the command never existed, and the reboot was reported done anyway. Until this driver implements `reboot_host()` (napalm-device-types `HostRebootMixin`) with its own CLI command and prompts, netOrk does not offer a reboot for it. Needs a test on real hardware. Likely command: `reload` (confirm `y`, possibly "save configuration?").
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Something is broken
 enhancement
New feature or request
 tech-debt
Refactoring / cleanup / deferred debt
prio
P0
Road blocker: blocks other work, drop everything
prio
P1
Critical
prio
P2
Important and urgent
prio
P3
Important, not urgent
prio
P4
Neither important nor urgent
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
christianmanivong
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-hpe-aruba-procurve#12