NAPALM/napalm-hpe-aruba-procurve
1
0 Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

feat!: configure_snmp_agent with the caller's values replaces fix_snmp (0.4.0) #15

Merged
christianmanivong merged 2 commits from feat/snmp-agent-template into master 2026-10-17 06:48:20 +00:00
Conversation 0 Commits 2 Files Changed 17
+165 -244
christianmanivong commented 2026-10-17 06:35:31 +00:00
Owner
Copy link
Copy source

Step 4 of NetOrk/netork#1105.

  • configure_snmp_agent(settings) overridden as a whole (over REST a temporary SSH session runs the CLI): community (read-only), contact, location from the caller; saved; verified in show snmp-server. Install/firewall steps say honestly that the agent is built in and sources are not enforced on the switch. Bad values refused.
  • run_device_action, _action_fix_snmp* and the dead _detect_management_vlan gone.
  • Separate commit: napalm-device-types declared as dependency (≥ 4.13), tracked .pyc/egg-info removed, .gitignore added (closes #11).

An existing community (e.g. public) is left on the switch; netOrk only adds its own.

Closes #11. Part of #12 and #6.

Step 4 of NetOrk/netork#1105. - `configure_snmp_agent(settings)` overridden as a whole (over REST a temporary SSH session runs the CLI): community (read-only), contact, location from the caller; saved; verified in `show snmp-server`. Install/firewall steps say honestly that the agent is built in and sources are not enforced on the switch. Bad values refused. - `run_device_action`, `_action_fix_snmp*` and the dead `_detect_management_vlan` gone. - Separate commit: `napalm-device-types` declared as dependency (≥ 4.13), tracked `.pyc`/egg-info removed, `.gitignore` added (closes #11). An existing community (e.g. `public`) is left on the switch; netOrk only adds its own. Closes #11. Part of #12 and #6.
christianmanivong added 2 commits 2026-10-17 06:35:31 +00:00
chore: declare napalm-device-types, stop tracking build artefacts 0c0ab7c988 
pyproject.toml did not list napalm-device-types although the code
imports it (CI installed it by hand); it now requires 4.13, whose fix
templates the next commit uses. Seven .pyc and six egg-info files were
tracked; they go, and a .gitignore keeps them out.

Closes #11
feat!: configure_snmp_agent with the caller's values replaces fix_snmp (0.4.0)
CI / test (3.10) (push) Successful in 24s
Details
CI / test (3.11) (push) Successful in 24s
Details
CI / test (3.12) (push) Successful in 24s
Details
CI / test (3.10) (pull_request) Successful in 24s
Details
CI / test (3.11) (pull_request) Successful in 23s
Details
CI / test (3.12) (pull_request) Successful in 24s
Details
0527cd20c1 
fix_snmp hard-coded community "public". The driver implements
napalm-device-types 4.13's configure_snmp_agent as a whole, because
over REST a temporary SSH session has to run the config-mode CLI:
community (read-only), contact and location from the caller, saved
and verified in show snmp-server. The agent is built in and the switch
filters nothing for its management plane; the steps say so instead of
pretending. A value that would break the CLI is refused.

The unused _detect_management_vlan goes with it.

BREAKING CHANGE: run_device_action is removed.

Part of #12 and #6 (the dead helper).
christianmanivong merged commit 382519f780 into master 2026-10-17 06:48:20 +00:00
christianmanivong deleted branch feat/snmp-agent-template 2026-10-17 06:48:20 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is broken
 enhancement
New feature or request
 tech-debt
Refactoring / cleanup / deferred debt
prio
P0
Road blocker: blocks other work, drop everything
prio
P1
Critical
prio
P2
Important and urgent
prio
P3
Important, not urgent
prio
P4
Neither important nor urgent
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
christianmanivong
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-hpe-aruba-procurve#15