NAPALM/napalm-yealink
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: drop stubs that claim what a phone cannot do (0.1.1) #3

Merged
christianmanivong merged 1 commits from chore/drop-snmp-stub into master 2026-10-16 23:07:00 +00:00
Conversation 0 Commits 1 Files Changed 12
+15 -42
christianmanivong commented 2026-10-16 10:04:03 +00:00
Owner
Copy link
Copy source
  • get_health_metrics, get_ssids, get_radio_info, get_wireless_clients only raised NotImplementedError (leftovers from AccessPointDriver); a stub makes a capability check answer yes.
  • Stops tracking .pyc and egg-info files .gitignore already lists.

Closes #2

With NetOrk/netork#1129 a phone is no longer SNMP-polled (today it is, and the stub raises every time). Part of NetOrk/netork#1105.

- `get_health_metrics`, `get_ssids`, `get_radio_info`, `get_wireless_clients` only raised `NotImplementedError` (leftovers from `AccessPointDriver`); a stub makes a capability check answer yes. - Stops tracking `.pyc` and egg-info files `.gitignore` already lists. Closes #2 With NetOrk/netork#1129 a phone is no longer SNMP-polled (today it is, and the stub raises every time). Part of NetOrk/netork#1105.
christianmanivong added 1 commit 2026-10-16 10:04:03 +00:00
fix: drop stubs that claim what a phone cannot do (0.1.1)
CI / test (3.10) (push) Successful in 29s
Details
CI / test (3.11) (push) Successful in 26s
Details
CI / test (3.12) (push) Successful in 28s
Details
CI / test (3.10) (pull_request) Successful in 30s
Details
CI / test (3.11) (pull_request) Successful in 28s
Details
CI / test (3.12) (pull_request) Successful in 29s
Details
46ff971953 
get_health_metrics, get_ssids, get_radio_info and get_wireless_clients
only raised NotImplementedError. They are left over from when the
driver sat on AccessPointDriver, and a stub makes a capability check
(callable(getattr(driver, name))) answer yes. The application polls
SNMP itself (napalm-device-types docs/STRUCTURE.md); a phone has no
profile to declare.

Also stops tracking the .pyc and egg-info files .gitignore already
lists.

Closes #2
christianmanivong merged commit 8d38e6f119 into master 2026-10-16 23:07:00 +00:00
christianmanivong deleted branch chore/drop-snmp-stub 2026-10-16 23:07:00 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is broken
 enhancement
New feature or request
 tech-debt
Refactoring / cleanup / deferred debt
prio
P0
Road blocker: blocks other work, drop everything
prio
P1
Critical
prio
P2
Important and urgent
prio
P3
Important, not urgent
prio
P4
Neither important nor urgent
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
christianmanivong
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-yealink#3