fix(accounts): switch off remove_local_account_keys on QTS
driver / standard (pull_request) Successful in 18s
driver / lint (pull_request) Successful in 19s
driver / types (pull_request) Successful in 1m16s
driver / test (3.12) (pull_request) Successful in 1m14s
driver / test (3.13) (pull_request) Successful in 1m5s
driver / lowest (pull_request) Successful in 41s
driver / build (pull_request) Successful in 32s
driver / security (pull_request) Successful in 1m11s
CI / driver (pull_request) Successful in 3m2s
driver / publish (pull_request) Skipped

napalm-linux 0.17.0 brings napalm-device-types' new
remove_local_account_keys to every LinuxDriver. QTS has the other
personal-account actions switched off, as it manages its users in its
own UI; without this one a capability check would say QTS can take keys
off an account.

See NetOrk/netork#2013
This commit is contained in:
Christian Manivong committed 2026-11-04 11:49:38 +01:00
1 parent b27dbab939
commit f3f263cf61
4 files changed
+11 -4

No files matched your search

+5
View File
@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]
### Changed
- `remove_local_account_keys`, which napalm-linux 0.17.0 brings, is switched off like the
other personal-account actions: QTS manages its users in its own UI (NetOrk/netork#2013).
Needs napalm-device-types 4.28.0 and napalm-linux 0.17.0.
### Added
- Scheduled jobs on QTS (#17, NetOrk/netork#1933). napalm-linux now brings
napalm-device-types' POSIX scheduled jobs with Debian's paths, which are wrong on QTS;
+2 -1
View File
@@ -97,11 +97,12 @@ class QnapQtsDriver(StorageDriver, HypervisorDriver, QtsScheduledJobsMixin, Linu
#: QTS manages its users in its own UI and ships no shadow-utils (useradd,
#: usermod, gpasswd) for LinuxDriver's accounts. Off until a QTS variant is
#: built against a real box (NetOrk/netork#1793), netOrk's own account
#: included (NetOrk/netork#1817).
#: included (NetOrk/netork#1817), and taking keys off one (NetOrk/netork#2013).
get_local_accounts = None # type: ignore[assignment]
add_local_account = None # type: ignore[assignment]
lock_local_account = None # type: ignore[assignment]
add_service_account = None # type: ignore[assignment]
remove_local_account_keys = None # type: ignore[assignment]
SNMP_OBJECT_ID_PREFIX = QNAP_ENTERPRISE_OID
SNMP_FINGERPRINT = [
+2 -2
View File
@@ -40,8 +40,8 @@ classifiers = [
# processes, Docker) from LinuxDriver rather than reimplementing it.
dependencies = [
"napalm>=4.0",
"napalm-device-types>=4.27.0",
"napalm-linux>=0.16.0",
"napalm-device-types>=4.28.0",
"napalm-linux>=0.17.0",
"netmiko>=4.0.0",
"paramiko>=5.0.0", # CVE-2026-44405
]
+2 -1
View File
@@ -242,7 +242,8 @@ def test_personal_accounts_are_not_managed_here():
from napalm_linux.linux import LinuxDriver
actions = ("get_local_accounts", "add_local_account", "lock_local_account")
for action in (*actions, "add_service_account"):
# And no key taken off an account either (NetOrk/netork#2013).
for action in (*actions, "add_service_account", "remove_local_account_keys"):
assert callable(getattr(LinuxDriver, action, None))
assert not callable(getattr(QnapQtsDriver, action, None))