diff --git a/CHANGELOG.md b/CHANGELOG.md index 5727420..20534f0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Changed +- `remove_local_account_keys`, which napalm-linux 0.17.0 brings, is switched off like the + other personal-account actions: QTS manages its users in its own UI (NetOrk/netork#2013). + Needs napalm-device-types 4.28.0 and napalm-linux 0.17.0. + ### Added - Scheduled jobs on QTS (#17, NetOrk/netork#1933). napalm-linux now brings napalm-device-types' POSIX scheduled jobs with Debian's paths, which are wrong on QTS; diff --git a/napalm_qnap_qts/qnap_qts.py b/napalm_qnap_qts/qnap_qts.py index f6fe02d..bcfa070 100644 --- a/napalm_qnap_qts/qnap_qts.py +++ b/napalm_qnap_qts/qnap_qts.py @@ -97,11 +97,12 @@ class QnapQtsDriver(StorageDriver, HypervisorDriver, QtsScheduledJobsMixin, Linu #: QTS manages its users in its own UI and ships no shadow-utils (useradd, #: usermod, gpasswd) for LinuxDriver's accounts. Off until a QTS variant is #: built against a real box (NetOrk/netork#1793), netOrk's own account - #: included (NetOrk/netork#1817). + #: included (NetOrk/netork#1817), and taking keys off one (NetOrk/netork#2013). get_local_accounts = None # type: ignore[assignment] add_local_account = None # type: ignore[assignment] lock_local_account = None # type: ignore[assignment] add_service_account = None # type: ignore[assignment] + remove_local_account_keys = None # type: ignore[assignment] SNMP_OBJECT_ID_PREFIX = QNAP_ENTERPRISE_OID SNMP_FINGERPRINT = [ diff --git a/pyproject.toml b/pyproject.toml index c5df099..4c235bf 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -40,8 +40,8 @@ classifiers = [ # processes, Docker) from LinuxDriver rather than reimplementing it. dependencies = [ "napalm>=4.0", - "napalm-device-types>=4.27.0", - "napalm-linux>=0.16.0", + "napalm-device-types>=4.28.0", + "napalm-linux>=0.17.0", "netmiko>=4.0.0", "paramiko>=5.0.0", # CVE-2026-44405 ] diff --git a/tests/test_qnap_qts.py b/tests/test_qnap_qts.py index 10f8691..d1cf003 100644 --- a/tests/test_qnap_qts.py +++ b/tests/test_qnap_qts.py @@ -242,7 +242,8 @@ def test_personal_accounts_are_not_managed_here(): from napalm_linux.linux import LinuxDriver actions = ("get_local_accounts", "add_local_account", "lock_local_account") - for action in (*actions, "add_service_account"): + # And no key taken off an account either (NetOrk/netork#2013). + for action in (*actions, "add_service_account", "remove_local_account_keys"): assert callable(getattr(LinuxDriver, action, None)) assert not callable(getattr(QnapQtsDriver, action, None))