feat!: fix templates with the caller's values replace run_device_action (0.2.0) #14

2026-10-17T06:33:25Z

christianmanivong commented

2026-10-17 06:33:25 +00:00

configure_snmp_agent(settings): snmpd installed when missing; community/contact/location in UCI, one com2sec/com2sec6 per allowed source (no sources → default; only IPv4 sources → IPv6 answers localhost only); the zone-resolving firewall step of the old fix, now limited to the sources (src_ip) and named Allow-SNMP; snmpd enabled, restarted, checked listening.
get_management_peer() from SSH_CONNECTION; ensure_package from the base package replaces install_lldpd/install_auc/install_coreutils_base64.
The shadowed second _action_fix_snmp in system_mixin.py is gone (#5).
Existing zone/rule/reload tests now run through the template.

Not changed here: the getter that rewrites lldpd's config (#8) — ensure_package("lldpd") no longer pins lldpd to the management interface itself.

Closes #5. Part of #13.

Step 4 of NetOrk/netork#1105. - `configure_snmp_agent(settings)`: snmpd installed when missing; community/contact/location in UCI, one `com2sec`/`com2sec6` per allowed source (no sources → `default`; only IPv4 sources → IPv6 answers localhost only); the zone-resolving firewall step of the old fix, now limited to the sources (`src_ip`) and named `Allow-SNMP`; snmpd enabled, restarted, checked listening. - `get_management_peer()` from `SSH_CONNECTION`; `ensure_package` from the base package replaces `install_lldpd`/`install_auc`/`install_coreutils_base64`. - The shadowed second `_action_fix_snmp` in `system_mixin.py` is gone (#5). - Existing zone/rule/reload tests now run through the template. Not changed here: the getter that rewrites lldpd's config (#8) — `ensure_package("lldpd")` no longer pins lldpd to the management interface itself. Closes #5. Part of #13.

christianmanivong added 1 commit 2026-10-17 06:33:25 +00:00

feat!: fix templates with the caller's values replace run_device_action (0.2.0)

CI / test (3.10) (push) Successful in 26s

Details

CI / test (3.11) (push) Successful in 24s

Details

CI / test (3.12) (push) Successful in 26s

Details

CI / test (3.10) (pull_request) Successful in 25s

Details

CI / test (3.11) (pull_request) Successful in 23s

Details

CI / test (3.12) (pull_request) Successful in 25s

Details

968d6583ba

fix_snmp set no community at all and opened the management zone's
udp/161 to every source, with a rule named after an application; a
second fix_snmp in the system mixin was shadowed and never ran (#5).
install_lldpd, install_auc and install_coreutils_base64 were actions of
their own.

The driver implements napalm-device-types 4.13's templates instead:
- configure_snmp_agent(settings): snmpd installed when missing;
  community, contact and location in UCI with one com2sec (com2sec6)
  per allowed source; the zone-resolving firewall step of the old fix,
  now limited to the sources (src_ip) and named Allow-SNMP; snmpd
  enabled, restarted and listening;
- get_management_peer() from SSH_CONNECTION;
- ensure_package(name) from the base package, over install_package.
A community, contact or location that would break UCI is refused.

BREAKING CHANGE: run_device_action is removed. Requires
napalm-device-types 4.13.

Closes #5. Part of #13.

christianmanivong merged commit 9f43b8c797 into master

2026-10-17 06:48:19 +00:00

christianmanivong deleted branch feat/fix-templates

2026-10-17 06:48:19 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: NAPALM/napalm-openwrt#14