package commands, UCI parsing: copies inside the driver; dead _action_fix_snmp #5

New Issue

2026-10-06T17:31:30Z

christianmanivong commented

2026-10-06 17:31:30 +00:00

Package commands. The "apk or opkg command, clean the output, check failure markers" sequence appears five times:

packages_mixin.py:196, :209
openwrt.py:607, :620, :629

The marker tuple ("error:", "failed", "not found", "unknown package") is repeated each time.

Dead code. OpenWrtSystemMixin._action_fix_snmp (system_mixin.py:247) is shadowed by OpenWrtDriver._action_fix_snmp (openwrt.py:472), because the class's own method wins in the MRO. The mixin copy is never called. It also uses a shorter marker tuple (:264).

UCI. There are two UCI tokenisers and two section parsers:

openwrt.py:292–326 handles '…', "…" and bare tokens.
vlan_mixin.py:20–74 handles single quotes only and network sections only.

Proposal: _pkg_run(apk_cmd, opkg_cmd, *, refresh=False) -> (success, output); delete the mixin's _action_fix_snmp; a uci.py that keeps the openwrt.py tokeniser.

Prio P4.

From the NetOrk function index (NetOrk/netork#670); every location was checked against the current code. Paths are relative to each driver repo.

**Package commands.** The "apk or opkg command, clean the output, check failure markers" sequence appears five times: - `packages_mixin.py`:196, :209 - `openwrt.py`:607, :620, :629 The marker tuple `("error:", "failed", "not found", "unknown package")` is repeated each time. **Dead code.** `OpenWrtSystemMixin._action_fix_snmp` (`system_mixin.py`:247) is shadowed by `OpenWrtDriver._action_fix_snmp` (`openwrt.py`:472), because the class's own method wins in the MRO. The mixin copy is never called. It also uses a shorter marker tuple (:264). **UCI.** There are two UCI tokenisers and two section parsers: - `openwrt.py`:292–326 handles `'…'`, `"…"` and bare tokens. - `vlan_mixin.py`:20–74 handles single quotes only and network sections only. **Proposal:** `_pkg_run(apk_cmd, opkg_cmd, *, refresh=False) -> (success, output)`; delete the mixin's `_action_fix_snmp`; a `uci.py` that keeps the `openwrt.py` tokeniser. Prio P4. From the NetOrk function index (NetOrk/netork#670); every location was checked against the current code. Paths are relative to each driver repo.

christianmanivong referenced this issue

2026-10-14 08:58:51 +00:00

Agnostic structure: fix templates, facts instead of warnings, shared parsers #13

christianmanivong referenced this issue from a commit

2026-10-17 06:33:25 +00:00

feat!: fix templates with the caller's values replace run_device_action (0.2.0)

christianmanivong referenced a pull request that will close this issue

2026-10-17 06:33:25 +00:00

feat!: fix templates with the caller's values replace run_device_action (0.2.0) #14

christianmanivong closed this issue

2026-10-17 06:48:19 +00:00

Sign in to join this conversation.