NAPALM/napalm-netgear
1
0 Fork 0
Code Issues 4 Pull Requests Actions 1 Packages Projects Releases Wiki Activity

feat: report the firmware Netgear offers, not a warning (0.4.0) #12

Merged
christianmanivong merged 1 commits from feat/firmware-offer into master 2026-10-17 11:10:40 +00:00
Conversation 0 Commits 1 Files Changed 5
+81 -47
christianmanivong commented 2026-10-17 11:02:36 +00:00
Owner
Copy link
Copy source

The Plus driver looked the newest firmware up in Netgear's download catalogue and named firmware_update_available itself. It now reports get_firmware_offer() (napalm-device-types 4.16 FirmwareOfferMixin, NAPALM/napalm-device-types#45): current and latest version, newer by Netgear's versioning, and the download link. None when the model is unknown, a version cannot be read or compared, or the check fails — the same cases that gave no warning before. netOrk names the warning (NetOrk/netork#1111).

The Smart driver's empty get_device_warnings goes too. First tests for the Plus driver's firmware lookup.

Requires napalm-device-types >= 4.16.0 — merge after NAPALM/napalm-device-types#45.

The Plus driver looked the newest firmware up in Netgear's download catalogue and named `firmware_update_available` itself. It now reports `get_firmware_offer()` (napalm-device-types 4.16 `FirmwareOfferMixin`, NAPALM/napalm-device-types#45): current and latest version, `newer` by Netgear's versioning, and the download link. None when the model is unknown, a version cannot be read or compared, or the check fails — the same cases that gave no warning before. netOrk names the warning (NetOrk/netork#1111). The Smart driver's empty `get_device_warnings` goes too. First tests for the Plus driver's firmware lookup. Requires napalm-device-types >= 4.16.0 — merge after NAPALM/napalm-device-types#45.
christianmanivong added 1 commit 2026-10-17 11:04:37 +00:00
feat: report the firmware Netgear offers, not a warning (0.4.0)
CI / test (3.10) (push) Successful in 25s
Details
CI / test (3.11) (push) Successful in 23s
Details
CI / test (3.12) (push) Successful in 26s
Details
CI / test (3.10) (pull_request) Successful in 24s
Details
CI / test (3.11) (pull_request) Successful in 23s
Details
CI / test (3.12) (pull_request) Successful in 25s
Details
4ccb2b5879 
The Plus driver looked the newest firmware up in Netgear's download
catalogue and named firmware_update_available itself. It now reports
get_firmware_offer() (napalm-device-types 4.16 FirmwareOfferMixin): what
runs, the newest offered, whether that is newer by Netgear's versioning,
and the download link; netOrk names the warning (netOrk #1111). The Smart
driver's empty get_device_warnings goes too. Requires
napalm-device-types 4.16.0.
christianmanivong force-pushed feat/firmware-offer from c8c9642af0 to 4ccb2b5879 2026-10-17 11:04:37 +00:00 Compare
christianmanivong merged commit 8062188b12 into master 2026-10-17 11:10:40 +00:00
christianmanivong deleted branch feat/firmware-offer 2026-10-17 11:10:40 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is broken
bug
Something is broken
 enhancement
New feature or request
 tech-debt
Refactoring / cleanup / deferred debt
prio
P0
Road blocker: blocks other work, drop everything
prio
P1
Critical
prio
P2
Important and urgent
prio
P3
Important, not urgent
prio
P4
Neither important nor urgent
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
christianmanivong
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-netgear#12