NAPALM/napalm-device-types
1
0 Fork 0
Code Issues 12 Pull Requests 1 Actions Packages Projects Releases 2 Wiki Activity

feat: the firmware a vendor offers, as a fact (4.16.0) #45

Merged
christianmanivong merged 1 commits from feat/firmware-offer into main 2026-10-17 11:04:22 +00:00
Conversation 0 Commits 1 Files Changed 5
+62 -1
christianmanivong commented 2026-10-17 11:00:43 +00:00
Owner
Copy link
Copy source

FirmwareOfferMixin.get_firmware_offer() → FirmwareOfferDict {current_version, latest_version, newer, download_url?} — or None when the driver cannot tell.

The last driver-named warning without a fact contract was napalm-netgear's Plus driver, which looks up the newest firmware in Netgear's download catalogue and names firmware_update_available itself. Comparing vendor version strings is vendor knowledge, so the driver reports newer; the application decides on the warning (NetOrk/netork#1111). Declared only, like the 4.14 getters.

Part of NetOrk/netork#1111.

`FirmwareOfferMixin.get_firmware_offer()` → `FirmwareOfferDict` `{current_version, latest_version, newer, download_url?}` — or None when the driver cannot tell. The last driver-named warning without a fact contract was napalm-netgear's Plus driver, which looks up the newest firmware in Netgear's download catalogue and names `firmware_update_available` itself. Comparing vendor version strings is vendor knowledge, so the driver reports `newer`; the application decides on the warning (NetOrk/netork#1111). Declared only, like the 4.14 getters. Part of NetOrk/netork#1111.
christianmanivong added 1 commit 2026-10-17 11:00:43 +00:00
feat: the firmware a vendor offers, as a fact (4.16.0)
CI / test (3.10) (push) Successful in 27s
Details
CI / test (3.11) (push) Successful in 24s
Details
CI / test (3.12) (push) Successful in 27s
Details
CI / test (3.13) (push) Successful in 26s
Details
CI / test (3.10) (pull_request) Successful in 25s
Details
CI / test (3.11) (pull_request) Successful in 24s
Details
CI / test (3.12) (pull_request) Successful in 27s
Details
CI / test (3.13) (pull_request) Successful in 25s
Details
59fb1273e8 
FirmwareOfferMixin.get_firmware_offer() -> FirmwareOfferDict
{current_version, latest_version, newer, download_url?}: what runs and
the newest firmware the vendor offers, from its download catalogue or
the device's own update check. Comparing vendor version strings stays
with the driver, so it says whether the offer is newer; whether that is a
warning is the application's call (NetOrk/netork#1111). Declared only.
christianmanivong merged commit 753ddc5eda into main 2026-10-17 11:04:22 +00:00
christianmanivong deleted branch feat/firmware-offer 2026-10-17 11:04:22 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is broken
 enhancement
New feature or request
 tech-debt
Refactoring / cleanup / deferred debt
prio
P0
Road blocker: blocks other work, drop everything
prio
P1
Critical
prio
P2
Important and urgent
prio
P3
Important, not urgent
prio
P4
Neither important nor urgent
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
christianmanivong
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-device-types#45