chore: adopt the NAPALM driver standard #38

Merged

christianmanivong merged 6 commits from chore/driver-standard into main 2026-10-23 12:55:55 +00:00

Conversation 0 Commits 6 Files Changed 14

+903 -449

christianmanivong commented 2026-10-22 17:12:12 +00:00

Owner

Copy link

Copy source

Summary

napalm-linux adopts the NAPALM driver standard
(https://git.netork.io/NAPALM/driver-standard, STANDARDS.md); second repo of the pilot,
after napalm-device-types (NAPALM/napalm-device-types#52).

Changes

• style: ruff format + ruff check --fix with the standard's rules. No behaviour change.
• fix: long shell lines split; a dead loop in get_os_users removed (output
  unchanged); the five except Exception: pass log at debug level (bandit B110);
  nosec for two bandit false positives; test lint.
• chore: CI in .gitea/ calling the shared workflow (device-types from git until
  it is on PyPI); requires-python >=3.10; LICENSE; py.typed; SPDX license; links to
  git.netork.io; strict mypy with napalm_linux.linux exempt for now (21 errors) and
  recorded in the quality baseline; coverage floor 58 %.

The default branch stays master in this PR; renaming it to main is a separate step.

Related Issue

NetOrk/netork#734

Testing

Locally: 212 tests, coverage 58.23 %, ruff, mypy, bandit clean; napalm-standard check
and ratchet clean; build + twine check --strict pass.

## Summary napalm-linux adopts the NAPALM driver standard (https://git.netork.io/NAPALM/driver-standard, STANDARDS.md); second repo of the pilot, after napalm-device-types (NAPALM/napalm-device-types#52). ## Changes - **style**: ruff format + ruff check --fix with the standard's rules. No behaviour change. - **fix**: long shell lines split; a dead loop in `get_os_users` removed (output unchanged); the five `except Exception: pass` log at debug level (bandit B110); nosec for two bandit false positives; test lint. - **chore**: CI in `.gitea/` calling the shared workflow (device-types from git until it is on PyPI); `requires-python >=3.10`; LICENSE; `py.typed`; SPDX license; links to git.netork.io; strict mypy with `napalm_linux.linux` exempt for now (21 errors) and recorded in the quality baseline; coverage floor 58 %. The default branch stays `master` in this PR; renaming it to `main` is a separate step. ## Related Issue NetOrk/netork#734 ## Testing Locally: 212 tests, coverage 58.23 %, ruff, mypy, bandit clean; `napalm-standard check` and `ratchet` clean; build + `twine check --strict` pass.

christianmanivong added 3 commits 2026-10-22 17:12:12 +00:00

style: ruff format and the lint rules of the driver standard ... 38391891ec

Mechanical: ruff format, and ruff check --fix with the rule set every NAPALM
driver uses (E, F, I, UP, B at line length 100, Python 3.10). What ruff
cannot fix comes in the next commit.

fix: what bandit and the remaining lint rules found ... 933f81bd44

- Long shell command lines are split into adjacent string literals.
- get_os_users: a first loop over /etc/group filled a map nobody read;
  it is gone, the output is unchanged.
- The five except Exception: pass now log at debug level (B110), so a
  swallowed failure leaves a trace.
- nosec for the staging path on the device (B108) and the sudo hint
  message (B105); both are false positives.
- tests: raise ... from exc, unused loop variable.

chore: adopt the NAPALM driver standard ... 9b3ac3f3eb

- CI moves to .gitea/workflows/ci.yml and calls the shared driver workflow
  of NAPALM/driver-standard; napalm-device-types comes from git until it is
  on PyPI.
- requires-python >=3.10 (napalm-device-types needs it), LICENSE file,
  py.typed, SPDX license string, links to git.netork.io.
- mypy strict for the package; napalm_linux.linux is exempt for now (21
  errors), recorded in the quality baseline with its long functions and
  the 2200-line module. Coverage floor 58 % (measured 58.23 %).

christianmanivong referenced this pull request from NAPALM/driver-standard 2026-10-22 17:31:47 +00:00

Epic: one standard for every NAPALM driver, releases on PyPI #2

christianmanivong referenced this pull request 2026-10-22 17:32:26 +00:00

chore: adopt the NAPALM driver standard #40

christianmanivong added 1 commit 2026-10-23 06:29:21 +00:00

Merge remote-tracking branch 'origin/master' into chore/driver-standard ... e0960085c7

# Conflicts:
#	napalm_linux/linux.py

christianmanivong added 1 commit 2026-10-23 06:29:33 +00:00

ci: say which napalm-device-types the git install waits for cc0e0358f2

christianmanivong added 1 commit 2026-10-23 10:02:11 +00:00

chore(release): 0.15.0 9a4bc76dbf

christianmanivong referenced this pull request from NAPALM/napalm-openmediavault 2026-10-23 10:07:19 +00:00

chore: adopt the NAPALM driver standard #9

christianmanivong referenced this pull request from NAPALM/napalm-qnap-qts 2026-10-23 10:10:04 +00:00

chore: adopt the NAPALM driver standard #11

christianmanivong merged commit 3aa1955382 into main 2026-10-23 12:55:55 +00:00

christianmanivong deleted branch chore/driver-standard 2026-10-23 12:55:55 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something is broken

enhancement

New feature or request

tech-debt

Refactoring / cleanup / deferred debt

prio

P0

Road blocker: blocks other work, drop everything

prio

P1

Critical

prio

P2

Important and urgent

prio

P3

Important, not urgent

prio

P4

Neither important nor urgent

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

christianmanivong

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: NAPALM/napalm-linux#38