Commit Graph
161 Commits
Author SHA1 Message Date
Christian Manivong 94badd0e23 test(system-identity): compare the identity's keys only
driver / lowest (pull_request) Successful in 31s
driver / build (pull_request) Successful in 33s
driver / security (pull_request) Successful in 1m9s
CI / driver (pull_request) Successful in 2m37s
driver / standard (pull_request) Successful in 14s
driver / lint (pull_request) Successful in 13s
driver / types (pull_request) Successful in 1m2s
driver / test (3.12) (pull_request) Successful in 1m1s
driver / test (3.13) (pull_request) Successful in 53s
driver / publish (pull_request) Skipped
napalm-device-types reads the system firmware in the same round trip
(bios_vendor, bios_version, bios_date). The driver only carries the
command across, so its test checks the identity it reads and passes
against napalm-device-types with and without the firmware.

NetOrk/netork#2518
2026-11-13 23:00:31 +01:00
christianmanivong 4db8b05ab4 Merge pull request 'fix(driver): load_replace_candidate is None, not a stub that raises (NetOrk/netork#2503)' (#81) from fix/no-config-replace into main
driver / lint (push) Successful in 15s
driver / lowest (push) Successful in 26s
driver / build (push) Successful in 26s
driver / security (push) Successful in 1m0s
driver / test (3.13) (push) Failing after 13m23s
driver / publish (push) Skipped
driver / test (3.12) (push) Failing after 13m25s
driver / types (push) Failing after 13m38s
driver / standard (push) Successful in 17s
CI / driver (push) Failing after 13m40s
2026-11-13 21:39:04 +00:00
Christian Manivong de91b1a918 style: one comment line, so linux.py keeps its recorded length
driver / build (pull_request) Successful in 27s
driver / security (pull_request) Successful in 56s
CI / driver (pull_request) Successful in 2m18s
driver / standard (pull_request) Successful in 15s
driver / types (pull_request) Successful in 55s
driver / test (3.12) (pull_request) Successful in 55s
driver / test (3.13) (pull_request) Successful in 50s
driver / lowest (pull_request) Successful in 27s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 12s
2026-11-13 21:50:25 +01:00
Christian Manivong c9a9d532aa fix(driver): load_replace_candidate is None, not a stub that raises (NetOrk/netork#2503)
driver / lowest (pull_request) Successful in 35s
driver / build (pull_request) Successful in 35s
driver / security (pull_request) Successful in 1m15s
CI / driver (pull_request) Failing after 4m54s
driver / standard (pull_request) Failing after 27s
driver / types (pull_request) Successful in 3m34s
driver / test (3.13) (pull_request) Successful in 3m12s
driver / test (3.12) (pull_request) Successful in 3m23s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 19s
The driver cannot replace a device's configuration, and said so with a
load_replace_candidate that raised NotImplementedError. A method that only
raises still looks like a replace to anyone who asks whether the driver has
one: netOrk offered a config restore for these devices that could only fail.

None is how a driver switches off a method, the convention netOrk's
capability checks and napalm-device-types follow, so asking now says no.
Nothing in the driver calls it.
2026-11-13 21:45:23 +01:00
christianmanivong 5f6595d160 Merge pull request 'feat(packages): each rpm names the source rpm it was built from' (#80) from fix/rpm-source-package into main
driver / lint (push) Successful in 14s
driver / test (3.13) (push) Successful in 1m18s
driver / lowest (push) Successful in 35s
driver / build (push) Successful in 34s
driver / security (push) Successful in 1m10s
driver / publish (push) Skipped
driver / types (push) Successful in 1m8s
driver / test (3.12) (push) Successful in 1m18s
driver / standard (push) Successful in 17s
CI / driver (push) Successful in 2m59s
2026-11-12 18:07:58 +00:00
Christian Manivong 4ba81cc90e feat(packages): each rpm names the source rpm it was built from
driver / lowest (pull_request) Successful in 50s
driver / build (pull_request) Successful in 39s
driver / security (pull_request) Successful in 1m35s
CI / driver (pull_request) Successful in 2m55s
driver / lint (pull_request) Successful in 15s
driver / standard (pull_request) Successful in 15s
driver / types (pull_request) Successful in 1m4s
driver / test (3.13) (pull_request) Successful in 1m5s
driver / test (3.12) (pull_request) Successful in 1m11s
driver / publish (pull_request) Skipped
perf, python3-perf and bpftool are built from the kernel's source rpm, and
Red Hat's VEX lists them in every kernel CVE: 18 532 findings on an Oracle
Linux 9 host's three kernel tools alone. The rpm query now reads
%{SOURCERPM}, and each package carries its name as `source_rpm` (`perf` ->
`kernel`), absent where rpm names none (`gpg-pubkey`).

Not dpkg's `source_package`: netOrk reads that as the name a distribution
files its verdicts under, which holds for Debian and not for Oracle or Red
Hat, whose records name the binary (NetOrk/netork#2394).
2026-11-12 19:04:27 +01:00
christianmanivong 92ca800026 Merge pull request 'fix(snmp): open udp/161 in firewalld, not behind it' (#79) from fix/snmp-firewalld into main
driver / lint (push) Successful in 14s
driver / test (3.13) (push) Successful in 55s
driver / lowest (push) Successful in 29s
driver / build (push) Successful in 26s
driver / security (push) Successful in 56s
driver / publish (push) Skipped
driver / types (push) Successful in 1m0s
driver / test (3.12) (push) Successful in 1m2s
driver / standard (push) Successful in 15s
CI / driver (push) Successful in 2m6s
2026-11-12 11:34:15 +00:00
Christian Manivong 655d115324 Merge remote-tracking branch 'origin/main' into fix/snmp-firewalld
driver / lowest (pull_request) Successful in 35s
driver / build (pull_request) Successful in 31s
driver / security (pull_request) Successful in 1m3s
CI / driver (pull_request) Successful in 2m20s
driver / lint (pull_request) Successful in 12s
driver / standard (pull_request) Successful in 15s
driver / types (pull_request) Successful in 1m8s
driver / test (3.13) (pull_request) Successful in 1m2s
driver / test (3.12) (pull_request) Successful in 1m7s
driver / publish (pull_request) Skipped
# Conflicts:
#	tests/quality_baseline.json
2026-11-12 12:31:14 +01:00
christianmanivong 6e5b0ea2ec Merge pull request 'feat(packages): the rpm epoch in the version, and the installed advisories' (#76) from feature/rpm-epoch-advisories into main
driver / lint (push) Successful in 13s
driver / test (3.13) (push) Successful in 58s
driver / lowest (push) Successful in 30s
driver / build (push) Successful in 27s
driver / security (push) Successful in 58s
driver / publish (push) Skipped
driver / types (push) Successful in 59s
driver / test (3.12) (push) Successful in 1m3s
driver / standard (push) Successful in 15s
CI / driver (push) Successful in 2m11s
2026-11-12 11:27:35 +00:00
Christian Manivong bc7162affd refactor(packages): the rpm query and its parse in _rpm.py, as dpkg's in _dpkg.py
driver / lowest (pull_request) Successful in 31s
driver / build (pull_request) Successful in 29s
driver / security (pull_request) Successful in 1m0s
CI / driver (pull_request) Successful in 2m16s
driver / lint (pull_request) Successful in 13s
driver / standard (pull_request) Successful in 16s
driver / test (3.13) (pull_request) Successful in 55s
driver / types (pull_request) Successful in 1m2s
driver / test (3.12) (pull_request) Successful in 1m5s
driver / publish (pull_request) Skipped
linux.py stays under its recorded size (2039 -> 2034 lines).
2026-11-12 12:24:43 +01:00
Christian Manivong 3683c85f21 refactor(snmp): the SNMP agent's helpers in a module of their own
driver / lowest (pull_request) Failing after 29s
driver / build (pull_request) Successful in 26s
driver / security (pull_request) Successful in 1m4s
CI / driver (pull_request) Failing after 2m20s
driver / lint (pull_request) Successful in 13s
driver / standard (pull_request) Successful in 14s
driver / types (pull_request) Successful in 1m7s
driver / test (3.13) (pull_request) Failing after 1m2s
driver / test (3.12) (pull_request) Failing after 1m16s
driver / publish (pull_request) Skipped
linux.py had grown past its recorded size with the firewalld rule. The
snmpd.conf rendering, the install commands and the firewalld rule now
live in _snmp_agent.py; linux.py shrinks to 2014 lines and the baseline
records that.
2026-11-12 12:22:35 +01:00
Christian Manivong aab25fb049 fix(snmp): open udp/161 in firewalld, not behind it
driver / lowest (pull_request) Failing after 30s
driver / build (pull_request) Successful in 27s
driver / security (pull_request) Successful in 1m1s
CI / driver (pull_request) Failing after 2m29s
driver / standard (pull_request) Failing after 14s
driver / lint (pull_request) Successful in 13s
driver / types (pull_request) Successful in 59s
driver / test (3.12) (pull_request) Failing after 1m1s
driver / test (3.13) (pull_request) Failing after 57s
driver / publish (pull_request) Skipped
On a host running firewalld, iptables is installed too, so the SNMP fix
inserted an iptables ACCEPT. firewalld keeps its own nftables table, whose
reject wins over it, and the step reported the port open while SNMP
stayed blocked.

With firewalld active, the step now adds a rich rule per allowed source to
the default zone (which takes interfaces in no zone, such as a WireGuard
interface) and to every active zone, at runtime and permanently, each only
when missing. No reload, which would drop rules others keep at runtime.

Closes #77
2026-11-12 12:15:10 +01:00
Christian Manivong 1d377acc5f test(time-sync): the reading carries dhcp_ntp_servers since device-types 4.36 (#75)
driver / lowest (pull_request) Successful in 31s
driver / build (pull_request) Successful in 28s
driver / security (pull_request) Successful in 59s
CI / driver (pull_request) Failing after 2m36s
driver / standard (pull_request) Failing after 15s
driver / lint (pull_request) Successful in 15s
driver / types (pull_request) Successful in 1m2s
driver / test (3.12) (pull_request) Successful in 1m6s
driver / test (3.13) (pull_request) Successful in 55s
driver / publish (pull_request) Skipped
2026-11-12 12:13:48 +01:00
Christian Manivong 257efdef8e feat(packages): the rpm epoch in the version, and the installed advisories
driver / lowest (pull_request) Failing after 46s
driver / build (pull_request) Successful in 42s
driver / security (pull_request) Successful in 1m25s
CI / driver (pull_request) Failing after 2m35s
driver / standard (pull_request) Failing after 15s
driver / lint (pull_request) Successful in 13s
driver / test (3.12) (pull_request) Failing after 39s
driver / types (pull_request) Failing after 47s
driver / test (3.13) (pull_request) Failing after 39s
driver / publish (pull_request) Skipped
On an rpm host a package's version now carries its epoch where it has
one (1:6.2.0-13.el9), as on a dpkg host: Oracle's and Red Hat's fixes
name it, and without it an epoch-1 fix read as newer than every
installed build. get_installed_advisory_cves() reads, as root and from
the cache, the CVEs the installed security advisories close, through
napalm-device-types 4.37.0; dnf only (NetOrk/netork#2394).
2026-11-12 12:10:05 +01:00
christianmanivong 235c1e9a91 Merge pull request 'feat(time-sync): the host's time sources and zone through PosixTimeSyncMixin' (#74) from feature/time-sync-2361 into main
driver / lint (push) Successful in 14s
driver / test (3.13) (push) Successful in 55s
driver / lowest (push) Successful in 34s
driver / build (push) Successful in 28s
driver / security (push) Successful in 59s
driver / publish (push) Skipped
driver / types (push) Successful in 1m1s
driver / test (3.12) (push) Successful in 1m1s
driver / standard (push) Successful in 14s
CI / driver (push) Successful in 2m8s
2026-11-11 14:12:53 +00:00
Christian Manivong c2e7ea5789 feat(time-sync): the host's time sources and zone through PosixTimeSyncMixin
driver / lowest (pull_request) Successful in 30s
driver / build (pull_request) Successful in 27s
driver / security (pull_request) Successful in 1m0s
CI / driver (pull_request) Successful in 2m11s
driver / lint (pull_request) Successful in 13s
driver / standard (pull_request) Successful in 14s
driver / types (pull_request) Successful in 1m0s
driver / test (3.13) (pull_request) Successful in 56s
driver / test (3.12) (pull_request) Successful in 1m3s
driver / publish (pull_request) Skipped
netOrk aligns every device's NTP servers and time zone with the site's
(NetOrk/netork#2360). A Linux host gets get_time_sync() and
configure_time_sync() from napalm-device-types 4.35.0's
PosixTimeSyncMixin (#2361): one reading as the login user, the zone by
timedatectl, chrony's servers in a file of their own with every other
source commented out, systemd-timesyncd's in a drop-in. The driver only
carries the commands across run_command.

The mixin comes in with PosixScheduledJobsMixin through LinuxPosixMixin,
the implementations napalm-device-types makes for any POSIX host, so
linux.py does not grow. OpenMediaVault and QNAP inherit both.
2026-11-11 14:32:29 +01:00
christianmanivong 10240c20bb Merge pull request 'feat(running-backups): the host's own backups a restart would abort' (#73) from feature/running-backups-2318 into main
driver / lint (push) Successful in 14s
driver / test (3.13) (push) Successful in 1m2s
driver / lowest (push) Successful in 32s
driver / build (push) Successful in 34s
driver / security (push) Successful in 1m11s
driver / publish (push) Skipped
driver / types (push) Successful in 1m3s
driver / test (3.12) (push) Successful in 1m13s
driver / standard (push) Successful in 15s
CI / driver (push) Successful in 2m43s
2026-11-11 07:40:53 +00:00
Christian Manivong 78374cfb42 feat(running-backups): the host's own backups a restart would abort
driver / lowest (pull_request) Successful in 28s
driver / build (pull_request) Successful in 26s
driver / security (pull_request) Successful in 54s
CI / driver (pull_request) Successful in 2m25s
driver / standard (pull_request) Successful in 15s
driver / lint (pull_request) Successful in 13s
driver / types (pull_request) Successful in 59s
driver / test (3.12) (pull_request) Successful in 1m3s
driver / test (3.13) (pull_request) Successful in 54s
driver / publish (pull_request) Skipped
netOrk holds a host's restart after patching while a backup runs on it
(NetOrk/netork#2318) and asks right before the restart. On a Linux host a
file-level backup is a process of a backup tool, started by a timer, a cron
line or by hand, so get_running_backups() (napalm-device-types 4.34.0) reads
the processes, the clock and each process's cgroup in one round trip as the
login user. What a tool does comes from its subcommand: restic backup is a
backup, restic forget a prune, restic mount none; borg serve counts, as the
receiving end of another host's backup. The systemd service a backup runs
in is its job, the timer's service netOrk shows as its scheduled job.

A ps without etimes (busybox) fails the reading rather than report nothing.
2026-11-10 23:45:49 +01:00
christianmanivong ea82d43bd4 Merge pull request 'feat(log-sources): which logs the host writes, through LogSourcesMixin' (#72) from feature/log-sources-2049 into main
driver / lint (push) Successful in 14s
driver / test (3.13) (push) Successful in 57s
driver / lowest (push) Successful in 27s
driver / build (push) Successful in 26s
driver / security (push) Successful in 56s
driver / publish (push) Skipped
driver / types (push) Successful in 1m1s
driver / test (3.12) (push) Successful in 1m5s
driver / standard (push) Successful in 14s
CI / driver (push) Successful in 2m9s
2026-11-04 23:53:40 +00:00
Christian Manivong c532a66260 refactor: the root reads' transports in a module of their own
driver / lowest (pull_request) Successful in 28s
driver / build (pull_request) Successful in 27s
driver / security (pull_request) Successful in 1m4s
CI / driver (pull_request) Successful in 2m16s
driver / lint (pull_request) Successful in 13s
driver / standard (pull_request) Successful in 14s
driver / types (pull_request) Successful in 1m0s
driver / test (3.13) (pull_request) Successful in 58s
driver / test (3.12) (pull_request) Successful in 1m4s
driver / publish (pull_request) Skipped
linux.py is over the file size limit and may not grow (quality ratchet).
Listening sockets and log sources share one transport -- through sudo where
the driver can, else as the login user -- so both move to _readings.py as
LinuxProcessReadingsMixin; linux.py shrinks from 2048 to 2039 lines.

Refs NetOrk/netork#2049
2026-11-05 00:35:19 +01:00
Christian Manivong 2b153cd61c feat(log-sources): which logs the host writes, through LogSourcesMixin
driver / lowest (pull_request) Failing after 23s
driver / build (pull_request) Successful in 32s
driver / security (pull_request) Failing after 1m1s
CI / driver (pull_request) Failing after 2m22s
driver / standard (pull_request) Failing after 18s
driver / lint (pull_request) Successful in 16s
driver / test (3.12) (pull_request) Failing after 46s
driver / types (pull_request) Failing after 1m3s
driver / test (3.13) (pull_request) Failing after 40s
driver / publish (pull_request) Skipped
The driver mixes in napalm-device-types' LogSourcesMixin (4.30.0) and
carries its command: as root through sudo where it can, else what the
login user may see. OpenMediaVault and QNAP inherit it.

Refs NetOrk/netork#2049
2026-11-05 00:24:32 +01:00
christianmanivong 249046512d Merge pull request 'feat(local-accounts): a deleted key can take the password with it' (#71) from feat/remove-keys-clear-password into main
driver / lint (push) Successful in 15s
driver / lowest (push) Successful in 35s
driver / test (3.13) (push) Successful in 1m9s
driver / build (push) Successful in 32s
driver / security (push) Successful in 1m15s
driver / publish (push) Skipped
driver / types (push) Successful in 1m3s
driver / test (3.12) (push) Successful in 1m5s
driver / standard (push) Successful in 17s
CI / driver (push) Successful in 2m48s
2026-11-04 14:45:06 +00:00
Christian Manivong 60ccea9a98 feat(local-accounts): a deleted key can take the password with it
driver / lowest (pull_request) Successful in 38s
driver / build (pull_request) Successful in 32s
driver / security (pull_request) Successful in 1m7s
CI / driver (pull_request) Successful in 2m29s
driver / lint (pull_request) Successful in 17s
driver / standard (pull_request) Successful in 20s
driver / types (pull_request) Successful in 1m3s
driver / test (3.13) (pull_request) Successful in 1m2s
driver / test (3.12) (pull_request) Successful in 1m11s
driver / publish (pull_request) Skipped
napalm-device-types 4.29.0 lets remove_local_account_keys clear the password and sudo too (NetOrk/netork#2033). This driver's _account_clear_password already does the work; a test pins the commands, and the floor rises to 4.29.0.
2026-11-04 15:22:49 +01:00
christianmanivong 5c13ce1a8b Merge pull request 'chore(release): 0.17.0' (#70) from chore/release-0.17.0 into main
driver / lint (push) Successful in 16s
driver / test (3.13) (push) Successful in 1m6s
driver / lowest (push) Successful in 38s
driver / build (push) Successful in 30s
driver / security (push) Successful in 1m10s
driver / publish (push) Successful in 30s
driver / types (push) Successful in 1m7s
driver / test (3.12) (push) Successful in 1m13s
driver / standard (push) Successful in 20s
CI / driver (push) Successful in 3m31s
v0.17.0
2026-11-04 11:19:01 +00:00
Christian Manivong 1c8b1b1c60 chore(release): 0.17.0
driver / lowest (pull_request) Successful in 35s
driver / build (pull_request) Successful in 32s
driver / security (pull_request) Successful in 1m12s
CI / driver (pull_request) Successful in 2m50s
driver / standard (pull_request) Successful in 18s
driver / lint (pull_request) Successful in 16s
driver / types (pull_request) Successful in 1m10s
driver / test (3.12) (pull_request) Successful in 1m4s
driver / test (3.13) (pull_request) Successful in 1m10s
driver / publish (pull_request) Skipped
2026-11-04 12:14:00 +01:00
christianmanivong bd17fbd84d Merge pull request 'feat(accounts): clear a password, replace and remove keys' (#69) from fix/local-account-key-replace into main
driver / lint (push) Successful in 15s
driver / test (3.13) (push) Successful in 1m13s
driver / lowest (push) Successful in 36s
driver / build (push) Successful in 32s
driver / security (push) Successful in 1m12s
driver / publish (push) Skipped
driver / types (push) Successful in 1m11s
driver / test (3.12) (push) Successful in 1m25s
driver / standard (push) Successful in 19s
CI / driver (push) Successful in 2m44s
2026-11-04 11:13:54 +00:00
Christian Manivong d03fe2a2ba feat(accounts): clear a password, replace and remove keys
driver / build (pull_request) Successful in 30s
driver / security (pull_request) Successful in 1m6s
CI / driver (pull_request) Successful in 2m27s
driver / standard (pull_request) Successful in 19s
driver / types (pull_request) Successful in 1m9s
driver / test (3.13) (pull_request) Successful in 1m2s
driver / test (3.12) (pull_request) Successful in 1m11s
driver / lowest (pull_request) Successful in 32s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 17s
napalm-device-types 4.28.0 lets add_local_account remove the old keys
(replaces) and the password (clear_password), and adds
remove_local_account_keys. The key changes run through the mixin's own
key files as the person; the password goes with usermod -p '*', which
leaves the expiry (the lock) alone and keeps the key login working with
and without PAM, where an empty password or a '!' would not.

See NetOrk/netork#2013
2026-11-04 11:46:13 +01:00
christianmanivong 650379680f Merge pull request 'feat(scheduled-jobs): scheduled jobs through PosixScheduledJobsMixin (#67)' (#68) from feature/scheduled-jobs into main
driver / lint (push) Successful in 14s
driver / test (3.13) (push) Successful in 51s
driver / lowest (push) Successful in 28s
driver / build (push) Successful in 31s
driver / security (push) Successful in 59s
driver / publish (push) Successful in 25s
driver / types (push) Successful in 59s
driver / test (3.12) (push) Successful in 1m3s
driver / standard (push) Successful in 14s
CI / driver (push) Successful in 2m52s
v0.16.0
2026-11-03 07:56:30 +00:00
Christian Manivong 04a34ca6f5 chore(release): 0.16.0
driver / lowest (pull_request) Successful in 36s
driver / build (pull_request) Successful in 27s
driver / security (pull_request) Successful in 1m4s
CI / driver (pull_request) Successful in 2m27s
driver / standard (pull_request) Successful in 14s
driver / lint (pull_request) Successful in 14s
driver / types (pull_request) Successful in 55s
driver / test (3.12) (pull_request) Successful in 59s
driver / test (3.13) (pull_request) Successful in 57s
driver / publish (pull_request) Skipped
Scheduled jobs (NetOrk/netork#1933) and everything unreleased since
0.15.0.
2026-11-03 08:52:05 +01:00
Christian Manivong d5870d9813 chore(scheduled-jobs): require napalm-device-types 4.27.0
driver / build (pull_request) Successful in 27s
driver / security (pull_request) Successful in 1m4s
CI / driver (pull_request) Successful in 2m14s
driver / standard (pull_request) Successful in 15s
driver / types (pull_request) Successful in 1m0s
driver / test (3.13) (pull_request) Successful in 53s
driver / test (3.12) (pull_request) Successful in 1m3s
driver / lowest (pull_request) Successful in 30s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 14s
4.26.0 went out with the sshd drop-in change; the scheduled-jobs
contract is in 4.27.0.
2026-11-03 08:35:36 +01:00
Christian Manivong a30d1f6fe5 chore: version 0.16.0 ahead of the release, so OMV and QTS can require it
driver / lowest (pull_request) Failing after 24s
driver / build (pull_request) Successful in 32s
driver / security (pull_request) Failing after 1m13s
CI / driver (pull_request) Failing after 2m36s
driver / standard (pull_request) Successful in 24s
driver / lint (pull_request) Successful in 25s
driver / test (3.12) (pull_request) Failing after 58s
driver / types (pull_request) Failing after 1m20s
driver / test (3.13) (pull_request) Failing after 56s
driver / publish (pull_request) Skipped
Their scheduled-jobs branches require napalm-linux>=0.16.0; the release
commit then only dates the changelog and tags.

Refs #67
2026-11-03 06:35:01 +01:00
Christian Manivong ca32b89686 feat(scheduled-jobs): scheduled jobs through PosixScheduledJobsMixin (#67)
driver / lowest (pull_request) Failing after 29s
driver / build (pull_request) Successful in 30s
driver / security (pull_request) Failing after 1m14s
CI / driver (pull_request) Failing after 2m29s
driver / standard (pull_request) Successful in 16s
driver / test (3.12) (pull_request) Failing after 51s
driver / types (pull_request) Failing after 59s
driver / test (3.13) (pull_request) Failing after 47s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 13s
get_scheduled_jobs reads /etc/crontab, /etc/cron.d, the user crontabs,
run-parts, anacron and every systemd timer in one round trip as root;
manage_scheduled_job enables, disables or runs one now; put_ and
delete_scheduled_job write and remove an application's own job.

get_cron_jobs goes: it read without root, missed most of what a host
schedules, and nothing called it.

Requires napalm-device-types 4.26.0.

Closes #67
2026-11-03 05:32:01 +01:00
christianmanivong cb0e308a78 Merge pull request 'fix(lldp): list every neighbour of a port, with its chassis MAC' (#62) from fix/lldp-keyvalue into main
driver / lint (push) Successful in 15s
driver / test (3.13) (push) Successful in 1m1s
driver / lowest (push) Successful in 33s
driver / build (push) Successful in 31s
driver / security (push) Successful in 1m18s
driver / publish (push) Skipped
driver / types (push) Successful in 1m12s
driver / test (3.12) (push) Successful in 1m14s
driver / standard (push) Successful in 19s
CI / driver (push) Successful in 3m4s
2026-11-02 11:03:06 +00:00
Christian Manivong c7317925ed Merge remote-tracking branch 'origin/main' into fix/lldp-keyvalue
driver / lowest (pull_request) Successful in 29s
driver / build (pull_request) Successful in 27s
driver / security (pull_request) Successful in 1m3s
CI / driver (pull_request) Successful in 2m21s
driver / standard (pull_request) Successful in 18s
driver / types (pull_request) Successful in 1m8s
driver / test (3.13) (pull_request) Successful in 58s
driver / test (3.12) (pull_request) Successful in 1m6s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 20s
# Conflicts:
#	CHANGELOG.md
#	tests/quality_baseline.json
2026-11-02 09:29:09 +01:00
christianmanivong 9ac6c7cf04 Merge pull request 'fix: quote ping arguments, sudo -n runs the whole command, ip route types (#55, #56, #57)' (#61) from fix/bugs-2026-11-02 into main
driver / lint (push) Successful in 15s
driver / test (3.13) (push) Successful in 1m8s
driver / lowest (push) Successful in 34s
driver / build (push) Successful in 34s
driver / security (push) Successful in 1m15s
driver / publish (push) Skipped
driver / types (push) Successful in 1m13s
driver / test (3.12) (push) Successful in 1m14s
driver / standard (push) Successful in 19s
CI / driver (push) Successful in 3m3s
2026-11-02 08:15:56 +00:00
Christian Manivong d3189806d3 fix(lldp): recognise a stopped lldpd and raise on a failed read
driver / build (pull_request) Successful in 32s
driver / security (pull_request) Failing after 1m9s
CI / driver (pull_request) Failing after 2m35s
driver / standard (pull_request) Successful in 19s
driver / test (3.12) (pull_request) Failing after 57s
driver / types (pull_request) Failing after 1m7s
driver / test (3.13) (pull_request) Failing after 50s
driver / lowest (pull_request) Failing after 23s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 15s
The running check looked for "active" anywhere in the answer, and
systemctl answers "inactive" for a stopped lldpd, so lldpctl was asked
anyway. The check now prints one word, running or stopped, and is
compared whole. With lldpd running, lldpctl runs as napalm-device-types'
LLDPCTL_KEYVALUE_COMMAND: a failure (socket out of the login's reach, a
daemon restarting) raises with lldpctl's message instead of reading as
a host without neighbours. A missing or stopped lldpd still answers {}.

Closes #66
2026-11-02 08:53:52 +01:00
Christian Manivong a3d95d72b9 refactor(lldp): take the neighbour MAC from the shared projection
napalm-device-types' lldp_neighbors now carries the chassis MAC as mac
when the chassis id is a MAC address, the rule this driver applied
itself. The getter uses the projection, so linux and openwrt report
neighbours the same way.
2026-11-02 08:52:10 +01:00
Christian Manivong ca65f007c1 fix(routes): read the address of a "via inet6" next hop
driver / lowest (pull_request) Successful in 37s
driver / build (pull_request) Successful in 40s
driver / security (pull_request) Successful in 1m25s
CI / driver (pull_request) Successful in 3m10s
driver / standard (pull_request) Successful in 16s
driver / types (pull_request) Successful in 1m17s
driver / test (3.13) (pull_request) Successful in 1m12s
driver / test (3.12) (pull_request) Successful in 1m18s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 16s
iproute2 prints an IPv4 route with an IPv6 next hop (RFC 8950, BGP
unnumbered) as "via inet6 fe80::1", and the next hop was read as the
literal "inet6". The family word after "via" is now skipped, for
multipath next hops as well.

With the address in place, get_route_to would have reported such a
route as ipv6, because it took the family from the next hop too. The
family is now the destination's alone. The test fixture is ip's output
(iproute2 6.1.0) recorded in a network namespace set up with these
routes.

Closes #65
2026-11-02 08:49:53 +01:00
Christian Manivong 9089429c2d fix(routes): give an FRR host route without a length /128 for IPv6
The FRR enrichment in get_route_to completed every prefix without a
length with /32. An IPv6 host route became a different, much larger
/32 prefix, so it missed the kernel's /128 entry for the same host
(stored that way since #6) and added a bogus one instead.

with_length() in _routes.py completes a prefix by its family, /32 or
/128. The protocol attributes move onto IpRoute, which keeps the import
in linux.py on one line; get_route_to shrinks and the baseline records
it.

Closes #64
2026-11-02 08:48:39 +01:00
Christian Manivong a1e8ec78c3 fix(ping): refuse a destination or source that reads as an option
Quoting keeps a value one word, but ping still reads a word starting
with "-" as one of its options: ping(destination="-f") sent a flood
ping option instead of a host, and a source "-f" did the same after -I.
No address or hostname starts with "-", so ping_command now refuses
such a destination or source with ValueError before anything is sent.

Closes #63
2026-11-02 08:47:23 +01:00
Christian Manivong 3d2de27988 fix(lldp): list every neighbour of a port, with its chassis MAC
driver / lowest (pull_request) Failing after 22s
driver / build (pull_request) Successful in 38s
driver / security (pull_request) Failing after 1m20s
CI / driver (pull_request) Failing after 2m46s
driver / standard (pull_request) Successful in 15s
driver / lint (pull_request) Successful in 15s
driver / test (3.12) (pull_request) Failing after 48s
driver / types (pull_request) Failing after 1m0s
driver / test (3.13) (pull_request) Failing after 48s
driver / publish (pull_request) Skipped
lldpctl -f keyvalue was grouped by interface, so a second neighbour on a
port overwrote the first. The driver looked for chassis.id.value and
port.id.value, keys lldpd never prints (it names an id by its type,
chassis.mac, port.local), so the chassis MAC was never reported and a
port given by MAC or local id came back empty; and eth0.100 was cut at
its dot. The output now goes through napalm-device-types'
parse_lldpctl_keyvalue, which splits neighbours at their via line and
keeps the interface name whole; the floor on napalm-device-types rises
to 4.24.0 for it.

Closes #58
2026-11-02 08:44:15 +01:00
Christian Manivong e4c65945b9 fix(routes): read route types and multipath next hops in ip route
driver / build (pull_request) Successful in 36s
driver / security (pull_request) Successful in 1m19s
CI / driver (pull_request) Successful in 2m57s
driver / standard (pull_request) Successful in 18s
driver / types (pull_request) Successful in 1m16s
driver / test (3.12) (pull_request) Successful in 1m11s
driver / test (3.13) (pull_request) Successful in 1m5s
driver / lowest (pull_request) Successful in 32s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 16s
get_route_to took the first word of every "ip route show" line as the
destination. For unreachable, blackhole, prohibit and throw routes that
word is the route type, so they came back as "unreachable/32" and the
like; a multipath route's continuation lines became "nexthop/32"
routes, and the route itself had no next hop.

The type word is now read as the type and reported in
protocol_attributes, without a next hop or outgoing interface for the
types that forward nothing (IPv6 names lo for them). nexthop lines
attach to the route before them, one entry per next hop. The test
fixture is ip's output (iproute2 6.1.0) recorded in a network
namespace set up with these routes.

Closes #57
2026-11-02 08:41:56 +01:00
Christian Manivong d3134c83b8 fix(sudo): run the whole command as root without a sudo password
Without a root login and without a sudo password, _run_privileged typed
"sudo -n <command>" into the interactive shell. sudo covered only the
first simple command of the line, and dnf's and yum's advisory query,
which starts with a brace group, did not parse at all: no status marker
ever arrived, so netmiko waited out the 120 s read timeout and
get_available_updates() failed. This is the default path for netOrk's
own NOPASSWD account.

The command now goes to "sudo -n sh -c" as one argument, as _as_root
already does with a password. A status echo at its end stays outside
sh -c: it reports sh's status, which is the command's, and still
arrives when sudo refuses.

Closes #56
2026-11-02 08:39:50 +01:00
Christian Manivong c2d7c4d1b4 fix(ping): quote the destination and source in the ping command
ping() typed its arguments into the interactive shell as they came, so a
destination such as "1.2.3.4; id" ran the command after the semicolon as
the login user. destination and source now go through shlex.quote, and
count, timeout, size and ttl are coerced with int(), which refuses
anything that is not a number before a command is sent.

The command is built in _ping.py, next to its parser, which keeps
linux.py within its recorded length.

Closes #55
2026-11-02 08:37:15 +01:00
christianmanivong 5687f5d9a1 Merge pull request 'fix(updates): read dnf and yum updates from the cached metadata (#59)' (#60) from fix/dnf-cache-only into main
driver / lint (push) Successful in 14s
driver / test (3.13) (push) Successful in 55s
driver / lowest (push) Successful in 29s
driver / build (push) Successful in 33s
driver / security (push) Successful in 1m8s
driver / publish (push) Skipped
driver / types (push) Successful in 1m3s
driver / test (3.12) (push) Successful in 1m11s
driver / standard (push) Successful in 16s
CI / driver (push) Successful in 2m49s
Reviewed-on: #60
2026-11-02 07:22:56 +00:00
Christian Manivong b891acd29c style(updates): keep linux.py within its recorded length
driver / lowest (pull_request) Successful in 29s
driver / build (pull_request) Successful in 30s
driver / security (pull_request) Successful in 1m7s
CI / driver (pull_request) Successful in 2m27s
driver / standard (pull_request) Successful in 14s
driver / lint (pull_request) Successful in 13s
driver / types (pull_request) Successful in 1m1s
driver / test (3.12) (pull_request) Successful in 59s
driver / test (3.13) (pull_request) Successful in 52s
driver / publish (pull_request) Skipped
The quality ratchet records 2142 lines for napalm_linux/linux.py; the docstring of the previous commit took it to 2147.
2026-11-02 08:18:42 +01:00
Christian Manivong d226ebf764 fix(updates): read dnf and yum updates from the cached metadata
driver / build (pull_request) Successful in 33s
driver / security (pull_request) Successful in 1m9s
CI / driver (pull_request) Failing after 2m30s
driver / standard (pull_request) Failing after 15s
driver / types (pull_request) Successful in 1m0s
driver / test (3.12) (pull_request) Failing after 1m1s
driver / test (3.13) (pull_request) Failing after 53s
driver / lowest (pull_request) Failing after 28s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 13s
`dnf check-update` and `yum check-update`, and yum's security query, download
the repositories' metadata first whenever the cached copy has expired. On an
Oracle Linux host on OCI that outlasted netOrk's 120 s poll on every run, and
the device went offline. They now run with --cacheonly, as apt's read uses its
local index; refresh_available_updates (`dnf makecache`) still refreshes it.
Without a cache the read fails at once and says to refresh the index. The
README row claimed check-update ran unprivileged; it runs as root.

dnf's security query is NAPALM/napalm-device-types#76.

Closes #59
2026-11-02 08:07:48 +01:00
christianmanivong 60ff9d9700 Merge pull request 'fix: six open bugs (#4, #43, #21, #17, #15, #6)' (#54) from fix/bugs-2026-11 into main
driver / lint (push) Successful in 14s
driver / test (3.13) (push) Successful in 1m2s
driver / lowest (push) Successful in 36s
driver / build (push) Successful in 30s
driver / security (push) Successful in 1m27s
driver / publish (push) Skipped
driver / types (push) Successful in 1m9s
driver / test (3.12) (push) Successful in 1m10s
driver / standard (push) Successful in 17s
CI / driver (push) Successful in 3m8s
2026-11-01 22:10:02 +00:00
Christian Manivong 897892b923 fix(routes): give the IPv6 default route ::/0
driver / lowest (pull_request) Successful in 37s
driver / build (pull_request) Successful in 38s
driver / security (pull_request) Successful in 1m20s
CI / driver (pull_request) Successful in 2m59s
driver / standard (pull_request) Successful in 17s
driver / lint (pull_request) Successful in 14s
driver / types (pull_request) Successful in 1m10s
driver / test (3.12) (pull_request) Successful in 1m8s
driver / test (3.13) (pull_request) Successful in 1m14s
driver / publish (pull_request) Skipped
get_route_to read "ip -4 route show && ip -6 route show" as one output
and mapped "default" to 0.0.0.0/0; the "default6" branch meant for IPv6
never matches, because ip -6 also prints "default". A dual-stack host
showed two 0.0.0.0/0 routes, one of them family ipv6. Each family is now
read with its own command, so "default" becomes ::/0 for IPv6 and a host
route without a prefix length a /128 there instead of a /32.

The line parse moves to napalm_linux/_routes.py.

Closes #6
2026-11-01 21:50:33 +01:00
Christian Manivong 69f1701ea6 fix(ping): read BusyBox's ping and IPv6 replies
ping() only knew the iputils summary. BusyBox, the ping on Alpine,
writes "2 packets received", so every target came back as an error and
the ping sweep counted it as down. Its probe lines ("seq=") and every
IPv6 reply were dropped by an IPv4-only per-probe pattern, and its
"round-trip min/avg/max" line without a deviation was not read.

The parse moves to napalm_linux/_ping.py and accepts both summaries
(also iputils' with "+N errors"), both RTT lines, IPv6 and named
replies. The shared Unix ping parser is still open as
NAPALM/napalm-device-types#12.

Closes #15
2026-11-01 21:49:28 +01:00