tests/test_time_sync.py::test_the_reading_is_one_round_trip_as_the_login_user fails on main (235c1e9) against napalm-device-types 4.36.0 or later:
AssertionError: assert {'ntp_servers'…, 'chrony', …} == {'ntp_servers'…on': 'chrony'}
Left contains 1 more item: {'dhcp_ntp_servers': []}
Why
napalm-device-types 4.36.0 added TimeSyncDict.dhcp_ntp_servers (the servers a device got by DHCP option 42; [] for none), and PosixTimeSyncMixin.get_time_sync now returns it. The test still compares against the dict without it.
Fix
Expect "dhcp_ntp_servers": [] in the test (and raise the floor in pyproject.toml to napalm-device-types>=4.36.0). Found while working on NetOrk/netork#2394; all other 412 tests pass.
## What happens
`tests/test_time_sync.py::test_the_reading_is_one_round_trip_as_the_login_user` fails on `main` (235c1e9) against napalm-device-types 4.36.0 or later:
```
AssertionError: assert {'ntp_servers'…, 'chrony', …} == {'ntp_servers'…on': 'chrony'}
Left contains 1 more item: {'dhcp_ntp_servers': []}
```
## Why
napalm-device-types 4.36.0 added `TimeSyncDict.dhcp_ntp_servers` (the servers a device got by DHCP option 42; `[]` for none), and `PosixTimeSyncMixin.get_time_sync` now returns it. The test still compares against the dict without it.
## Fix
Expect `"dhcp_ntp_servers": []` in the test (and raise the floor in `pyproject.toml` to `napalm-device-types>=4.36.0`). Found while working on NetOrk/netork#2394; all other 412 tests pass.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
What happens
tests/test_time_sync.py::test_the_reading_is_one_round_trip_as_the_login_userfails onmain(235c1e9) against napalm-device-types 4.36.0 or later:Why
napalm-device-types 4.36.0 added
TimeSyncDict.dhcp_ntp_servers(the servers a device got by DHCP option 42;[]for none), andPosixTimeSyncMixin.get_time_syncnow returns it. The test still compares against the dict without it.Fix
Expect
"dhcp_ntp_servers": []in the test (and raise the floor inpyproject.tomltonapalm-device-types>=4.36.0). Found while working on NetOrk/netork#2394; all other 412 tests pass.