NAPALM/napalm-fritzbox
1
0 Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

feat: report facts, not warnings (0.2.0) #5

Merged
christianmanivong merged 1 commits from feat/facts-not-warnings into master 2026-10-17 08:34:56 +00:00
Conversation 0 Commits 1 Files Changed 3
+6 -62
christianmanivong commented 2026-10-17 07:33:20 +00:00
Owner
Copy link
Copy source

Drops get_device_warnings. The DSL noise margin and the firmware on offer are already facts in get_system_config (dsl_downstream_noise_margin, firmware_update_available, firmware_version); netOrk derives dsl_snr_low and firmware_update_available from them with the same threshold (NetOrk/netork#1146, NetOrk/netork#1111).

The old tests for the warnings are replaced by one asserting the driver names none; the facts are covered by TestGetSystemConfig.

Part of #4 (the HealthMetricsMixin and lan points stay open).

Drops `get_device_warnings`. The DSL noise margin and the firmware on offer are already facts in `get_system_config` (`dsl_downstream_noise_margin`, `firmware_update_available`, `firmware_version`); netOrk derives `dsl_snr_low` and `firmware_update_available` from them with the same threshold (NetOrk/netork#1146, NetOrk/netork#1111). The old tests for the warnings are replaced by one asserting the driver names none; the facts are covered by `TestGetSystemConfig`. Part of #4 (the `HealthMetricsMixin` and `lan` points stay open).
christianmanivong added 1 commit 2026-10-17 07:33:20 +00:00
feat: report facts, not warnings (0.2.0)
CI / test (3.10) (push) Successful in 5m27s
Details
CI / test (3.11) (push) Successful in 5m24s
Details
CI / test (3.12) (push) Successful in 5m23s
Details
CI / test (3.10) (pull_request) Successful in 5m26s
Details
CI / test (3.11) (pull_request) Successful in 5m18s
Details
CI / test (3.12) (pull_request) Successful in 5m21s
Details
ec3e1e9028 
Drop get_device_warnings. The DSL noise margin and the firmware on offer
are already facts in get_system_config (dsl_downstream_noise_margin,
firmware_update_available, firmware_version); netOrk derives
dsl_snr_low and firmware_update_available from them (netOrk #1111).
christianmanivong merged commit 8145a9f479 into master 2026-10-17 08:34:56 +00:00
christianmanivong deleted branch feat/facts-not-warnings 2026-10-17 08:34:56 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is broken
 enhancement
New feature or request
 tech-debt
Refactoring / cleanup / deferred debt
prio
P0
Road blocker: blocks other work, drop everything
prio
P1
Critical
prio
P2
Important and urgent
prio
P3
Important, not urgent
prio
P4
Neither important nor urgent
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
christianmanivong
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-fritzbox#5