NAPALM/napalm-fritzbox
1
0 Fork 0
Code Issues 3 Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Agnostic structure: facts instead of warnings #4

New Issue
Open
opened 2026-10-14 08:58:53 +00:00 by christianmanivong · 1 comment
christianmanivong commented 2026-10-14 08:58:53 +00:00
Owner
Copy link
Copy source

What this driver has to change for the agnostic structure (NAPALM/napalm-device-types docs/STRUCTURE.md (NAPALM/napalm-device-types#37), epic NetOrk/netork#1105).

  • get_device_warnings goes: firmware_update_available (the fact is in get_system_config) and dsl_snr_low with its threshold 0 < snr_down < 60 (dB×10); the SNR is already reported as dsl_downstream_noise_margin. The warnings path also lacks the UserInterface1 fallback get_system_config has.
  • Inherits HealthMetricsMixin (FritzOS has no SNMP agent); goes with the deprecation.
  • Low: lan uses the hostname as an IP key with a fixed /24; a docstring names the poll cycle.

Size: small. Needs: NAPALM/napalm-device-types#34.

Prio P3.

What this driver has to change for the agnostic structure (NAPALM/napalm-device-types `docs/STRUCTURE.md` (NAPALM/napalm-device-types#37), epic NetOrk/netork#1105). - `get_device_warnings` goes: `firmware_update_available` (the fact is in `get_system_config`) and `dsl_snr_low` with its threshold `0 < snr_down < 60` (dB×10); the SNR is already reported as `dsl_downstream_noise_margin`. The warnings path also lacks the `UserInterface1` fallback `get_system_config` has. - Inherits `HealthMetricsMixin` (FritzOS has no SNMP agent); goes with the deprecation. - Low: `lan` uses the hostname as an IP key with a fixed /24; a docstring names the poll cycle. Size: small. Needs: NAPALM/napalm-device-types#34. Prio P3.
christianmanivong commented 2026-10-18 12:44:03 +00:00
Author
Owner
Copy link
Copy source

Status 2026-10-18, checked against the pin on NetOrk/netork main.

Done: get_device_warnings is gone (0.2.0, #5); netOrk derives dsl_snr_low and firmware_update_available from get_system_config. The poll-cycle docstring is gone.

Rest:

  • HealthMetricsMixin still comes in through ResidentialGatewayDriver; it goes with device-types 5.0 (NAPALM/napalm-device-types#36).
  • Low: get_interfaces_ip keys lan by the hostname with a fixed /24 (fritzbox.py:325).
Status 2026-10-18, checked against the pin on NetOrk/netork main. **Done:** `get_device_warnings` is gone (0.2.0, #5); netOrk derives `dsl_snr_low` and `firmware_update_available` from `get_system_config`. The poll-cycle docstring is gone. **Rest:** - `HealthMetricsMixin` still comes in through `ResidentialGatewayDriver`; it goes with device-types 5.0 (NAPALM/napalm-device-types#36). - Low: `get_interfaces_ip` keys `lan` by the hostname with a fixed `/24` (`fritzbox.py:325`).
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Something is broken
 enhancement
New feature or request
 tech-debt
Refactoring / cleanup / deferred debt
prio
P0
Road blocker: blocks other work, drop everything
prio
P1
Critical
prio
P2
Important and urgent
prio
P3
Important, not urgent
prio
P4
Neither important nor urgent
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
christianmanivong
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-fritzbox#4