christianmanivong
4eeaaef236
Merge pull request 'docs(structure): format the code examples as current ruff does' ( #80 ) from fix/ruff-markdown-format into main
driver / lint (push) Successful in 17s
driver / test (3.13) (push) Successful in 1m7s
driver / lowest (push) Successful in 44s
driver / build (push) Successful in 36s
driver / security (push) Successful in 1m22s
driver / publish (push) Skipped
driver / types (push) Successful in 1m15s
driver / test (3.12) (push) Successful in 1m20s
driver / standard (push) Successful in 20s
CI / driver (push) Successful in 3m2s
2026-11-02 09:23:57 +00:00
christianmanivong
3490d8b62a
docs(structure): format the code examples as current ruff does
...
driver / lowest (pull_request) Successful in 34s
driver / build (pull_request) Successful in 32s
driver / security (pull_request) Successful in 1m29s
CI / driver (pull_request) Successful in 3m21s
driver / standard (pull_request) Successful in 21s
driver / lint (pull_request) Successful in 17s
driver / types (pull_request) Successful in 1m5s
driver / test (3.12) (pull_request) Successful in 1m14s
driver / test (3.13) (pull_request) Successful in 1m7s
driver / publish (pull_request) Skipped
ruff 0.17 formats Python blocks in Markdown too, and CI installs ruff
unpinned, so the lint job on main failed on docs/STRUCTURE.md.
Closes #79
2026-11-02 09:18:42 +01:00
christianmanivong
ad9ec0fb4d
Merge pull request 'docs: a structure that keeps device-types vendor- and product-agnostic' ( #37 ) from docs/structure-plan into main
...
driver / lint (push) Failing after 13s
driver / test (3.13) (push) Successful in 1m2s
driver / lowest (push) Successful in 36s
driver / build (push) Successful in 42s
driver / security (push) Successful in 1m19s
driver / publish (push) Skipped
driver / test (3.12) (push) Successful in 1m0s
driver / types (push) Successful in 1m5s
driver / standard (push) Successful in 14s
CI / driver (push) Failing after 2m48s
Reviewed-on: #37
2026-11-02 07:19:02 +00:00
christianmanivong
8dd7e8ab9a
Merge branch 'main' into docs/structure-plan
driver / build (pull_request) Successful in 27s
driver / security (pull_request) Successful in 58s
CI / driver (pull_request) Failing after 2m22s
driver / standard (pull_request) Successful in 14s
driver / types (pull_request) Successful in 1m0s
driver / test (3.12) (pull_request) Successful in 58s
driver / test (3.13) (pull_request) Successful in 58s
driver / lowest (pull_request) Successful in 30s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Failing after 13s
2026-11-02 07:18:47 +00:00
christianmanivong
935fad2a2d
Merge pull request 'fix(updates): read dnf's security advisories from the cached metadata ( #76 )' ( #77 ) from fix/dnf-security-cache-only into main
...
driver / lint (push) Successful in 14s
driver / test (3.13) (push) Successful in 55s
driver / lowest (push) Successful in 31s
driver / build (push) Successful in 31s
driver / security (push) Successful in 1m3s
driver / publish (push) Skipped
driver / types (push) Successful in 1m1s
driver / test (3.12) (push) Successful in 1m1s
driver / standard (push) Failing after 2s
CI / driver (push) Failing after 2m6s
Reviewed-on: #77
2026-11-02 07:18:33 +00:00
christianmanivong
f337ae7fb8
fix(updates): read dnf's security advisories from the cached metadata
...
driver / build (pull_request) Successful in 25s
driver / security (pull_request) Successful in 57s
CI / driver (pull_request) Successful in 2m27s
driver / standard (pull_request) Successful in 15s
driver / types (pull_request) Successful in 55s
driver / test (3.12) (pull_request) Successful in 1m2s
driver / lowest (pull_request) Successful in 32s
driver / test (3.13) (pull_request) Successful in 1m4s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 13s
DNF_SECURITY_COMMAND ran `dnf updateinfo list --security`, which downloads
the repositories' metadata first whenever the cached copy has expired. On an
Oracle Linux host on OCI that took longer than netOrk's whole 120 s poll.
It now runs with --cacheonly, as APT_UPGRADABLE_COMMAND reads apt's local
index; refreshing stays `dnf makecache`. Without a cache dnf fails at once,
and the __DNF_RC marker already turns that into "security unknown".
Closes #76
2026-11-02 08:07:48 +01:00
christianmanivong
e2aebeadeb
Merge pull request 'chore(release): 4.23.0' ( #75 ) from chore/release-4.23.0 into main
driver / lint (push) Successful in 19s
driver / test (3.13) (push) Successful in 1m16s
driver / lowest (push) Successful in 32s
driver / build (push) Successful in 30s
driver / security (push) Successful in 1m6s
driver / publish (push) Successful in 44s
driver / types (push) Successful in 1m18s
driver / test (3.12) (push) Successful in 1m24s
driver / standard (push) Successful in 21s
CI / driver (push) Successful in 3m29s
v4.23.0
2026-11-01 23:26:04 +00:00
christianmanivong
36cf117b95
chore(release): 4.23.0
driver / lowest (pull_request) Successful in 31s
driver / build (pull_request) Successful in 31s
driver / security (pull_request) Successful in 1m0s
CI / driver (pull_request) Successful in 2m22s
driver / standard (pull_request) Successful in 16s
driver / lint (pull_request) Successful in 13s
driver / types (pull_request) Successful in 57s
driver / test (3.12) (pull_request) Successful in 1m2s
driver / test (3.13) (pull_request) Successful in 58s
driver / publish (pull_request) Skipped
2026-11-02 00:21:38 +01:00
christianmanivong
02d461036b
Merge pull request 'feat: TLS certificates by trust on first use' ( #74 ) from feat/tls-fingerprint-tofu into main
driver / lint (push) Successful in 15s
driver / test (3.13) (push) Successful in 57s
driver / lowest (push) Successful in 34s
driver / build (push) Successful in 27s
driver / security (push) Successful in 1m3s
driver / publish (push) Skipped
driver / types (push) Successful in 1m5s
driver / test (3.12) (push) Successful in 1m4s
driver / standard (push) Successful in 16s
CI / driver (push) Successful in 2m16s
2026-11-01 23:21:03 +00:00
christianmanivong
63039ce758
fix(types): the adapter's ignore holds with and without requests' stubs
...
driver / build (pull_request) Successful in 26s
driver / security (pull_request) Successful in 53s
CI / driver (pull_request) Successful in 2m12s
driver / standard (pull_request) Successful in 15s
driver / types (pull_request) Successful in 57s
driver / test (3.13) (pull_request) Successful in 1m4s
driver / test (3.12) (pull_request) Successful in 1m10s
driver / lowest (pull_request) Successful in 30s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 14s
CI installs types-requests, so HTTPAdapter is typed there and the
ignore for subclassing an untyped base is unused; locally it is needed.
2026-11-02 00:15:55 +01:00
christianmanivong
516fb18c0e
Merge remote-tracking branch 'origin/main' into feat/tls-fingerprint-tofu
...
driver / lowest (pull_request) Successful in 34s
driver / build (pull_request) Successful in 28s
driver / security (pull_request) Successful in 59s
CI / driver (pull_request) Failing after 2m34s
driver / standard (pull_request) Successful in 15s
driver / test (3.13) (pull_request) Successful in 1m14s
driver / types (pull_request) Failing after 1m35s
driver / test (3.12) (pull_request) Successful in 1m27s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 14s
# Conflicts:
# CHANGELOG.md
2026-11-02 00:06:53 +01:00
christianmanivong
8d32e70cd7
Merge pull request 'feat(fixes): configure_lldp_agent(interfaces) template' ( #73 ) from feat/lldp-agent-template into main
driver / lint (push) Successful in 25s
driver / lowest (push) Successful in 34s
driver / test (3.13) (push) Successful in 1m8s
driver / build (push) Successful in 37s
driver / security (push) Successful in 1m15s
driver / publish (push) Skipped
driver / test (3.12) (push) Failing after 6s
driver / types (push) Successful in 1m15s
driver / standard (push) Successful in 24s
CI / driver (push) Failing after 2m19s
2026-11-01 23:06:48 +00:00
christianmanivong
51e8c849bb
Merge remote-tracking branch 'origin/main' into feat/lldp-agent-template
...
driver / lowest (pull_request) Successful in 38s
driver / build (pull_request) Successful in 33s
driver / security (pull_request) Successful in 1m10s
CI / driver (pull_request) Successful in 2m45s
driver / standard (pull_request) Successful in 18s
driver / types (pull_request) Successful in 1m6s
driver / test (3.13) (pull_request) Successful in 1m6s
driver / test (3.12) (pull_request) Successful in 1m14s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 14s
# Conflicts:
# CHANGELOG.md
2026-11-02 00:01:46 +01:00
christianmanivong
6aadcc3d91
Merge pull request 'feat(snmp): let a health profile mark a value unknown' ( #72 ) from feat/health-profile-unknown into main
driver / lint (push) Successful in 17s
driver / test (3.13) (push) Successful in 1m15s
driver / security (push) Failing after 3s
driver / lowest (push) Successful in 41s
driver / build (push) Successful in 31s
driver / publish (push) Skipped
driver / types (push) Successful in 1m4s
driver / test (3.12) (push) Successful in 1m17s
driver / standard (push) Successful in 19s
CI / driver (push) Failing after 2m6s
2026-11-01 23:01:40 +00:00
christianmanivong
e98d4763f3
Merge remote-tracking branch 'origin/main' into feat/health-profile-unknown
...
driver / build (pull_request) Successful in 29s
driver / security (pull_request) Successful in 1m11s
CI / driver (pull_request) Successful in 2m57s
driver / standard (pull_request) Successful in 19s
driver / types (pull_request) Successful in 1m7s
driver / test (3.12) (pull_request) Successful in 1m8s
driver / test (3.13) (pull_request) Successful in 1m9s
driver / lowest (pull_request) Successful in 40s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 18s
# Conflicts:
# CHANGELOG.md
2026-11-01 23:56:39 +01:00
christianmanivong
24f4be3b7e
Merge pull request 'feat: VMProvisionIncomplete names the VM a failed creation left behind' ( #70 ) from feat/vm-create-partial-failure into main
driver / lint (push) Successful in 18s
driver / test (3.13) (push) Successful in 1m9s
driver / lowest (push) Successful in 35s
driver / build (push) Successful in 38s
driver / security (push) Successful in 1m10s
driver / publish (push) Skipped
driver / types (push) Successful in 1m6s
driver / test (3.12) (push) Successful in 1m16s
driver / standard (push) Successful in 19s
CI / driver (push) Successful in 2m38s
2026-11-01 22:56:34 +00:00
christianmanivong
f4354f498e
refactor: the SNMP health profile shapes in snmp_health_profile.py
...
models.py is over the file size limit and may not grow; the unknown
key pushed it past its recorded length. SnmpHealthProfile,
SnmpValueSpec, SnmpMemorySpec and SnmpInterfacesSpec move to
napalm_device_types/snmp_health_profile.py. The package exports them
as before and models re-exports them, so existing imports keep working.
The baseline records the smaller models.py.
2026-11-01 23:05:13 +01:00
christianmanivong
73771aba00
docs: a tighter create_vm_from_cloud_init docstring
...
driver / build (pull_request) Successful in 30s
driver / security (pull_request) Successful in 1m6s
CI / driver (pull_request) Successful in 2m52s
driver / standard (pull_request) Successful in 16s
driver / types (pull_request) Successful in 1m7s
driver / test (3.12) (pull_request) Successful in 1m12s
driver / lowest (pull_request) Successful in 35s
driver / test (3.13) (pull_request) Successful in 1m11s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 18s
The VMProvisionIncomplete entry pushed the method past its recorded
length in the quality baseline. The image-cache note joins the
paragraph it repeated, and the Raises entry takes two lines; nothing
it says is dropped.
2026-11-01 23:02:46 +01:00
christianmanivong
c9571d59f1
Merge remote-tracking branch 'origin/main' into feat/tls-fingerprint-tofu
...
# Conflicts:
# CHANGELOG.md
2026-11-01 23:01:38 +01:00
christianmanivong
cf862af026
Merge remote-tracking branch 'origin/main' into feat/lldp-agent-template
...
# Conflicts:
# CHANGELOG.md
2026-11-01 23:01:38 +01:00
christianmanivong
83ea13f88e
Merge remote-tracking branch 'origin/main' into feat/health-profile-unknown
...
# Conflicts:
# CHANGELOG.md
2026-11-01 23:01:38 +01:00
christianmanivong
4938056d20
Merge remote-tracking branch 'origin/main' into feat/vm-create-partial-failure
...
# Conflicts:
# CHANGELOG.md
2026-11-01 23:01:38 +01:00
christianmanivong
9c3be46d8a
Merge pull request 'feat: HA state, backups, quorum votes, migrate_vm and node maintenance' ( #71 ) from feat/vm-lifecycle into main
driver / lint (push) Successful in 15s
driver / test (3.13) (push) Successful in 53s
driver / lowest (push) Successful in 30s
driver / build (push) Successful in 27s
driver / security (push) Successful in 56s
driver / publish (push) Skipped
driver / types (push) Successful in 58s
driver / test (3.12) (push) Successful in 1m3s
driver / standard (push) Successful in 16s
CI / driver (push) Successful in 2m29s
2026-11-01 21:48:11 +00:00
christianmanivong
a6289cb24a
feat: HA state, backups, quorum votes, migrate_vm and node maintenance
...
driver / build (pull_request) Successful in 27s
driver / security (pull_request) Successful in 1m3s
CI / driver (pull_request) Successful in 2m30s
driver / standard (pull_request) Successful in 15s
driver / types (pull_request) Successful in 58s
driver / test (3.12) (pull_request) Successful in 59s
driver / lowest (pull_request) Successful in 30s
driver / test (3.13) (pull_request) Successful in 58s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 12s
get_clusters() may also report the cluster's HA resources, backup jobs, the
newest backup per guest and storage, and each node's quorum votes (all
NotRequired; None means not read). HypervisorDriver declares
get_vm_migration_preflight(), migrate_vm() and set_node_maintenance(); the
preflight shape lives in vm_migration.py.
Part of NetOrk/netork#1820 (stage 7: #759 , #760 , #761 ).
2026-11-01 22:15:01 +01:00
christianmanivong
46c1c9dc4e
feat: TLS certificates by trust on first use
...
driver / lowest (pull_request) Successful in 38s
driver / build (pull_request) Successful in 34s
driver / security (pull_request) Successful in 1m13s
CI / driver (pull_request) Failing after 3m4s
driver / standard (pull_request) Successful in 17s
driver / lint (pull_request) Successful in 20s
driver / types (pull_request) Failing after 1m10s
driver / test (3.12) (pull_request) Successful in 1m14s
driver / test (3.13) (pull_request) Successful in 1m4s
driver / publish (pull_request) Skipped
Devices ship self-signed certificates, so a driver either fails the CA
check on every one of them or turns verification off and sends the
login to whatever answers on the address. tls_certificates pins the
certificate by its SHA-256 fingerprint instead, shaped like
ssh_host_keys: the caller passes the fingerprint to expect by port
(optional_args["tls_fingerprints"]), the driver refuses any other
certificate before a request carries credentials, and every certificate
seen goes to optional_args["tls_certificate_observer"]. Without a
fingerprint the first certificate is accepted.
CertificateCheck checks the certificate in a handshake of its own, then
pins a requests session to it (urllib3's assert_fingerprint, direct and
through a proxy), so no other host can step in between the check and
the login.
Refs NAPALM/napalm-hpe-aruba-procurve#17
2026-11-01 22:13:20 +01:00
christianmanivong
bc17862a44
feat(fixes): configure_lldp_agent(interfaces) template
...
driver / build (pull_request) Successful in 28s
driver / security (pull_request) Successful in 58s
CI / driver (pull_request) Successful in 2m32s
driver / standard (pull_request) Successful in 15s
driver / types (pull_request) Successful in 57s
driver / test (3.12) (pull_request) Successful in 1m7s
driver / test (3.13) (pull_request) Successful in 56s
driver / lowest (pull_request) Successful in 30s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 12s
LLDP getters used to install, start and reconfigure lldpd on their own,
on every poll. Getters only read now, so starting the agent needs an
action the application calls. The template installs the agent through
ensure_package, has the driver write the interfaces it runs on, then
enables and restarts it through manage_service. The caller names the
interfaces: an agent on every interface also advertises on a WAN port.
Refs NAPALM/napalm-openwrt#8
2026-11-01 22:11:21 +01:00
christianmanivong
9f6ffa8a25
feat(snmp): let a health profile mark a value unknown
...
driver / build (pull_request) Successful in 27s
driver / security (pull_request) Successful in 1m1s
CI / driver (pull_request) Failing after 2m30s
driver / standard (pull_request) Failing after 15s
driver / types (pull_request) Successful in 58s
driver / test (3.12) (pull_request) Successful in 1m3s
driver / test (3.13) (pull_request) Successful in 56s
driver / lowest (pull_request) Successful in 35s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 13s
SnmpValueSpec gains `unknown`. A driver whose device's agent answers a
value wrongly says so in its SNMP_HEALTH_PROFILE, and the application
reports no value for it instead of the standard reading or a default.
OpenBSD's net-snmp reports the CPU as never idle, so a reading of
ssCpuIdle shows every OpenBSD host at 100 % (NAPALM/napalm-bsd#7 ).
2026-11-01 22:11:19 +01:00
christianmanivong
4150570a94
feat: VMProvisionIncomplete names the VM a failed creation left behind
...
driver / lowest (pull_request) Successful in 37s
driver / build (pull_request) Successful in 35s
driver / security (pull_request) Successful in 1m15s
CI / driver (pull_request) Failing after 3m1s
driver / standard (pull_request) Failing after 17s
driver / lint (pull_request) Successful in 16s
driver / types (pull_request) Successful in 1m5s
driver / test (3.12) (pull_request) Successful in 1m13s
driver / test (3.13) (pull_request) Successful in 1m6s
driver / publish (pull_request) Skipped
create_vm_from_cloud_init raised a plain error once the VM existed, so the
caller had no id to remove it by. The new RuntimeError carries vmid and
node, with the failure as its cause; a failure before the VM exists raises
as before.
Refs NAPALM/napalm-proxmox#28
2026-11-01 22:09:01 +01:00
christianmanivong
a809e6c02f
Merge pull request 'feat: get_clusters() and create_vm_from_cloud_init(node=)' ( #68 ) from feat/cluster-inventory into main
driver / lint (push) Successful in 20s
driver / test (3.13) (push) Successful in 1m21s
driver / lowest (push) Successful in 39s
driver / build (push) Successful in 35s
driver / security (push) Successful in 1m16s
driver / publish (push) Skipped
driver / types (push) Successful in 1m30s
driver / test (3.12) (push) Successful in 1m26s
driver / standard (push) Failing after 7s
CI / driver (push) Failing after 2m49s
2026-11-01 18:41:05 +00:00
christianmanivong
5b894913e1
refactor: the cluster shapes in clusters.py, a shorter provisioning docstring
...
driver / lowest (pull_request) Successful in 32s
driver / build (pull_request) Successful in 27s
driver / security (pull_request) Successful in 1m4s
CI / driver (pull_request) Successful in 2m16s
driver / standard (pull_request) Successful in 15s
driver / types (pull_request) Successful in 1m1s
driver / test (3.13) (pull_request) Successful in 57s
driver / test (3.12) (pull_request) Successful in 1m4s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 14s
models.py is over the file size limit and may not grow, and the declaration
of create_vm_from_cloud_init() may not get longer: the four cluster shapes
move to napalm_device_types/clusters.py (exported from the package as
before), and the docstring says the same in fewer lines.
Refs NetOrk/netork#484
2026-11-01 17:08:10 +01:00
christianmanivong
00aa5efef0
feat: get_clusters() and create_vm_from_cloud_init(node=)
...
driver / lowest (pull_request) Successful in 32s
driver / build (pull_request) Successful in 28s
driver / security (pull_request) Successful in 1m0s
CI / driver (pull_request) Failing after 2m32s
driver / lint (pull_request) Successful in 16s
driver / standard (pull_request) Failing after 19s
driver / types (pull_request) Successful in 1m10s
driver / test (3.13) (pull_request) Successful in 1m13s
driver / test (3.12) (pull_request) Successful in 1m19s
driver / publish (pull_request) Skipped
A hypervisor reports every cluster its connection can see: the cluster's
name and quorum, its nodes (offline ones too, the local one marked) with
CPU and memory, and the storages and networks with the nodes that see
each. A standalone host is a cluster of one without a name; a manager
reports each cluster and standalone host it runs. Declared only, so a
capability check stays truthful.
create_vm_from_cloud_init() takes the node to create the VM on; a driver
that can only create on its own node refuses another.
Refs NetOrk/netork#484 , NetOrk/netork#1822
2026-11-01 16:38:38 +01:00
christianmanivong
97cb8779c5
Merge pull request 'feat: netOrk's own account through the current login (NetOrk/netork#1817)' ( #67 ) from feature/system-user-1817 into main
driver / lint (push) Successful in 15s
driver / test (3.13) (push) Successful in 1m0s
driver / lowest (push) Successful in 30s
driver / build (push) Successful in 26s
driver / security (push) Successful in 1m0s
driver / publish (push) Skipped
driver / types (push) Successful in 57s
driver / test (3.12) (push) Successful in 1m6s
driver / standard (push) Successful in 16s
CI / driver (push) Successful in 2m16s
2026-11-01 12:39:41 +00:00
christianmanivong
47751d12d6
fix: another service's account of the same name is left alone ( NetOrk/netork#1817 )
...
driver / lowest (pull_request) Successful in 30s
driver / security (pull_request) Successful in 55s
driver / build (pull_request) Successful in 26s
CI / driver (pull_request) Successful in 56s
driver / standard (pull_request) Successful in 15s
driver / types (pull_request) Successful in 1m1s
driver / test (3.13) (pull_request) Successful in 59s
driver / test (3.12) (pull_request) Successful in 56s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 14s
On bw-01, netork is the satellite's own user (nologin, in docker).
add_service_account opened it, gave it the passwordless sudo rule and netOrk's
key, and only the login as it failed. An account that is there and cannot log
in (nologin, false) is now refused before anything changes.
2026-11-01 13:36:38 +01:00
christianmanivong
3f59023f46
feat: a fixed uid for netOrk's own account ( NetOrk/netork#1817 )
...
driver / lowest (pull_request) Successful in 31s
driver / security (pull_request) Successful in 1m3s
driver / build (pull_request) Successful in 26s
CI / driver (pull_request) Successful in 1m10s
driver / standard (pull_request) Successful in 16s
driver / lint (pull_request) Successful in 14s
driver / types (pull_request) Successful in 1m8s
driver / test (3.13) (pull_request) Successful in 1m2s
driver / test (3.12) (pull_request) Successful in 1m10s
driver / publish (pull_request) Skipped
add_service_account(uid=) makes a new account with that uid once no other
account has it, through the driver's _account_create_with_uid; an account that
is there keeps its own, as a uid is never changed under files that carry it.
The infrastructure's build standard wants the same uid on every host.
2026-11-01 12:42:30 +01:00
christianmanivong
666be091e3
feat: netOrk's own account through the current login ( NetOrk/netork#1817 )
...
driver / build (pull_request) Successful in 38s
driver / security (pull_request) Successful in 1m19s
CI / driver (pull_request) Failing after 2m35s
driver / standard (pull_request) Successful in 21s
driver / types (pull_request) Successful in 1m10s
driver / test (3.12) (pull_request) Successful in 1m9s
driver / test (3.13) (pull_request) Successful in 1m6s
driver / lowest (pull_request) Successful in 50s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Failing after 7s
add_service_account(name, public_key) creates or reopens the account through
the login the driver uses today: a key and no password, and a rule of its own
in 85-service-<name> that lets it run everything as root without a password,
checked with visudo and sudo -l. Root is refused; run again with the account
the driver already logs in with, it only adds what is missing.
2026-11-01 12:03:01 +01:00
christianmanivong
25cc264306
Merge pull request 'fix(apt_proxy): https sources take the http proxy too (NetOrk/netork#1811)' ( #64 ) from fix/apt-https-proxy into main
driver / lint (push) Successful in 15s
driver / test (3.13) (push) Successful in 1m4s
driver / lowest (push) Successful in 30s
driver / build (push) Successful in 26s
driver / security (push) Successful in 59s
driver / publish (push) Skipped
driver / types (push) Successful in 1m4s
driver / test (3.12) (push) Successful in 1m10s
driver / standard (push) Successful in 15s
CI / driver (push) Successful in 2m18s
2026-11-01 07:25:56 +00:00
christianmanivong
86959b7599
Merge remote-tracking branch 'origin/main' into fix/apt-https-proxy
driver / build (pull_request) Successful in 33s
driver / security (pull_request) Successful in 1m7s
CI / driver (pull_request) Successful in 2m50s
driver / standard (pull_request) Successful in 16s
driver / types (pull_request) Successful in 1m11s
driver / test (3.12) (pull_request) Successful in 1m12s
driver / test (3.13) (pull_request) Successful in 1m0s
driver / lowest (pull_request) Successful in 33s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 15s
2026-11-01 08:21:18 +01:00
christianmanivong
8664accbc4
Merge pull request 'refactor(ssh_server): split three functions under the standard's line limit ( #65 )' ( #66 ) from fix/ssh-server-ratchet into main
driver / lint (push) Successful in 17s
driver / test (3.13) (push) Successful in 1m7s
driver / lowest (push) Successful in 31s
driver / build (push) Successful in 28s
driver / security (push) Successful in 1m16s
driver / publish (push) Skipped
driver / types (push) Successful in 1m1s
driver / test (3.12) (push) Successful in 1m3s
driver / standard (push) Successful in 21s
CI / driver (push) Successful in 2m37s
2026-11-01 07:21:11 +00:00
christianmanivong
449a6b13ca
refactor(ssh_server): split three functions under the standard's line limit ( #65 )
...
driver / lowest (pull_request) Successful in 35s
driver / build (pull_request) Successful in 33s
driver / security (pull_request) Successful in 1m9s
CI / driver (pull_request) Successful in 3m9s
driver / standard (pull_request) Successful in 17s
driver / lint (pull_request) Successful in 15s
driver / types (pull_request) Successful in 1m18s
driver / test (3.12) (pull_request) Successful in 1m28s
driver / test (3.13) (pull_request) Successful in 1m18s
driver / publish (pull_request) Skipped
harden_ssh_server (70), _apply_or_restore (51) and exempt_from_ssh_penalties
(81) had grown past the 50-line limit with #63 , and `driver / standard` was
red on main. The reading and planning, the putting back, the session's
address, the reasons to leave the exemption and its write move into methods
of their own. Same behaviour, same tests; harden_ssh_server leaves the
baseline.
2026-11-01 08:17:27 +01:00
christianmanivong
c71ddd7fe6
refactor(apt_proxy): smaller parts, under the standard's complexity limit
...
driver / build (pull_request) Successful in 55s
driver / security (pull_request) Successful in 1m33s
CI / driver (pull_request) Failing after 3m0s
driver / standard (pull_request) Failing after 20s
driver / types (pull_request) Successful in 1m8s
driver / test (3.13) (pull_request) Successful in 1m6s
driver / test (3.12) (pull_request) Successful in 1m12s
driver / lowest (pull_request) Successful in 47s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 17s
The quality ratchet counted _dump, parse_apt_proxy and _https_direct over
complexity 10 (NetOrk/netork#1811 ). Same behaviour, same tests.
2026-11-01 08:13:20 +01:00
christianmanivong
3b6c5f9585
fix(apt_proxy): https sources take the http proxy too ( NetOrk/netork#1811 )
...
driver / lowest (pull_request) Successful in 33s
driver / build (pull_request) Successful in 28s
driver / security (pull_request) Successful in 1m1s
CI / driver (pull_request) Failing after 2m22s
driver / lint (pull_request) Successful in 17s
driver / standard (pull_request) Failing after 18s
driver / types (pull_request) Successful in 1m7s
driver / test (3.13) (pull_request) Successful in 1m3s
driver / test (3.12) (pull_request) Successful in 1m7s
driver / publish (pull_request) Skipped
apt's https method asks Acquire::https::Proxy and then Acquire::http::Proxy,
for the host and then for all. An 00proxy with the http line alone therefore
sent download.docker.com and every other https source to apt-cacher-ng, which
answers 403 CONNECT denied without a PassThroughPattern, and the whole upgrade
failed.
- The report carries https_proxy, https_per_host and https_settings;
https_proxy_for(report, host) is the proxy apt takes for one https host.
- check_https_source() fetches one https source the way apt does.
- configure_package_proxy gains an https step: one https source through the
new proxy. Where the proxy refuses it, 00proxy also says
Acquire::https::Proxy "DIRECT", later https lines to the same proxy are
commented out, and the source is fetched direct. An HTTP error from the
mirror counts as let through.
- apt_fetch_command takes https URLs; comment_out_command takes a scheme.
2026-11-01 07:58:05 +01:00
christianmanivong
1c71fe6896
Merge pull request 'feat: LocalAccountsMixin, personal accounts added and locked again (NetOrk/netork#1793)' ( #62 ) from feat/local-accounts into main
...
driver / lint (push) Successful in 14s
driver / lowest (push) Failing after 5s
driver / test (3.13) (push) Successful in 1m2s
driver / build (push) Successful in 31s
driver / security (push) Successful in 1m11s
driver / publish (push) Skipped
driver / test (3.12) (push) Successful in 1m4s
driver / types (push) Successful in 1m6s
driver / standard (push) Failing after 16s
CI / driver (push) Failing after 2m47s
Reviewed-on: #62
2026-10-31 23:45:34 +00:00
christianmanivong
9159106837
Merge remote-tracking branch 'origin/main' into feat/local-accounts
...
driver / build (pull_request) Successful in 32s
driver / security (pull_request) Successful in 59s
CI / driver (pull_request) Failing after 2m35s
driver / standard (pull_request) Failing after 18s
driver / types (pull_request) Successful in 59s
driver / test (3.12) (pull_request) Successful in 1m7s
driver / lowest (pull_request) Successful in 31s
driver / test (3.13) (pull_request) Successful in 58s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 13s
# Conflicts:
# CHANGELOG.md
2026-11-01 00:45:06 +01:00
christianmanivong
28ff14589b
Merge pull request 'feat: the managing client and sshd's per-source penalties (NetOrk/netork#1800)' ( #63 ) from feat/ssh-penalties-1800 into main
...
driver / lint (push) Successful in 14s
driver / test (3.13) (push) Successful in 58s
driver / lowest (push) Successful in 30s
driver / build (push) Successful in 30s
driver / security (push) Successful in 1m4s
driver / publish (push) Skipped
driver / types (push) Successful in 1m2s
driver / test (3.12) (push) Successful in 1m4s
driver / standard (push) Failing after 17s
CI / driver (push) Failing after 2m21s
Reviewed-on: #63
2026-10-31 23:29:09 +00:00
christianmanivong
5fffb3b886
feat: the managing client and sshd's per-source penalties ( NetOrk/netork#1800 )
...
driver / lowest (pull_request) Successful in 33s
driver / build (pull_request) Successful in 30s
driver / security (pull_request) Successful in 1m4s
CI / driver (pull_request) Failing after 2m24s
driver / standard (pull_request) Failing after 9s
driver / types (pull_request) Successful in 1m14s
driver / test (3.12) (pull_request) Successful in 1m11s
driver / test (3.13) (pull_request) Successful in 1m7s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 22s
OpenSSH 9.8+ penalises a source whose connections do not authenticate --
a scanner's probes -- and then drops every connection from it, the
managing client's included.
- OpenSshServerMixin.exempt_from_ssh_penalties puts the address the host
sees the client at ($SSH_CONNECTION) into PerSourcePenaltyExemptList,
next to the host's own exemptions, in its own drop-in. Only where sshd
has the penalties (an older one refuses the directive) and includes the
drop-in directory; checked with sshd -t, sshd -T and a new session, and
taken back on any failure. The check-and-restore step of
harden_ssh_server is shared for it.
- retry_refused tries a connection again after 1, 3, 7 and 15 s while
sshd closes it before its banner; HostKeyCheck.connect uses it.
2026-11-01 00:24:11 +01:00
christianmanivong
2846824a21
feat: a host may add a key file sshd reads ( NetOrk/netork#1793 )
...
driver / lowest (pull_request) Successful in 39s
driver / build (pull_request) Successful in 32s
driver / security (pull_request) Successful in 1m5s
CI / driver (pull_request) Successful in 2m45s
driver / standard (pull_request) Successful in 17s
driver / lint (pull_request) Successful in 14s
driver / types (pull_request) Successful in 1m6s
driver / test (3.12) (pull_request) Successful in 1m14s
driver / test (3.13) (pull_request) Successful in 1m23s
driver / publish (pull_request) Skipped
_account_key_files says which files hold an account's keys; the default is
~/.ssh/authorized_keys and authorized_keys2. OpenMediaVault adds the file it
deploys under /var/lib/openmediavault/ssh/authorized_keys, so reading an
account back sees every key sshd would take.
2026-10-31 23:31:05 +01:00
christianmanivong
0545d1d814
feat: a driver may keep the account keys elsewhere ( NetOrk/netork#1793 )
...
driver / lowest (pull_request) Successful in 36s
driver / build (pull_request) Successful in 34s
driver / security (pull_request) Successful in 1m9s
CI / driver (pull_request) Successful in 2m44s
driver / standard (pull_request) Successful in 16s
driver / lint (pull_request) Successful in 13s
driver / types (pull_request) Successful in 1m6s
driver / test (3.13) (pull_request) Successful in 1m8s
driver / test (3.12) (pull_request) Successful in 1m14s
driver / publish (pull_request) Skipped
OpenMediaVault keeps a user's keys in its own database and deploys them
to /var/lib/openmediavault/ssh/authorized_keys, and creates a home only
when its home directory setting is on. The key store becomes three hooks
with the ~/.ssh default: _account_read_keys, _account_add_key and
_account_remove_keys, each given the account's home.
2026-10-31 23:29:46 +01:00
christianmanivong
49c65cbd5d
feat: LocalAccountsMixin, personal accounts added and locked again ( NetOrk/netork#1793 )
...
driver / lowest (pull_request) Successful in 46s
driver / build (pull_request) Successful in 36s
driver / security (pull_request) Successful in 1m21s
CI / driver (pull_request) Successful in 3m6s
driver / standard (pull_request) Successful in 25s
driver / types (pull_request) Successful in 1m36s
driver / test (3.13) (pull_request) Successful in 1m15s
driver / test (3.12) (pull_request) Successful in 1m41s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 30s
get_local_accounts(names) reads a person's account back: groups, lock,
sudo, key files. add_local_account() creates or reopens one with the
person's key, optional password hash and optional sudo rule;
lock_local_account() takes the keys and sudo away and refuses every
login, keeping the home.
Every command root runs is one fixed command, so a sudoers allowlist can
name it. The key files are read and written as the person (sudo -n -u),
never as root, since a link in a home the person owns may point anywhere.
The sudo rule is a drop-in of its own, checked with visudo before and
sudo -l after; a rule elsewhere (cloud-init's) is reported, not edited.
The login user's own account and system accounts are refused.
A driver supplies creating, opening, locking, reading the lock and
leaving a group.
2026-10-31 23:24:27 +01:00
christianmanivong
888a7229dc
Merge pull request 'feat: SudoHistoryMixin, the sudo password left in shell histories (NetOrk/netork#1090)' ( #60 ) from feat/sudo-history-cleanup into main
driver / lint (push) Successful in 16s
driver / test (3.13) (push) Successful in 1m3s
driver / lowest (push) Successful in 32s
driver / build (push) Successful in 34s
driver / security (push) Successful in 1m5s
driver / publish (push) Skipped
driver / types (push) Successful in 1m1s
driver / test (3.12) (push) Successful in 1m10s
driver / standard (push) Successful in 17s
CI / driver (push) Successful in 2m25s
2026-10-30 20:47:48 +00:00
christianmanivong
0f0064c2d7
test: the fake host never answers with this machine's uid
...
driver / lowest (pull_request) Successful in 36s
driver / build (pull_request) Successful in 30s
driver / security (pull_request) Successful in 1m2s
CI / driver (pull_request) Successful in 2m32s
driver / lint (pull_request) Successful in 15s
driver / standard (pull_request) Successful in 19s
driver / types (pull_request) Successful in 1m14s
driver / test (3.12) (pull_request) Successful in 1m14s
driver / test (3.13) (pull_request) Successful in 1m16s
driver / publish (pull_request) Skipped
CI runs as root, which the owner step skips, so three owner tests failed there
while they passed for a normal user.
2026-10-30 21:44:40 +01:00