ssh_server: three functions over the standard's line limit, driver / standard red on main #65

Closed
opened 2026-11-01 07:13:30 +00:00 by christianmanivong · 0 comments
Owner

Prio: P2 (it blocks every PR in this repo: driver / standard is red on main, so no PR can go green)

napalm-standard ratchet fails on main (1c71fe6) since #63 (SSH penalties, NetOrk/netork#1800):

function_lines: napalm_device_types/ssh_server.py::OpenSshServerMixin._apply_or_restore = 51 (new)
function_lines: napalm_device_types/ssh_server.py::OpenSshServerMixin.exempt_from_ssh_penalties = 81 (new)
function_lines: napalm_device_types/ssh_server.py::OpenSshServerMixin.harden_ssh_server = 70 (recorded 52)

The limit is 50 lines per function. Two functions are new and one grew. CI on the push of 1c71fe6 shows driver / standard (push) failing. The same failure now stops #64 (NetOrk/netork#1811), whose own functions pass.

Fix: split the three functions, or record a justified exception in the ratchet baseline.

Prio: P2 (it blocks every PR in this repo: `driver / standard` is red on main, so no PR can go green) `napalm-standard ratchet` fails on `main` (1c71fe6) since #63 (SSH penalties, NetOrk/netork#1800): ``` function_lines: napalm_device_types/ssh_server.py::OpenSshServerMixin._apply_or_restore = 51 (new) function_lines: napalm_device_types/ssh_server.py::OpenSshServerMixin.exempt_from_ssh_penalties = 81 (new) function_lines: napalm_device_types/ssh_server.py::OpenSshServerMixin.harden_ssh_server = 70 (recorded 52) ``` The limit is 50 lines per function. Two functions are new and one grew. CI on the push of 1c71fe6 shows `driver / standard (push)` failing. The same failure now stops #64 (NetOrk/netork#1811), whose own functions pass. Fix: split the three functions, or record a justified exception in the ratchet baseline.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-device-types#65