No manage_service: services cannot be started, stopped, enabled or disabled #7

New Issue

2026-10-04T22:39:09Z

christianmanivong commented

2026-10-04 22:39:09 +00:00

What happens

LinuxDriver implements get_services() (systemd, with a SysV fallback) but has no manage_service(), the counterpart declared in napalm_device_types/services.py. On the deployed engine (172.22.8.50) both of these are False:

hasattr(LinuxDriver, "manage_service")
hasattr(OpenMediaVaultDriver, "manage_service") (it inherits from Linux)

netOrk offers Start/Stop/Restart/Enable/Disable for every service it lists. On 23 Linux hosts and one OMV host each of those calls ends in an AttributeError, so the buttons do nothing (the netOrk side is tracked in NetOrk/netork).

Proposal

Mirror napalm-proxmox's manage_service():

sudo systemctl {start|stop|restart|enable|disable} {name}.service
Validate the name against [A-Za-z0-9_.@-]+. That admits template units (wg-quick@wg0, openvpn@server) and dotted ones (snapd.apparmor), and nothing a shell reads.
On a SysV host (no systemctl), fall back to service {name} {start|stop|restart}. Report enable/disable as unsupported there.
Return {"success": bool, "output": str}. Unlike napalm-proxmox, do not append || true: a failed systemctl should say so.

## What happens `LinuxDriver` implements `get_services()` (systemd, with a SysV fallback) but has no `manage_service()`, the counterpart declared in `napalm_device_types/services.py`. On the deployed engine (172.22.8.50) both of these are `False`: - `hasattr(LinuxDriver, "manage_service")` - `hasattr(OpenMediaVaultDriver, "manage_service")` (it inherits from Linux) netOrk offers Start/Stop/Restart/Enable/Disable for every service it lists. On 23 Linux hosts and one OMV host each of those calls ends in an `AttributeError`, so the buttons do nothing (the netOrk side is tracked in NetOrk/netork). ## Proposal Mirror `napalm-proxmox`'s `manage_service()`: - `sudo systemctl {start|stop|restart|enable|disable} {name}.service` - Validate the name against `[A-Za-z0-9_.@-]+`. That admits template units (`wg-quick@wg0`, `openvpn@server`) and dotted ones (`snapd.apparmor`), and nothing a shell reads. - On a SysV host (no `systemctl`), fall back to `service {name} {start|stop|restart}`. Report enable/disable as unsupported there. - Return `{"success": bool, "output": str}`. Unlike napalm-proxmox, do not append `|| true`: a failed `systemctl` should say so.

christianmanivong referenced this issue from a commit

2026-10-05 04:19:52 +00:00

feat(services): system services join the Managed Services list (#49)

christianmanivong referenced a pull request that will close this issue

2026-10-05 11:12:13 +00:00

feat: start, stop, restart, enable and disable services, and list them in one round trip #9

christianmanivong closed this issue

2026-10-05 11:12:14 +00:00

christianmanivong referenced this issue from a commit

2026-10-05 11:12:14 +00:00

feat: start, stop, restart, enable and disable services, and list them in one round trip

christianmanivong referenced this issue from NAPALM/napalm-qnap-qts