NAPALM/napalm-zyxel
1
0 Fork 0
Code Issues 4 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix!: reboot_host instead of reboot; drop run_device_action (0.2.0) #7

Merged
christianmanivong merged 1 commits from fix/reboot-host into master 2026-10-17 06:59:43 +00:00
Conversation 0 Commits 1 Files Changed 3
+28 -48
christianmanivong commented 2026-10-17 06:40:28 +00:00
Owner
Copy link
Copy source
  • reboot_host() per HostRebootMixin (raises when refused): the application looks for it, so the gateway was not restartable (#5).
  • run_device_action gone; restart_wifi(band) and get_diagnostics() are methods.

Part of NetOrk/netork#1105. Closes #5, part of #6.

- `reboot_host()` per `HostRebootMixin` (raises when refused): the application looks for it, so the gateway was not restartable (#5). - `run_device_action` gone; `restart_wifi(band)` and `get_diagnostics()` are methods. Part of NetOrk/netork#1105. Closes #5, part of #6.
christianmanivong added 1 commit 2026-10-17 06:40:28 +00:00
fix!: reboot_host instead of reboot; drop run_device_action (0.2.0)
CI / test (3.10) (push) Successful in 3m5s
Details
CI / test (3.11) (push) Successful in 23s
Details
CI / test (3.12) (push) Successful in 24s
Details
CI / test (3.10) (pull_request) Successful in 3m3s
Details
CI / test (3.11) (pull_request) Successful in 23s
Details
CI / test (3.12) (pull_request) Successful in 24s
Details
210f00f5e7 
The gateway had reboot(), but the contract (HostRebootMixin) and the
application look for reboot_host(), so the gateway could not be
restarted from it. reboot_host() returns None and raises when the
gateway refuses, as the contract says.

run_device_action dispatched reboot, restart_wifi[:band] and
get_diagnostics by string, with a result shape other than its
contract's. restart_wifi(band) and get_diagnostics() are methods now;
napalm-device-types deprecates run_device_action.

BREAKING CHANGE: reboot() and run_device_action are removed.

Closes #5. Part of #6.
christianmanivong merged commit f94c0a3171 into master 2026-10-17 06:59:43 +00:00
christianmanivong deleted branch fix/reboot-host 2026-10-17 06:59:43 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is broken
 enhancement
New feature or request
 tech-debt
Refactoring / cleanup / deferred debt
prio
P0
Road blocker: blocks other work, drop everything
prio
P1
Critical
prio
P2
Important and urgent
prio
P3
Important, not urgent
prio
P4
Neither important nor urgent
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
christianmanivong
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-zyxel#7