fix(config): leave get_config to NAPALM's stub #22

Merged
christianmanivong merged 1 commits from fix/get-config-unsupported into main 2026-11-12 14:31:07 +00:00
Owner

A VMG has no configuration export, but the driver overrode get_config with a stub returning {}. netOrk then could not tell "not supported" from "read an empty configuration" and raised config_backup_failed ("The device returned an empty configuration.") on every poll.

The override is gone: NAPALM's stub raises NotImplementedError, and netOrk's implements_napalm_getter reports the getter as not implemented, so the backup is "not covered" instead of failing.

A VMG has no configuration export, but the driver overrode `get_config` with a stub returning `{}`. netOrk then could not tell "not supported" from "read an empty configuration" and raised `config_backup_failed` ("The device returned an empty configuration.") on every poll. The override is gone: NAPALM's stub raises `NotImplementedError`, and netOrk's `implements_napalm_getter` reports the getter as not implemented, so the backup is "not covered" instead of failing.
christianmanivong added 1 commit 2026-11-12 14:28:35 +00:00
fix(config): leave get_config to NAPALM's stub
driver / standard (pull_request) Successful in 17s
driver / lint (pull_request) Successful in 17s
driver / types (pull_request) Successful in 57s
driver / test (3.13) (pull_request) Successful in 54s
driver / test (3.12) (pull_request) Successful in 1m0s
driver / lowest (pull_request) Successful in 25s
driver / build (pull_request) Successful in 26s
driver / security (pull_request) Successful in 1m10s
CI / driver (pull_request) Successful in 2m24s
driver / publish (pull_request) Skipped
fe7c3fc7f9
A VMG has no configuration export. The override returned {}, so a caller
could not tell "not supported" from "read an empty configuration": netOrk
took it for a backup that came back empty and raised config_backup_failed
on every poll. Without the override NAPALM's stub raises
NotImplementedError and the getter reads as not implemented.
christianmanivong merged commit 63f92561eb into main 2026-11-12 14:31:07 +00:00
christianmanivong deleted branch fix/get-config-unsupported 2026-11-12 14:31:07 +00:00
Sign in to join this conversation.