get_facts read HostName from getBasicInformation, which a VMG4005-B50A (V5.17(ABQA.3.1)C0) does not send, and fell back to the address the driver connects to. netOrk ignores an IP as a host name, so the gateway stayed named 192.168.1.1.
The gateway's own Maintenance > System page reads host name and domain with GET /cgi-bin/System?oid=snmp (the oid name is Zyxel's; this firmware has no SNMP agent), sealed like a DAL answer. get_facts now reads them there:
hostname: HostName from that page
fqdn: HostName.DomainName, or the host name alone without a domain
no name set: "", not the address
the page cannot be read: get_facts raises, like the interfaces since #15
Checked read-only against the gateway with this branch: hostname: VMG4005-B50A, fqdn: VMG4005-B50A.home.
Tests: tests/test_facts.py with that gateway's real answers; 88 passed, ruff, mypy and the standard's ratchet clean, coverage 76 %.
`get_facts` read `HostName` from `getBasicInformation`, which a VMG4005-B50A (V5.17(ABQA.3.1)C0) does not send, and fell back to the address the driver connects to. netOrk ignores an IP as a host name, so the gateway stayed named `192.168.1.1`.
The gateway's own Maintenance > System page reads host name and domain with `GET /cgi-bin/System?oid=snmp` (the oid name is Zyxel's; this firmware has no SNMP agent), sealed like a DAL answer. `get_facts` now reads them there:
- `hostname`: `HostName` from that page
- `fqdn`: `HostName.DomainName`, or the host name alone without a domain
- no name set: `""`, not the address
- the page cannot be read: `get_facts` raises, like the interfaces since #15
Checked read-only against the gateway with this branch: `hostname: VMG4005-B50A`, `fqdn: VMG4005-B50A.home`.
Tests: `tests/test_facts.py` with that gateway's real answers; 88 passed, ruff, mypy and the standard's ratchet clean, coverage 76 %.
get_facts read HostName from getBasicInformation, which a VMG4005-B50A
does not send, and fell back to the address the driver connects to:
netOrk kept the gateway named 192.168.1.1. The gateway's own System page
reads host name and domain with GET /cgi-bin/System?oid=snmp, sealed like
a DAL answer; get_facts now reads them there. fqdn is the host name with
its domain. A gateway with no name set reports "", and get_facts raises
when the System page cannot be read.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
get_factsreadHostNamefromgetBasicInformation, which a VMG4005-B50A (V5.17(ABQA.3.1)C0) does not send, and fell back to the address the driver connects to. netOrk ignores an IP as a host name, so the gateway stayed named192.168.1.1.The gateway's own Maintenance > System page reads host name and domain with
GET /cgi-bin/System?oid=snmp(the oid name is Zyxel's; this firmware has no SNMP agent), sealed like a DAL answer.get_factsnow reads them there:hostname:HostNamefrom that pagefqdn:HostName.DomainName, or the host name alone without a domain"", not the addressget_factsraises, like the interfaces since #15Checked read-only against the gateway with this branch:
hostname: VMG4005-B50A,fqdn: VMG4005-B50A.home.Tests:
tests/test_facts.pywith that gateway's real answers; 88 passed, ruff, mypy and the standard's ratchet clean, coverage 76 %.