Commit Graph
27 Commits
Author SHA1 Message Date
christianmanivong 5f0c7c76b3 Merge pull request 'fix(tests): stub is_alive so no test opens a socket' (#18) from fix/bugs-2026-11-02c into main
driver / standard (push) Successful in 18s
driver / lint (push) Failing after 7s
driver / types (push) Successful in 1m30s
driver / test (3.13) (push) Successful in 1m16s
driver / test (3.12) (push) Successful in 1m31s
driver / lowest (push) Successful in 34s
driver / build (push) Successful in 44s
driver / security (push) Successful in 1m23s
CI / driver (push) Failing after 3m15s
driver / publish (push) Skipped
2026-11-02 09:57:10 +00:00
Christian Manivong 745946387f fix(tests): stub is_alive so no test opens a socket
driver / standard (pull_request) Successful in 18s
driver / lint (pull_request) Successful in 15s
driver / types (pull_request) Successful in 1m9s
driver / test (3.12) (pull_request) Successful in 1m9s
driver / test (3.13) (pull_request) Successful in 1m0s
driver / lowest (pull_request) Successful in 34s
driver / build (pull_request) Successful in 33s
driver / security (pull_request) Successful in 1m14s
CI / driver (pull_request) Successful in 2m56s
driver / publish (pull_request) Skipped
NAPALM's __del__ calls is_alive(), and this driver's is_alive() opens a
TCP connection to the gateway whether or not the driver was opened or
closed, so every driver a test built connected to 192.168.1.1:80 when
it was collected. The tests now build their drivers with an is_alive()
that opens nothing (the is_alive tests call the class's method), and a
session-wide guard in conftest refuses every connection and fails the
run if anything tried one.

Closes #17
2026-11-02 10:41:58 +01:00
christianmanivong 98f9df188e Merge pull request 'fix(dal): raise on a failed request instead of reading it as empty' (#16) from fix/bugs-2026-11-02b into main
driver / standard (push) Successful in 16s
driver / lint (push) Failing after 5s
driver / types (push) Successful in 1m12s
driver / test (3.12) (push) Successful in 4m16s
driver / test (3.13) (push) Successful in 4m3s
driver / lowest (push) Successful in 3m33s
driver / build (push) Successful in 30s
driver / security (push) Successful in 1m18s
CI / driver (push) Failing after 5m54s
driver / publish (push) Skipped
2026-11-02 09:40:44 +00:00
Christian Manivong ded19238c0 fix(dal): raise on a failed request instead of reading it as empty
driver / standard (pull_request) Successful in 17s
driver / lint (pull_request) Successful in 15s
driver / types (pull_request) Successful in 1m10s
driver / test (3.12) (pull_request) Successful in 4m10s
driver / test (3.13) (pull_request) Successful in 4m6s
driver / lowest (pull_request) Successful in 3m43s
driver / build (pull_request) Successful in 31s
driver / security (pull_request) Successful in 1m17s
CI / driver (pull_request) Successful in 5m59s
driver / publish (pull_request) Skipped
_dal_query and _fetch_page returned None for any failure, and the
getters turned that into empty data, so a timeout or an expired session
read as a gateway with no hosts, port forwards, SSIDs or Wi-Fi clients.
Both now raise: ConnectionException when the gateway does not answer or
refuses the session, RuntimeError naming the request otherwise. A getter
whose DAL request fails still reads the HTML page and raises when that
fails too; get_facts no longer swallows a failed get_interfaces.

Closes #15
2026-11-02 09:18:50 +01:00
christianmanivong da9e303e45 Merge pull request 'fix(fingerprint): tell a DAL gateway from other Zyxel devices' (#14) from fix/bugs-2026-11-02 into main
driver / standard (push) Successful in 18s
driver / lint (push) Successful in 20s
driver / types (push) Successful in 1m7s
driver / test (3.12) (push) Successful in 4m11s
driver / test (3.13) (push) Successful in 4m1s
driver / lowest (push) Successful in 3m34s
driver / build (push) Successful in 45s
driver / security (push) Successful in 1m18s
CI / driver (push) Successful in 6m7s
driver / publish (push) Skipped
2026-11-02 08:12:33 +00:00
Christian Manivong 6f9b91ae9b fix(fingerprint): tell a DAL gateway from other Zyxel devices
driver / standard (pull_request) Successful in 17s
driver / lint (pull_request) Successful in 15s
driver / types (pull_request) Successful in 1m18s
driver / test (3.13) (pull_request) Successful in 4m9s
driver / test (3.12) (pull_request) Successful in 4m28s
driver / lowest (pull_request) Successful in 3m41s
driver / build (pull_request) Successful in 34s
driver / security (pull_request) Successful in 1m18s
CI / driver (pull_request) Successful in 6m0s
driver / publish (pull_request) Skipped
The driver's evidence was all vendor-wide: Zyxel's enterprise OID, Zyxel
OUIs and "zyxel" on the web page. Every managed Zyxel device has all
three, and they were the driver's whole maximum, so discovery named any
Zyxel switch this gateway with high confidence.

Discovery now also fetches /getRSAPublickKey on ports 80 and 443, the
DAL key exchange the driver logs in with, without counting the port.
Its "RSAPublicKey" answer weighs 24: vendor-wide evidence alone is 28 of
52 (medium), a gateway 52 of 52, or 37 of 52 without SNMP.

Closes #13
2026-11-02 08:47:46 +01:00
christianmanivong f6b3887121 Merge pull request 'fix: switch fingerprints, request timeouts, ping (#4, #3, #2)' (#12) from fix/bugs-2026-11 into main
driver / standard (push) Successful in 16s
driver / lint (push) Successful in 15s
driver / types (push) Successful in 1m3s
driver / test (3.13) (push) Successful in 3m59s
driver / test (3.12) (push) Successful in 4m9s
driver / lowest (push) Successful in 3m36s
driver / build (push) Successful in 31s
driver / security (push) Successful in 1m6s
CI / driver (push) Successful in 5m37s
driver / publish (push) Skipped
2026-11-01 22:00:49 +00:00
Christian Manivong fcee6d7ddd fix(ping): stop reporting every target alive
driver / standard (pull_request) Successful in 17s
driver / lint (pull_request) Successful in 16s
driver / types (pull_request) Successful in 1m13s
driver / test (3.12) (pull_request) Successful in 4m9s
driver / test (3.13) (pull_request) Successful in 4m1s
driver / lowest (pull_request) Successful in 3m33s
driver / build (pull_request) Successful in 30s
driver / security (pull_request) Successful in 1m6s
CI / driver (pull_request) Successful in 5m49s
driver / publish (pull_request) Skipped
ping() returned three replies of 0 ms whenever the DAL accepted a
PINGTEST request, without reading any result, so a LAN scan through
this gateway marked every address alive. The DAL answer is only an
acknowledgement with no reply count, so ping() now returns NAPALM's
error reply without contacting the gateway and the driver opts out of
ping sweeps with SUPPORTS_PING = False.

Closes #2
2026-11-01 21:56:45 +01:00
Christian Manivong f7002114ae fix(http): pass the timeout with every request
requests ignores a timeout attribute on a Session, so open() setting
one left every call without a timeout and an unresponsive gateway
could hang a worker indefinitely. Each get/post/put now carries the
driver's timeout.

Closes #3
2026-11-01 21:55:36 +01:00
Christian Manivong d5362fd382 fix(fingerprint): drop the GS1920 and GS2210 switch patterns
GS1920 and GS2210 are Zyxel switches. Counting them as evidence for a
VMG gateway driver made discovery score a Zyxel switch higher for this
driver than a real VMG gateway.

Closes #4
2026-11-01 21:54:55 +01:00
christianmanivong 7fbb7034d3 Merge pull request 'fix: an unknown ARP age is -1.0, not 0.0' (#11) from fix/arp-unknown-age into main
driver / standard (push) Successful in 16s
driver / lint (push) Failing after 5s
driver / types (push) Successful in 1m6s
driver / test (3.12) (push) Successful in 3m51s
driver / test (3.13) (push) Successful in 3m55s
driver / lowest (push) Successful in 3m21s
driver / build (push) Successful in 33s
driver / security (push) Successful in 1m3s
CI / driver (push) Failing after 5m14s
driver / publish (push) Skipped
2026-10-30 09:11:38 +00:00
Christian Manivong 48fdda1904 fix: an unknown ARP age is -1.0, not 0.0
driver / standard (pull_request) Successful in 18s
driver / lint (pull_request) Successful in 23s
driver / types (pull_request) Successful in 1m24s
driver / test (3.12) (pull_request) Successful in 3m53s
driver / test (3.13) (pull_request) Successful in 3m37s
driver / lowest (pull_request) Successful in 3m14s
driver / build (pull_request) Successful in 31s
driver / security (pull_request) Successful in 1m11s
CI / driver (pull_request) Successful in 5m45s
driver / publish (pull_request) Skipped
The host list says a host is active, not when the gateway last saw it, so
get_arp_table reports ARP_AGE_UNKNOWN instead of 0.0 ("confirmed just now").

NetOrk/netork#1327
2026-10-30 08:37:08 +01:00
christianmanivong d0f2576510 Merge pull request 'chore: Python 3.12 is the floor (NAPALM/driver-standard#6)' (#10) from chore/python-312-floor into main
driver / standard (push) Successful in 14s
driver / lint (push) Successful in 13s
driver / types (push) Successful in 54s
driver / test (3.12) (push) Successful in 3m32s
driver / test (3.13) (push) Successful in 3m27s
driver / lowest (push) Successful in 3m3s
driver / build (push) Successful in 26s
driver / security (push) Successful in 56s
CI / driver (push) Successful in 4m51s
driver / publish (push) Skipped
2026-10-27 10:53:08 +00:00
Christian Manivong 0ebd69b739 fix: the floor on napalm is 5.1 (NAPALM/driver-standard#6)
driver / standard (pull_request) Successful in 18s
driver / lint (pull_request) Successful in 16s
driver / types (pull_request) Successful in 1m6s
driver / test (3.12) (pull_request) Successful in 3m48s
driver / test (3.13) (pull_request) Successful in 3m38s
driver / lowest (pull_request) Successful in 3m6s
driver / build (pull_request) Successful in 31s
driver / security (pull_request) Successful in 1m0s
CI / driver (pull_request) Successful in 5m22s
driver / publish (pull_request) Skipped
napalm 5.0 and older import pkg_resources, which a Python 3.12 venv no
longer has, so the lowest job failed on them.
2026-10-27 10:49:33 +01:00
Christian Manivong cd2670bf5f chore: Python 3.12 is the floor (NAPALM/driver-standard#6)
driver / standard (pull_request) Successful in 16s
driver / lint (pull_request) Successful in 13s
driver / types (pull_request) Successful in 1m1s
driver / lowest (pull_request) Failing after 22s
driver / security (pull_request) Successful in 56s
driver / build (pull_request) Successful in 26s
driver / test (3.12) (pull_request) Successful in 3m42s
driver / test (3.13) (pull_request) Successful in 3m30s
CI / driver (pull_request) Failing after 4m12s
driver / publish (pull_request) Skipped
netOrk runs every driver in its own containers on Python 3.12, so 3.10
and 3.11 are no longer supported or tested. requires-python, mypy and
ruff move to 3.12, along with what ruff's pyupgrade rules then rewrite.
2026-10-27 10:19:02 +01:00
christianmanivong b4bd6ae4be Merge pull request 'chore: adopt the NAPALM driver standard' (#9) from chore/driver-standard into main
driver / standard (push) Successful in 16s
driver / lint (push) Successful in 12s
driver / types (push) Successful in 48s
driver / test (3.10) (push) Successful in 3m30s
driver / test (3.11) (push) Successful in 3m27s
driver / test (3.12) (push) Successful in 3m25s
driver / security (push) Successful in 52s
driver / build (push) Successful in 25s
driver / lowest (push) Successful in 3m5s
driver / test (3.13) (push) Successful in 3m25s
driver / publish (push) Successful in 26s
CI / driver (push) Successful in 39m6s
v0.3.0
2026-10-23 10:22:33 +00:00
Christian Manivong d8c3a149cc chore(release): 0.3.0
driver / standard (pull_request) Successful in 14s
driver / lint (pull_request) Successful in 11s
driver / types (pull_request) Successful in 43s
driver / test (3.10) (pull_request) Successful in 3m24s
driver / test (3.11) (pull_request) Successful in 3m25s
driver / test (3.12) (pull_request) Successful in 3m34s
driver / test (3.13) (pull_request) Successful in 3m22s
driver / lowest (pull_request) Successful in 3m2s
driver / security (pull_request) Successful in 47s
driver / build (pull_request) Successful in 22s
CI / driver (pull_request) Successful in 19m4s
driver / publish (pull_request) Skipped
2026-10-23 10:29:07 +02:00
Christian Manivong 51b8cda3e4 chore: adopt the NAPALM driver standard
driver / standard (pull_request) Successful in 13s
driver / lint (pull_request) Successful in 11s
driver / types (pull_request) Successful in 42s
driver / test (3.10) (pull_request) Successful in 3m25s
driver / test (3.11) (pull_request) Successful in 3m23s
driver / test (3.12) (pull_request) Successful in 3m25s
driver / test (3.13) (pull_request) Successful in 3m19s
driver / lowest (pull_request) Successful in 3m7s
driver / security (pull_request) Successful in 53s
driver / build (pull_request) Successful in 34s
CI / driver (pull_request) Successful in 19m12s
driver / publish (pull_request) Skipped
- CI moves to .gitea/workflows/ci.yml and calls the shared driver workflow
  of NAPALM/driver-standard; .github/ is gone.
- requires-python >=3.10 (napalm-device-types needs it), floor
  napalm-device-types>=4.21.1 (was napalm_device_types>=0.4.0), LICENSE
  file, py.typed, SPDX license string, links to git.netork.io, a dev extra
  with floors.
- README (pyproject named one that did not exist) and CHANGELOG.md.
- mypy strict for the package; napalm_zyxel.zyxel_driver is exempt for now
  (24 errors), recorded in the quality baseline with its two complex
  functions. Coverage floor 68 % (measured 68.97 %).

Closes #8
2026-10-23 08:40:47 +02:00
Christian Manivong b306b64673 fix: what bandit and the remaining lint rules found
- nosec for SHA512_password in the login payload (B105): it is a flag
  telling the gateway how Input_Passwd is encoded, not a password; a false
  positive.
- A failed login raises ConnectionException from the underlying error, so
  the cause stays attached.
- tests: pytest.raises instead of try / assert False / except, which
  python -O would have turned into tests that always pass.
2026-10-23 08:39:32 +02:00
Christian Manivong f9fc4e3d06 style: ruff format and the lint rules of the driver standard
Mechanical: ruff format, and ruff check --fix with the rule set every NAPALM
driver uses (E, F, I, UP, B at line length 100, Python 3.10). What ruff
cannot fix comes in the next commit.
2026-10-23 08:38:39 +02:00
christianmanivong f94c0a3171 Merge pull request 'fix!: reboot_host instead of reboot; drop run_device_action (0.2.0)' (#7) from fix/reboot-host into master
CI / test (3.10) (push) Successful in 3m5s
CI / test (3.11) (push) Successful in 26s
CI / test (3.12) (push) Successful in 28s
2026-10-17 06:59:42 +00:00
Christian Manivong 210f00f5e7 fix!: reboot_host instead of reboot; drop run_device_action (0.2.0)
CI / test (3.10) (push) Successful in 3m5s
CI / test (3.11) (push) Successful in 23s
CI / test (3.12) (push) Successful in 24s
CI / test (3.10) (pull_request) Successful in 3m3s
CI / test (3.11) (pull_request) Successful in 23s
CI / test (3.12) (pull_request) Successful in 24s
The gateway had reboot(), but the contract (HostRebootMixin) and the
application look for reboot_host(), so the gateway could not be
restarted from it. reboot_host() returns None and raises when the
gateway refuses, as the contract says.

run_device_action dispatched reboot, restart_wifi[:band] and
get_diagnostics by string, with a result shape other than its
contract's. restart_wifi(band) and get_diagnostics() are methods now;
napalm-device-types deprecates run_device_action.

BREAKING CHANGE: reboot() and run_device_action are removed.

Closes #5. Part of #6.
2026-10-17 08:40:28 +02:00
christianmanivong efdf62c8be Merge pull request 'ci: run the tests and build the package on every push and pull request' (#1) from ci/workflow into master
CI / test (3.10) (push) Successful in 3m0s
CI / test (3.11) (push) Successful in 23s
CI / test (3.12) (push) Successful in 25s
2026-10-07 06:48:22 +00:00
Christian Manivong 6dc60916ee ci: run the tests and build the package on every push and pull request
CI / test (3.10) (push) Successful in 3m13s
CI / test (3.11) (push) Successful in 38s
CI / test (3.12) (push) Successful in 35s
CI / test (3.10) (pull_request) Successful in 3m0s
CI / test (3.11) (pull_request) Successful in 23s
CI / test (3.12) (pull_request) Successful in 25s
The same job as napalm-fritzbox and napalm-opnsense: Python 3.10, 3.11 and
3.12, pytest, then wheel and sdist. napalm-device-types comes from
git.netork.io first, because PyPI has an unrelated package of that name.
2026-10-07 07:52:44 +02:00
Christian ManivongandClaude Sonnet 4.6 247329fada feat: OUI_PREFIXES für MAC/ARP-Fingerprinting
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-24 15:41:45 +02:00
Christian ManivongandClaude Sonnet 4.6 23e68ecd87 feat: Fingerprint-Attribute für Discovery-Scoring
Ergänzt DRIVER_NAME, HTTP_FINGERPRINT, SNMP_FINGERPRINT, SSH_FINGERPRINT,
PORT_SPECS und SNMP_OBJECT_ID_PREFIX gemäß docs/DISCOVERY_FINGERPRINTING.md.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-24 14:47:08 +02:00
Christian Manivong 13e1aba5aa init 2026-06-13 03:18:28 +02:00