fix: drop stubs that claim what a phone cannot do (0.1.1)
CI / test (3.10) (push) Successful in 29s
CI / test (3.11) (push) Successful in 26s
CI / test (3.12) (push) Successful in 28s
CI / test (3.10) (pull_request) Successful in 30s
CI / test (3.11) (pull_request) Successful in 28s
CI / test (3.12) (pull_request) Successful in 29s

get_health_metrics, get_ssids, get_radio_info and get_wireless_clients
only raised NotImplementedError. They are left over from when the
driver sat on AccessPointDriver, and a stub makes a capability check
(callable(getattr(driver, name))) answer yes. The application polls
SNMP itself (napalm-device-types docs/STRUCTURE.md); a phone has no
profile to declare.

Also stops tracking the .pyc and egg-info files .gitignore already
lists.

Closes #2
This commit is contained in:
Christian Manivong committed 2026-10-16 12:03:38 +02:00
1 parent e80e3051fb
commit 46ff971953
12 files changed
+15 -42

No files matched your search

Binary file not shown.
Binary file not shown.
-16
View File
@@ -22,7 +22,6 @@ from requests.exceptions import RequestException
from napalm.base.exceptions import ConnectionClosedException, ConnectionException
from napalm_device_types import FingerprintRule, PhoneDriver
from napalm_device_types.models import HealthMetricsDict
class YealinkDriver(PhoneDriver):
@@ -210,18 +209,3 @@ class YealinkDriver(PhoneDriver):
def rollback(self) -> None:
raise NotImplementedError
# AccessPointDriver stubs
def get_wireless_clients(self) -> list:
raise NotImplementedError
def get_ssids(self) -> dict:
raise NotImplementedError
def get_radio_info(self) -> dict:
raise NotImplementedError
@classmethod
async def get_health_metrics(cls, snmp_get, snmp_walk) -> HealthMetricsDict:
raise NotImplementedError