chore: adopt the NAPALM driver standard #5

Merged

christianmanivong merged 4 commits from chore/driver-standard into main 2026-10-23 11:16:24 +00:00

Conversation 0 Commits 4 Files Changed 9

+301 -73

christianmanivong commented 2026-10-23 06:49:39 +00:00

Owner

Copy link

Copy source

Summary

napalm-windows adopts the NAPALM driver standard (https://git.netork.io/NAPALM/driver-standard).
Epic: NAPALM/driver-standard#2.

Changes

• style: the standard's ruff rule set (E, F, I, UP, B, line length 100, Python 3.10, E501 off under tests/); the code was already formatted and clean under it.
• fix: get_route_to: "0.0.0.0"/"::" are the unspecified next hop of an on-link route as the host reports it, nothing binds to them (nosec B104).
• chore: CI moves from .github/ to .gitea/workflows/ci.yml calling the shared workflow; requires-python >=3.10, LICENSE file, py.typed, setuptools>=77 with the SPDX license string, Issues/Changelog links, napalm-device-types>=4.21.1 from PyPI, floors on the dev extra. Strict mypy for the whole package with no module exempt (optional_args: dict[str, Any] | None was the one error). Coverage floor 95 %; tests/quality_baseline.json (get_facts, get_route_to over complexity 10). CHANGELOG in Keep a Changelog form; README says no host output is recorded yet and links napalm-device-types in the NAPALM org, pypsrp on PyPI.

Related Issue

Closes #4

Testing

Locally: 82 tests, coverage 95.67 %, ruff, mypy, bandit clean; napalm-standard check and ratchet clean; build + twine check --strict pass. The tests also pass at the lowest declared versions on Python 3.10 (synthetic fixtures only).

## Summary napalm-windows adopts the NAPALM driver standard (https://git.netork.io/NAPALM/driver-standard). Epic: NAPALM/driver-standard#2. ## Changes - **style**: the standard's ruff rule set (E, F, I, UP, B, line length 100, Python 3.10, E501 off under `tests/`); the code was already formatted and clean under it. - **fix**: `get_route_to`: `"0.0.0.0"`/`"::"` are the unspecified next hop of an on-link route as the host reports it, nothing binds to them (nosec B104). - **chore**: CI moves from `.github/` to `.gitea/workflows/ci.yml` calling the shared workflow; `requires-python >=3.10`, LICENSE file, `py.typed`, setuptools>=77 with the SPDX license string, Issues/Changelog links, `napalm-device-types>=4.21.1` from PyPI, floors on the dev extra. Strict mypy for the whole package with no module exempt (`optional_args: dict[str, Any] | None` was the one error). Coverage floor 95 %; `tests/quality_baseline.json` (`get_facts`, `get_route_to` over complexity 10). CHANGELOG in Keep a Changelog form; README says no host output is recorded yet and links napalm-device-types in the NAPALM org, pypsrp on PyPI. ## Related Issue Closes #4 ## Testing Locally: 82 tests, coverage 95.67 %, ruff, mypy, bandit clean; `napalm-standard check` and `ratchet` clean; build + `twine check --strict` pass. The tests also pass at the lowest declared versions on Python 3.10 (synthetic fixtures only).

christianmanivong added 3 commits 2026-10-23 06:49:39 +00:00

style: ruff format and the lint rules of the driver standard ... 3b87a9ad77

Mechanical: the rule set every NAPALM driver uses (E, F, I, UP, B at line
length 100, Python 3.10), with E501 off under tests/. The code was already
formatted and clean under it; what ruff cannot fix comes in the next commit.

fix: what bandit and the remaining lint rules found ... 989e826b34

- get_route_to: "0.0.0.0" and "::" are the unspecified next hop of an
  on-link route as the host reports it, not an address anything binds to
  (nosec B104).

chore: adopt the NAPALM driver standard ... d43d697700

- CI moves to .gitea/workflows/ci.yml and calls the shared driver workflow
  of NAPALM/driver-standard; .github/ is gone.
- requires-python >=3.10 (napalm-device-types needs it), LICENSE file,
  py.typed, setuptools>=77 with the SPDX license string, Issues and
  Changelog links on git.netork.io, napalm-device-types>=4.21.1 from PyPI,
  floors on the dev extra.
- mypy strict for the whole package, no module exempt: optional_args is
  dict[str, Any] | None.
- tests/quality_baseline.json records get_facts and get_route_to, over
  complexity 10. Coverage floor 95 % (measured 95.67 %).
- CHANGELOG.md in Keep a Changelog form; the README says no host output is
  recorded yet, links napalm-device-types in the NAPALM org and pypsrp on
  PyPI.

christianmanivong added 1 commit 2026-10-23 09:37:04 +00:00

chore(release): 0.2.0 40346456d0

christianmanivong merged commit 211ed27c9e into main 2026-10-23 11:16:24 +00:00

christianmanivong deleted branch chore/driver-standard 2026-10-23 11:16:24 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something is broken

enhancement

New feature or request

tech-debt

Refactoring / cleanup / deferred debt

prio

P0

Road blocker: blocks other work, drop everything

prio

P1

Critical

prio

P2

Important and urgent

prio

P3

Important, not urgent

prio

P4

Neither important nor urgent

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

christianmanivong

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: NAPALM/napalm-windows#5