NAPALM/napalm-sonos
1
0 Fork 0
Code Issues 1 Pull Requests Actions 1 Packages Projects Releases Wiki Activity

chore: adopt the NAPALM driver standard #6

Merged
christianmanivong merged 4 commits from chore/driver-standard into main 2026-10-23 14:42:36 +00:00
Conversation 0 Commits 4 Files Changed 11
+372 -71
4 Commits
Author SHA1 Message Date
Christian Manivong 89698c5bd6 chore(release): 0.3.0
driver / standard (pull_request) Successful in 14s
Details
driver / lint (pull_request) Successful in 12s
Details
driver / types (pull_request) Successful in 47s
Details
driver / test (3.10) (pull_request) Successful in 2m44s
Details
driver / test (3.11) (pull_request) Successful in 2m46s
Details
driver / test (3.12) (pull_request) Successful in 2m41s
Details
driver / security (pull_request) Successful in 47s
Details
driver / build (pull_request) Successful in 22s
Details
driver / test (3.13) (pull_request) Successful in 2m35s
Details
driver / lowest (pull_request) Successful in 2m18s
Details
CI / driver (pull_request) Successful in 5m55s
Details
driver / publish (pull_request) Skipped
Details
2026-10-23 16:01:56 +02:00
Christian Manivong 168841ebb8 chore: adopt the NAPALM driver standard
driver / standard (pull_request) Successful in 13s
Details
driver / lint (pull_request) Successful in 12s
Details
driver / types (pull_request) Successful in 45s
Details
driver / test (3.10) (pull_request) Successful in 2m40s
Details
driver / test (3.11) (pull_request) Successful in 2m40s
Details
driver / test (3.12) (pull_request) Successful in 2m37s
Details
driver / test (3.13) (pull_request) Successful in 2m34s
Details
driver / lowest (pull_request) Successful in 2m16s
Details
driver / security (pull_request) Successful in 47s
Details
driver / build (pull_request) Successful in 22s
Details
CI / driver (pull_request) Successful in 15m6s
Details
driver / publish (pull_request) Skipped
Details 
- CI moves to .gitea/workflows/ci.yml and calls the shared driver workflow
  of NAPALM/driver-standard; .github/ is gone.
- napalm-device-types >=4.21.1 is now declared: the driver imports
  MediaDriver, PortSpec and FingerprintRule from it, and CI used to
  install it by hand.
- requires-python >=3.10 (napalm-device-types needs it), LICENSE, README,
  CHANGELOG, py.typed, SPDX license string, setuptools>=77, version floors
  on the dev extra, links to git.netork.io; .gitignore as in the template.
- mypy strict for the package; napalm_sonos.sonos_driver is exempt for now
  (5 errors, two of them return types that differ from MediaDriver's),
  recorded in the quality baseline.
- Coverage floor 71 % (measured 71.30 %).
 2026-10-23 09:00:07 +02:00
Christian Manivong a6d1d1e597 fix: what bandit and the remaining lint rules found 
- open() raises ConnectionException from the SoCo error (B904), so the
  cause stays attached.
- _check_wired_connection: the except Exception: pass (B110) now logs at
  debug level, so a swallowed failure leaves a trace. A module logger is
  new.
- nosec for the empty password default (B107): a Sonos speaker takes no
  login, the argument exists for NAPALM's constructor signature.
- tests: raise AssertionError instead of assert False (B011).
 2026-10-23 08:57:52 +02:00
Christian Manivong ad69c0e643 style: ruff format and the lint rules of the driver standard 
Mechanical: ruff format, and ruff check --fix with the rule set every NAPALM
driver uses (E, F, I, UP, B at line length 100, Python 3.10). What ruff
cannot fix comes in the next commit.
 2026-10-23 08:55:35 +02:00