refactor!: drop run_device_action; the media controls are methods (0.2.0) #4

2026-10-17T06:39:32Z

christianmanivong commented

2026-10-17 06:39:32 +00:00

Part of NetOrk/netork#1105. run_device_action was a string dispatch over the media controls with a result shape other than its contract's; the typed methods (play(), set_volume(), …) stay as the interface. netOrk does not call it.

Closes #3.

Part of NetOrk/netork#1105. `run_device_action` was a string dispatch over the media controls with a result shape other than its contract's; the typed methods (`play()`, `set_volume()`, …) stay as the interface. netOrk does not call it. Closes #3.

christianmanivong added 1 commit 2026-10-17 06:39:32 +00:00

refactor!: drop run_device_action; the media controls are methods (0.2.0)

CI / test (3.10) (push) Successful in 2m20s

Details

CI / test (3.11) (push) Successful in 27s

Details

CI / test (3.12) (push) Successful in 30s

Details

CI / test (3.10) (pull_request) Successful in 2m19s

Details

CI / test (3.11) (pull_request) Successful in 27s

Details

CI / test (3.12) (pull_request) Successful in 29s

Details

06dbcf4b83

run_device_action dispatched play, pause, stop, next/previous track,
set_volume:N and toggle_mute by string and returned
{success, action, message} instead of the DeviceActionResultDict its
contract names. The typed methods it called (play(), set_volume(), ...)
are the interface; napalm-device-types deprecates run_device_action.

BREAKING CHANGE: run_device_action is removed.

Closes #3

christianmanivong merged commit 6ceac1d526 into master

2026-10-17 06:51:53 +00:00

christianmanivong deleted branch chore/drop-run-device-action

2026-10-17 06:51:53 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: NAPALM/napalm-sonos#4