fix(time-sync): switch off the POSIX time sync on QTS #20

Merged
christianmanivong merged 1 commits from feature/time-sync-2370 into main 2026-11-11 14:27:33 +00:00
Owner

What

get_time_sync = None and configure_time_sync = None, next to the other things QTS switches off. See NetOrk/netork#2370 (part of NetOrk/netork#2360).

napalm-linux now brings napalm-device-types' PosixTimeSyncMixin (4.35.0, NAPALM/napalm-linux#74) to every LinuxDriver. QTS has no systemd and no timedatectl, and its NTP client and zone are QTS settings. The inherited reading finds no client (daemon None, ntp_servers []), and every write fails its step. That would be a permanent difference netOrk reports but cannot fix. With these lines, a capability check (callable(getattr(driver, "get_time_sync", None))) answers no.

A read-only QTS variant was considered and left out. The zone is readable (getcfg System 'Time Zone', as scheduled jobs do), but the NTP keys in uLinux.conf have not been harvested from a box. A reading that reports the zone but no servers would show the same false difference. Follow-up: #21.

The floor rises to napalm-device-types>=4.35.0. napalm-linux stays at >=0.17.0: #74 is unreleased, its main still says 0.17.0, and CI installs it from git main. With napalm-linux 0.17.0 from PyPI the two lines do nothing.

Tests

test_time_sync_is_not_read_or_set_here failed first against napalm-linux main (both methods were callable on QnapQtsDriver). 117 tests pass (1 xfailed), and ruff, mypy, napalm-standard check and ratchet are clean.

## What `get_time_sync = None` and `configure_time_sync = None`, next to the other things QTS switches off. See NetOrk/netork#2370 (part of NetOrk/netork#2360). napalm-linux now brings napalm-device-types' `PosixTimeSyncMixin` (4.35.0, NAPALM/napalm-linux#74) to every `LinuxDriver`. QTS has no systemd and no `timedatectl`, and its NTP client and zone are QTS settings. The inherited reading finds no client (`daemon` None, `ntp_servers` []), and every write fails its step. That would be a permanent difference netOrk reports but cannot fix. With these lines, a capability check (`callable(getattr(driver, "get_time_sync", None))`) answers no. A read-only QTS variant was considered and left out. The zone is readable (`getcfg System 'Time Zone'`, as scheduled jobs do), but the NTP keys in `uLinux.conf` have not been harvested from a box. A reading that reports the zone but no servers would show the same false difference. Follow-up: #21. The floor rises to `napalm-device-types>=4.35.0`. `napalm-linux` stays at `>=0.17.0`: #74 is unreleased, its `main` still says 0.17.0, and CI installs it from git `main`. With napalm-linux 0.17.0 from PyPI the two lines do nothing. ## Tests `test_time_sync_is_not_read_or_set_here` failed first against napalm-linux `main` (both methods were callable on `QnapQtsDriver`). 117 tests pass (1 xfailed), and ruff, mypy, `napalm-standard check` and `ratchet` are clean.
christianmanivong added 1 commit 2026-11-11 14:19:28 +00:00
fix(time-sync): switch off the POSIX time sync on QTS
driver / standard (pull_request) Successful in 17s
driver / lint (pull_request) Successful in 16s
driver / types (pull_request) Successful in 1m9s
driver / test (3.12) (pull_request) Successful in 1m6s
driver / test (3.13) (pull_request) Successful in 1m1s
driver / lowest (pull_request) Successful in 34s
driver / build (pull_request) Successful in 28s
driver / security (pull_request) Successful in 1m12s
CI / driver (pull_request) Successful in 2m51s
driver / publish (pull_request) Skipped
f1d191c52a
napalm-linux now brings napalm-device-types' PosixTimeSyncMixin (4.35.0). QTS has no systemd and no timedatectl, and its NTP client and time zone are QTS settings: the inherited reading finds no client there and every write fails its step, a difference netOrk could report on every poll but never fix (NetOrk/netork#2370). get_time_sync and configure_time_sync are None, so a capability check answers no, until a QTS variant is built against a real box. The floor rises to napalm-device-types 4.35.0.
christianmanivong merged commit 37fb54939a into main 2026-11-11 14:27:33 +00:00
christianmanivong deleted branch feature/time-sync-2370 2026-11-11 14:27:33 +00:00
Sign in to join this conversation.