fix: do not claim service control QTS cannot do #1

Merged
christianmanivong merged 1 commits from fix/no-service-control into main 2026-10-05 11:12:17 +00:00
2 changed files with 16 additions and 0 deletions
Showing only changes of commit 77313ca436 - Show all commits
+6
View File
@@ -68,6 +68,12 @@ class QnapQtsDriver(StorageDriver, HypervisorDriver, LinuxDriver):
driver_name = "qnap_qts"
NETMIKO_DEVICE_TYPE = "linux"
#: QTS has no systemd, so the systemctl actions LinuxDriver inherits from
#: napalm-device-types' SystemdServicesMixin would fail on every unit. None
#: makes every "can it control services?" check -- is ``manage_service``
#: callable -- answer no, rather than offering buttons that cannot work.
manage_service = None # type: ignore[assignment]
SNMP_OBJECT_ID_PREFIX = QNAP_ENTERPRISE_OID
SNMP_FINGERPRINT = [
FingerprintRule("qnap", weight=9.0),
+10
View File
@@ -182,3 +182,13 @@ class TestDockerBinDiscovery:
def test_docker_bin_hook_returns_the_discovered_path(self, driver):
driver._docker_path = "/opt/docker"
assert driver._docker_bin() == "/opt/docker"
def test_services_cannot_be_controlled():
"""QTS has no systemd: the systemctl actions inherited from LinuxDriver would
fail on every unit, so the driver says it cannot control services at all --
which is what every capability check asks (is ``manage_service`` callable?)."""
from napalm_linux.linux import LinuxDriver
assert callable(getattr(LinuxDriver, "manage_service", None))
assert not callable(getattr(QnapQtsDriver, "manage_service", None))