Compare commits
17
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
f96afa42c7 | ||
|
|
0cf719e6de | ||
|
|
dd785da94f | ||
|
|
991cae7e8d | ||
|
|
3a991970b8 | ||
|
|
472518576e | ||
|
|
375530ac1c | ||
|
|
95ec6ad33b | ||
|
|
088d47f47c | ||
|
|
912469bdc0 | ||
|
|
39532471b7 | ||
|
|
5838685690 | ||
|
|
b868f53990 | ||
|
|
8ad1c66ace | ||
|
|
0f4b4f56c4 | ||
|
|
5e371db3af | ||
|
|
872e5718a3 |
No files matched your search
@@ -0,0 +1,17 @@
|
||||
name: CI
|
||||
|
||||
on:
|
||||
push:
|
||||
branches: [main, master]
|
||||
tags: ["v*"]
|
||||
pull_request:
|
||||
|
||||
jobs:
|
||||
driver:
|
||||
uses: NAPALM/driver-standard/.gitea/workflows/driver.yml@main
|
||||
with:
|
||||
standard-ref: main
|
||||
# Until napalm-linux 0.15.0 is on PyPI.
|
||||
pre-install: "git+https://git.netork.io/NAPALM/napalm-device-types.git git+https://git.netork.io/NAPALM/napalm-linux.git"
|
||||
secrets:
|
||||
PYPI_TOKEN: ${{ secrets.PYPI_TOKEN }}
|
||||
@@ -7,6 +7,53 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
|
||||
|
||||
## [Unreleased]
|
||||
|
||||
## [0.6.0] - 2026-10-23
|
||||
|
||||
The first release on PyPI.
|
||||
|
||||
### Changed
|
||||
- The driver follows the NAPALM driver standard
|
||||
(https://git.netork.io/NAPALM/driver-standard): CI on Gitea runs ruff, mypy, the
|
||||
tests on Python 3.10–3.13 and at the lowest declared versions, bandit, pip-audit and
|
||||
a build check, and a release tag publishes to PyPI. The package now ships `py.typed`
|
||||
and a LICENSE file. It needs napalm-device-types 4.22.0 and napalm-linux 0.15.0.
|
||||
**Python 3.9 is no longer supported**; napalm-device-types never ran on it.
|
||||
|
||||
## [0.4.0] – 2026-10-17
|
||||
|
||||
### Changed
|
||||
- Requires napalm-linux 0.8.0, whose fixes are napalm-device-types' templates.
|
||||
`configure_snmp_agent`, `configure_package_proxy` and `ensure_package` are switched
|
||||
off (`None`): QTS has no apt, dnf or opkg, and its SNMP agent is set in its own UI.
|
||||
Before, the inherited SNMP and apt-proxy fixes were offered and failed.
|
||||
|
||||
### Fixed
|
||||
- `get_device_warnings` no longer logs a TypeError on every poll: the inherited one
|
||||
asked for updates, which QTS cannot list (#6).
|
||||
|
||||
## [0.3.0] – 2026-10-08
|
||||
|
||||
### Removed
|
||||
- The `_docker_bin()` override: napalm-linux 0.3.0 drops the Docker CLI
|
||||
methods it served. `_container_engine_binary("docker")` returns Container
|
||||
Station's path itself.
|
||||
|
||||
### Changed
|
||||
- Requires napalm-linux >= 0.3.0.
|
||||
|
||||
## [0.2.0] – 2026-10-07
|
||||
|
||||
### Added
|
||||
- `_container_engine_binary` returns Container Station's docker path, so the
|
||||
container engine connection from napalm-device-types 2.6.0
|
||||
(`open_container_engine("docker")`) reaches it although it is not on PATH.
|
||||
Callers pass arguments only and never see the path (NetOrk/netork#765).
|
||||
|
||||
### Changed
|
||||
- Requires napalm-device-types >= 2.6.0 and napalm-linux >= 0.2.0.
|
||||
|
||||
## [0.1.0]
|
||||
|
||||
### Added
|
||||
- Initial driver scaffold: `QnapQtsDriver(StorageDriver, LinuxDriver)` with
|
||||
discovery fingerprints (SNMP enterprise OID 1.3.6.1.4.1.24681, HTTP, port
|
||||
|
||||
@@ -0,0 +1,191 @@
|
||||
Apache License
|
||||
Version 2.0, January 2004
|
||||
http://www.apache.org/licenses/
|
||||
|
||||
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
|
||||
|
||||
1. Definitions.
|
||||
|
||||
"License" shall mean the terms and conditions for use, reproduction,
|
||||
and distribution as defined by Sections 1 through 9 of this document.
|
||||
|
||||
"Licensor" shall mean the copyright owner or entity authorized by
|
||||
the copyright owner that is granting the License.
|
||||
|
||||
"Legal Entity" shall mean the union of the acting entity and all
|
||||
other entities that control, are controlled by, or are under common
|
||||
control with that entity. For the purposes of this definition,
|
||||
"control" means (i) the power, direct or indirect, to cause the
|
||||
direction or management of such entity, whether by contract or
|
||||
otherwise, or (ii) ownership of fifty percent (50%) or more of the
|
||||
outstanding shares, or (iii) beneficial ownership of such entity.
|
||||
|
||||
"You" (or "Your") shall mean an individual or Legal Entity
|
||||
exercising permissions granted by this License.
|
||||
|
||||
"Source" form shall mean the preferred form for making modifications,
|
||||
including but not limited to software source code, documentation
|
||||
source, and configuration files.
|
||||
|
||||
"Object" form shall mean any form resulting from mechanical
|
||||
transformation or translation of a Source form, including but
|
||||
not limited to compiled object code, generated documentation,
|
||||
and conversions to other media types.
|
||||
|
||||
"Work" shall mean the work of authorship made available under
|
||||
the License, as indicated by a copyright notice that is included in
|
||||
or attached to the work (an example is provided in the Appendix below).
|
||||
|
||||
"Derivative Works" shall mean any work, whether in Source or Object
|
||||
form, that is based on (or derived from) the Work and for which the
|
||||
editorial revisions, annotations, elaborations, or other transformations
|
||||
represent, as a whole, an original work of authorship. For the purposes
|
||||
of this License, Derivative Works shall not include works that remain
|
||||
separable from, or merely link (or bind by name) to the interfaces of,
|
||||
the Work and Derivative Works thereof.
|
||||
|
||||
"Contribution" shall mean, as submitted to the Licensor for inclusion
|
||||
in the Work by the copyright owner or by an individual or Legal Entity
|
||||
authorized to submit on behalf of the copyright owner. For the purposes
|
||||
of this definition, "submitted" means any form of electronic, verbal,
|
||||
or written communication sent to the Licensor or its representatives,
|
||||
including but not limited to communication on electronic mailing lists,
|
||||
source code control systems, and issue tracking systems that are managed
|
||||
by, or on behalf of, the Licensor for the purpose of discussing and
|
||||
improving the Work, but excluding communication that is conspicuously
|
||||
marked or designated in writing by the copyright owner as "Not a
|
||||
Contribution."
|
||||
|
||||
"Contributor" shall mean Licensor and any Legal Entity on behalf of
|
||||
whom a Contribution has been received by the Licensor and incorporated
|
||||
within the Work.
|
||||
|
||||
2. Grant of Copyright License. Subject to the terms and conditions of
|
||||
this License, each Contributor hereby grants to You a perpetual,
|
||||
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
|
||||
copyright license to reproduce, prepare Derivative Works of,
|
||||
publicly display, publicly perform, sublicense, and distribute the
|
||||
Work and such Derivative Works in Source or Object form.
|
||||
|
||||
3. Grant of Patent License. Subject to the terms and conditions of
|
||||
this License, each Contributor hereby grants to You a perpetual,
|
||||
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
|
||||
(except as stated in this section) patent license to make, have made,
|
||||
use, offer to sell, sell, import, and otherwise transfer the Work,
|
||||
where such license applies only to those patent claims licensable
|
||||
by such Contributor that are necessarily infringed by their
|
||||
Contribution(s) alone or by the combined Contribution(s) and the Work
|
||||
to which such Contribution(s) was submitted. If You institute patent
|
||||
litigation against any entity (including a cross-claim or counterclaim
|
||||
in a lawsuit) alleging that the Work or any Contribution embodied
|
||||
within the Work constitutes direct or contributory patent infringement,
|
||||
then any patent licenses granted to You under this License for that
|
||||
Work shall terminate as of the date such litigation is filed.
|
||||
|
||||
4. Redistribution. You may reproduce and distribute copies of the
|
||||
Work or Derivative Works thereof in any medium, with or without
|
||||
modifications, and in Source or Object form, provided that You
|
||||
meet the following conditions:
|
||||
|
||||
(a) You must give any other recipients of the Work or Derivative
|
||||
Works a copy of this License; and
|
||||
|
||||
(b) You must cause any modified files to carry prominent notices
|
||||
stating that You changed the files; and
|
||||
|
||||
(c) You must retain, in the Source form of any Derivative Works
|
||||
that You distribute, all copyright, patent, trademark, and
|
||||
attribution notices from the Source form of the Work,
|
||||
excluding those notices that do not pertain to any part of
|
||||
the Derivative Works; and
|
||||
|
||||
(d) If the Work includes a "NOTICE" text file as part of its
|
||||
distribution, You must include a readable copy of the
|
||||
attribution notices contained within such NOTICE file, in
|
||||
at least one of the following places: within a NOTICE text file
|
||||
distributed as part of the Derivative Works; within the Source
|
||||
form or documentation, if provided along with the Derivative
|
||||
Works; or, within a display generated by the Derivative Works,
|
||||
if and wherever such third-party notices normally appear. The
|
||||
contents of the NOTICE file are for informational purposes only
|
||||
and do not modify the License. You may add Your own attribution
|
||||
notices within Derivative Works that You distribute, alongside
|
||||
or as an addendum to the NOTICE text from the Work, provided
|
||||
that such additional attribution notices cannot be construed
|
||||
as modifying the License.
|
||||
|
||||
You may add Your own license statement for Your modifications and
|
||||
may provide additional grant of rights to use, copy, modify, merge,
|
||||
publish, distribute, sublicense, and/or sell copies of the Work,
|
||||
and to permit persons to whom the Work is furnished to do so,
|
||||
subject to the following conditions:
|
||||
|
||||
5. Submission of Contributions. Unless You explicitly state otherwise,
|
||||
any Contribution intentionally submitted for inclusion in the Work
|
||||
by You to the Licensor shall be under the terms and conditions of
|
||||
this License, without any additional terms or conditions.
|
||||
Notwithstanding the above, nothing herein shall supersede or modify
|
||||
the terms of any separate license agreement you may have executed
|
||||
with Licensor regarding such Contributions.
|
||||
|
||||
6. Trademarks. This License does not grant permission to use the trade
|
||||
names, trademarks, service marks, or product names of the Licensor,
|
||||
except as required for reasonable and customary use in describing the
|
||||
origin of the Work and reproducing the content of the NOTICE file.
|
||||
|
||||
7. Disclaimer of Warranty. Unless required by applicable law or
|
||||
agreed to in writing, Licensor provides the Work (and each
|
||||
Contributor provides its Contributions) on an "AS IS" BASIS,
|
||||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
|
||||
implied, including, without limitation, any conditions of TITLE,
|
||||
MERCHANTIBILITY, or FITNESS FOR A PARTICULAR PURPOSE.
|
||||
See the License for the specific language governing permissions and
|
||||
limitations under the License.
|
||||
|
||||
8. Limitation of Liability. In no event and under no legal theory,
|
||||
whether in tort (including negligence), contract, or otherwise,
|
||||
unless required by applicable law (such as deliberate and grossly
|
||||
negligent acts) or agreed to in writing, shall any Contributor be
|
||||
liable to You for damages, including any direct, indirect, special,
|
||||
incidental, or exemplary damages of any character arising as a
|
||||
result of this License or out of the use or inability to use the
|
||||
Work (even if such Contributor has been advised of the possibility
|
||||
of such damages).
|
||||
|
||||
9. Accepting Warranty or Additional Liability. While redistributing
|
||||
the Work or Derivative Works thereof, You may choose to offer,
|
||||
and charge a fee for, acceptance of support, warranty, indemnity,
|
||||
or other liability obligations and/or rights consistent with this
|
||||
License. However, in accepting such obligations, You may offer only
|
||||
conditions consistent with this License, subject to the following
|
||||
additional conditions:
|
||||
|
||||
(a) You may offer additional warranty, indemnity, or other liability
|
||||
terms and conditions; and
|
||||
|
||||
(b) You may offer support for the Work in return for a fee.
|
||||
|
||||
END OF TERMS AND CONDITIONS
|
||||
|
||||
APPENDIX: How to apply the Apache License to your work.
|
||||
|
||||
To apply the Apache License to your work, attach the following
|
||||
boilerplate notice, with the fields enclosed by brackets "[]"
|
||||
replaced with your own identifying information. (Don't include
|
||||
the brackets!) The text should be enclosed in the appropriate
|
||||
comment syntax for the file format in question. It may also be
|
||||
possible to make it available with a creative commons license.
|
||||
|
||||
Copyright 2026 Christian Manivong
|
||||
|
||||
Licensed under the Apache License, Version 2.0 (the "License");
|
||||
you may not use this file except in compliance with the License.
|
||||
You may obtain a copy of the License at
|
||||
|
||||
http://www.apache.org/licenses/LICENSE-2.0
|
||||
|
||||
Unless required by applicable law or agreed to in writing, software
|
||||
distributed under the License is distributed on an "AS IS" BASIS,
|
||||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
See the License for the specific language governing permissions and
|
||||
limitations under the License.
|
||||
@@ -32,7 +32,7 @@ output is how a driver ends up passing its own tests and failing on a real NAS.
|
||||
| `start_vm`, `stop_vm`, `reboot_vm` | `virsh` | pending harvest |
|
||||
| `set_service_enabled` | `setcfg`, `/etc/init.d` | pending harvest |
|
||||
| `get_device_warnings` | derived from the above | pending harvest |
|
||||
| `get_docker_info` | inherited, via `_docker_bin()` | ✅ |
|
||||
| `container_engines`, `open_container_engine` | Container Station's docker, `system dial-stdio` | ✅ |
|
||||
| `get_services`, `get_users`, `get_processes` | inherited from `LinuxDriver` | ✅ |
|
||||
| `get_health_metrics` | inherited (UCD-MIB over SNMP) | ✅ |
|
||||
| `ping`, `ping_sweep` | inherited from `LinuxDriver` | ✅ |
|
||||
@@ -94,9 +94,10 @@ QNAP running Virtualization Station is a NAS *and* a hypervisor, and
|
||||
### Docker
|
||||
|
||||
Container Station does not put `docker` on `PATH`; it lives under
|
||||
`/share/<pool>/.qpkg/container-station/`. The Docker *logic* stays in
|
||||
`LinuxDriver` and only the path is overridden here, via the `_docker_bin()`
|
||||
hook.
|
||||
`/share/<pool>/.qpkg/container-station/`. This driver only says where:
|
||||
`_container_engine_binary("docker")` returns the path it found, and
|
||||
`open_container_engine("docker")` from napalm-device-types reaches the Engine
|
||||
API through it. What runs on the engine is netOrk's (NetOrk/netork#765).
|
||||
|
||||
## Harvesting fixtures
|
||||
|
||||
|
||||
Whitespace-only changes.
@@ -73,6 +73,18 @@ class QnapQtsDriver(StorageDriver, HypervisorDriver, LinuxDriver):
|
||||
#: makes every "can it control services?" check -- is ``manage_service``
|
||||
#: callable -- answer no, rather than offering buttons that cannot work.
|
||||
manage_service = None # type: ignore[assignment]
|
||||
#: The same for updates: QTS has no apt, dnf or opkg, and QPKG updates are
|
||||
#: not implemented. netOrk leaves a driver without them out of patching.
|
||||
get_available_updates = None # type: ignore[assignment]
|
||||
refresh_available_updates = None # type: ignore[assignment]
|
||||
apply_updates = None # type: ignore[assignment]
|
||||
#: The fix templates LinuxDriver carries, and the package proxy it reports,
|
||||
#: need a package manager or net-snmp from packages; QTS has neither, and
|
||||
#: its SNMP agent is set in its own UI.
|
||||
configure_snmp_agent = None # type: ignore[assignment]
|
||||
configure_package_proxy = None # type: ignore[assignment]
|
||||
get_package_proxy = None # type: ignore[assignment]
|
||||
ensure_package = None # type: ignore[assignment]
|
||||
|
||||
SNMP_OBJECT_ID_PREFIX = QNAP_ENTERPRISE_OID
|
||||
SNMP_FINGERPRINT = [
|
||||
@@ -145,9 +157,11 @@ class QnapQtsDriver(StorageDriver, HypervisorDriver, LinuxDriver):
|
||||
return None
|
||||
return found.splitlines()[0].strip() or None if found else None
|
||||
|
||||
def _docker_bin(self) -> str:
|
||||
"""Override LinuxDriver's hook: docker is not on PATH under QTS."""
|
||||
return getattr(self, "_docker_path", None) or "docker"
|
||||
def _container_engine_binary(self, engine: str) -> str:
|
||||
"""Container Station keeps docker off PATH; callers never see the path."""
|
||||
if engine == "docker":
|
||||
return getattr(self, "_docker_path", None) or "docker"
|
||||
return super()._container_engine_binary(engine)
|
||||
|
||||
# ── QPKG, not apt ─────────────────────────────────────────────────────────
|
||||
#
|
||||
@@ -163,8 +177,10 @@ class QnapQtsDriver(StorageDriver, HypervisorDriver, LinuxDriver):
|
||||
"QTS uses QPKG, not a Linux package manager; QPKG parsing is not implemented yet"
|
||||
)
|
||||
|
||||
def install_package(self, name: str, version: str = "") -> None:
|
||||
# These two keep napalm-device-types' PackagesMixin signatures; LinuxDriver's
|
||||
# own differ from that contract (no version, a purge flag, a dict returned).
|
||||
def install_package(self, name: str, version: str = "") -> None: # type: ignore[override]
|
||||
raise NotImplementedError("QPKG install is not implemented yet")
|
||||
|
||||
def uninstall_package(self, name: str) -> None:
|
||||
def uninstall_package(self, name: str) -> None: # type: ignore[override]
|
||||
raise NotImplementedError("QPKG removal is not implemented yet")
|
||||
+35
-19
@@ -1,14 +1,14 @@
|
||||
[build-system]
|
||||
requires = ["setuptools>=68", "wheel"]
|
||||
requires = ["setuptools>=77"]
|
||||
build-backend = "setuptools.build_meta"
|
||||
|
||||
[project]
|
||||
name = "napalm-qnap-qts"
|
||||
version = "0.1.0"
|
||||
version = "0.6.0"
|
||||
description = "NAPALM driver for QNAP NAS systems running QTS via SSH"
|
||||
readme = "README.md"
|
||||
requires-python = ">=3.9"
|
||||
license = { text = "Apache-2.0" }
|
||||
requires-python = ">=3.10"
|
||||
license = "Apache-2.0"
|
||||
authors = [
|
||||
{ name = "Christian Manivong", email = "christian@manivong.de" },
|
||||
]
|
||||
@@ -27,13 +27,12 @@ classifiers = [
|
||||
"Development Status :: 3 - Alpha",
|
||||
"Intended Audience :: Developers",
|
||||
"Intended Audience :: System Administrators",
|
||||
"License :: OSI Approved :: Apache Software License",
|
||||
"Operating System :: OS Independent",
|
||||
"Programming Language :: Python :: 3",
|
||||
"Programming Language :: Python :: 3.9",
|
||||
"Programming Language :: Python :: 3.10",
|
||||
"Programming Language :: Python :: 3.11",
|
||||
"Programming Language :: Python :: 3.12",
|
||||
"Programming Language :: Python :: 3.13",
|
||||
"Topic :: System :: Networking",
|
||||
"Topic :: System :: Systems Administration",
|
||||
"Typing :: Typed",
|
||||
@@ -43,39 +42,56 @@ classifiers = [
|
||||
# processes, Docker) from LinuxDriver rather than reimplementing it.
|
||||
dependencies = [
|
||||
"napalm>=4.0",
|
||||
"napalm-device-types>=0.5.0",
|
||||
"napalm-linux>=0.1.0",
|
||||
"napalm-device-types>=4.22.0",
|
||||
"napalm-linux>=0.15.0",
|
||||
"netmiko>=4.0.0",
|
||||
"paramiko>=5.0.0", # CVE-2026-44405
|
||||
]
|
||||
|
||||
[project.optional-dependencies]
|
||||
dev = [
|
||||
"pytest",
|
||||
"pytest-cov",
|
||||
"black",
|
||||
"ruff",
|
||||
"mypy",
|
||||
]
|
||||
dev = ["pytest>=8", "pytest-cov>=5", "mypy>=1.11", "ruff>=0.6"]
|
||||
|
||||
[project.entry-points."napalm.drivers"]
|
||||
qnap_qts = "napalm_qnap_qts:QnapQtsDriver"
|
||||
|
||||
[project.urls]
|
||||
Repository = "https://git.netork.io/NAPALM/napalm-qnap-qts"
|
||||
Issues = "https://git.netork.io/NAPALM/napalm-qnap-qts/issues"
|
||||
Changelog = "https://git.netork.io/NAPALM/napalm-qnap-qts/src/branch/main/CHANGELOG.md"
|
||||
|
||||
[tool.setuptools.packages.find]
|
||||
where = ["."]
|
||||
include = ["napalm_qnap_qts*"]
|
||||
|
||||
[tool.setuptools.package-data]
|
||||
napalm_qnap_qts = ["py.typed"]
|
||||
|
||||
[tool.pytest.ini_options]
|
||||
testpaths = ["tests"]
|
||||
|
||||
[tool.ruff]
|
||||
line-length = 100
|
||||
target-version = "py39"
|
||||
target-version = "py310"
|
||||
|
||||
# Same rule set the netOrk repo gates on, so this driver is held to the
|
||||
# standard of the project that consumes it rather than to ruff's defaults.
|
||||
[tool.ruff.lint]
|
||||
select = ["E", "F", "I", "UP"]
|
||||
select = ["E", "F", "I", "UP", "B"]
|
||||
|
||||
[tool.ruff.lint.per-file-ignores]
|
||||
# Recorded device output keeps its lines.
|
||||
"tests/**" = ["E501"]
|
||||
|
||||
[tool.mypy]
|
||||
python_version = "3.10"
|
||||
strict = true
|
||||
# napalm itself is untyped, so every driver subclasses Any.
|
||||
disallow_subclassing_any = false
|
||||
|
||||
[[tool.mypy.overrides]]
|
||||
module = ["napalm.*", "netmiko.*", "paramiko.*"]
|
||||
ignore_missing_imports = true
|
||||
|
||||
[tool.coverage.run]
|
||||
source = ["napalm_qnap_qts"]
|
||||
|
||||
[tool.coverage.report]
|
||||
fail_under = 76
|
||||
@@ -0,0 +1,8 @@
|
||||
{
|
||||
"coverage_floor": 76.0,
|
||||
"function_complexity": {},
|
||||
"function_lines": {},
|
||||
"mypy_relaxed": [],
|
||||
"python_file_lines": {},
|
||||
"untyped_public": []
|
||||
}
|
||||
+59
-9
@@ -10,8 +10,8 @@ from __future__ import annotations
|
||||
from unittest.mock import MagicMock, patch
|
||||
|
||||
import pytest
|
||||
|
||||
from napalm_device_types import primary_role_of, role_keys_of
|
||||
|
||||
from napalm_qnap_qts import QnapQtsDriver
|
||||
|
||||
#: Parsers need real command output to be written against. These tests are the
|
||||
@@ -97,7 +97,7 @@ class TestRolesDoNotShadowLinux:
|
||||
collision. There is nothing left to collide with.
|
||||
"""
|
||||
|
||||
@pytest.mark.parametrize("method", ["get_services", "get_users", "get_docker_info"])
|
||||
@pytest.mark.parametrize("method", ["get_services", "get_os_users"])
|
||||
def test_os_surface_resolves_to_linux(self, method):
|
||||
"""QTS really is Linux for these, so inheriting them is correct."""
|
||||
from napalm_linux.linux import LinuxDriver
|
||||
@@ -105,9 +105,7 @@ class TestRolesDoNotShadowLinux:
|
||||
owner = next(k for k in QnapQtsDriver.__mro__ if method in k.__dict__)
|
||||
assert owner is LinuxDriver
|
||||
|
||||
@pytest.mark.parametrize(
|
||||
"method", ["get_packages", "install_package", "uninstall_package"]
|
||||
)
|
||||
@pytest.mark.parametrize("method", ["get_packages", "install_package", "uninstall_package"])
|
||||
def test_package_surface_is_refused_deliberately(self, method):
|
||||
"""QTS has no apt/dnf, so LinuxDriver's versions must not be inherited
|
||||
silently -- this driver overrides them to refuse."""
|
||||
@@ -117,7 +115,8 @@ class TestRolesDoNotShadowLinux:
|
||||
def test_no_forwarding_methods_remain(self):
|
||||
"""A forwarder here would mean the shadowing came back."""
|
||||
own = {
|
||||
name for name, val in vars(QnapQtsDriver).items()
|
||||
name
|
||||
for name, val in vars(QnapQtsDriver).items()
|
||||
if callable(val) and not name.startswith("__")
|
||||
}
|
||||
assert "get_services" not in own
|
||||
@@ -179,9 +178,31 @@ class TestDockerBinDiscovery:
|
||||
with patch.object(driver, "_send", return_value=""):
|
||||
assert driver._discover_docker_path() == "docker"
|
||||
|
||||
def test_docker_bin_hook_returns_the_discovered_path(self, driver):
|
||||
driver._docker_path = "/opt/docker"
|
||||
assert driver._docker_bin() == "/opt/docker"
|
||||
def test_the_old_docker_methods_are_gone(self):
|
||||
"""netOrk reaches Container Station over the Engine API (NetOrk/netork#765)."""
|
||||
for name in ("get_docker_info", "get_docker_outdated", "_docker_bin"):
|
||||
assert not hasattr(QnapQtsDriver, name), name
|
||||
|
||||
|
||||
class TestContainerEngineBinary:
|
||||
"""The container engine connection (napalm-device-types 2.6.0) reaches
|
||||
Container Station's docker, not one on PATH: the driver decides where the
|
||||
binary lives, and netOrk never sees it (NetOrk/netork#765)."""
|
||||
|
||||
def test_the_engine_binary_is_the_discovered_path(self, driver):
|
||||
driver._docker_path = "/share/CACHEDEV1_DATA/.qpkg/container-station/bin/docker"
|
||||
assert driver._container_engine_binary("docker") == driver._docker_path
|
||||
|
||||
def test_the_api_stream_runs_dial_stdio_from_that_path(self, driver):
|
||||
driver._docker_path = "/share/CACHEDEV1_DATA/.qpkg/container-station/bin/docker"
|
||||
opened = []
|
||||
with patch.object(driver, "open_stream", side_effect=lambda cmd, **kw: opened.append(cmd)):
|
||||
driver.open_container_engine("docker").open_api()
|
||||
assert opened == [f"{driver._docker_path} system dial-stdio"]
|
||||
|
||||
def test_without_a_discovered_path_it_falls_back_to_plain_docker(self, driver):
|
||||
driver._docker_path = None
|
||||
assert driver._container_engine_binary("docker") == "docker"
|
||||
|
||||
|
||||
def test_services_cannot_be_controlled():
|
||||
@@ -192,3 +213,32 @@ def test_services_cannot_be_controlled():
|
||||
|
||||
assert callable(getattr(LinuxDriver, "manage_service", None))
|
||||
assert not callable(getattr(QnapQtsDriver, "manage_service", None))
|
||||
|
||||
|
||||
def test_updates_are_not_read_or_applied_here():
|
||||
"""QTS has no apt, dnf or opkg: the readers inherited from LinuxDriver find no
|
||||
package manager, and QPKG updates are not implemented. Saying so keeps QNAP out
|
||||
of netOrk's patch groups and compliance report, which ask whether these
|
||||
methods are callable."""
|
||||
for method in ("get_available_updates", "refresh_available_updates", "apply_updates"):
|
||||
assert not callable(getattr(QnapQtsDriver, method, None)), method
|
||||
|
||||
|
||||
class TestFixesQtsCannotTake:
|
||||
"""QTS has no apt, dnf or opkg, and its SNMP agent is configured in its own UI:
|
||||
the fix templates inherited from LinuxDriver are switched off (#7), so a
|
||||
capability check -- is it callable? -- answers no."""
|
||||
|
||||
@pytest.mark.parametrize(
|
||||
"name",
|
||||
["configure_snmp_agent", "configure_package_proxy", "get_package_proxy", "ensure_package"],
|
||||
)
|
||||
def test_switched_off(self, name):
|
||||
assert getattr(QnapQtsDriver, name) is None
|
||||
|
||||
|
||||
def test_no_warnings_of_its_own():
|
||||
"""napalm-linux names no warnings any more (netOrk #1111), so neither does
|
||||
this driver; the override that kept the inherited one from asking for updates
|
||||
QTS cannot list (#6) is gone with it."""
|
||||
assert not callable(getattr(QnapQtsDriver, "get_device_warnings", None))
|
||||
Reference in new issue
Block a user