The cloud-image download put image_url, hand-wrapped in single quotes, and the cache path built from its basename unquoted into commands that run as root on the node: a quote, $(...), ; or space in a URL from a release feed was acted on by the shell. The URL and every path built from it now go through shlex.quote (exists check, wget, mv, checksum, rm, unpack, qm importdisk), and the cache file name keeps only the characters Proxmox keeps in a content file name, as the import volume name already did. The checksum algorithm is checked against the ones Proxmox knows, since it is part of the command name. The file-name helpers move to image_names.py; vm_provision_mixin.py would otherwise cross the 1000-line limit. _download_cloud_image drops below 50 lines, so its baseline entry goes. Closes #43
63 lines
3.3 KiB
JSON
63 lines
3.3 KiB
JSON
{
|
|
"coverage_floor": 68.0,
|
|
"function_complexity": {
|
|
"napalm_proxmox/driver.py::ProxmoxDriver._resolve_node": 13,
|
|
"napalm_proxmox/driver.py::ProxmoxDriver.get_facts": 16,
|
|
"napalm_proxmox/interfaces_mixin.py::ProxmoxInterfaceMixin.get_interfaces_counters": 14,
|
|
"napalm_proxmox/interfaces_mixin.py::ProxmoxInterfaceMixin.get_mac_address_table": 22,
|
|
"napalm_proxmox/routing_mixin.py::ProxmoxRoutingMixin.get_route_to": 13,
|
|
"napalm_proxmox/routing_mixin.py::ProxmoxRoutingMixin.ping": 12,
|
|
"napalm_proxmox/sdn_mixin.py::ProxmoxSDNMixin._find_switch_uplink": 13,
|
|
"napalm_proxmox/sdn_mixin.py::ProxmoxSDNMixin._get_ovs_bridge_for_port": 13,
|
|
"napalm_proxmox/sdn_mixin.py::ProxmoxSDNMixin._get_vm_vlan_tags": 11,
|
|
"napalm_proxmox/sdn_mixin.py::ProxmoxSDNMixin._is_cluster_master": 13,
|
|
"napalm_proxmox/sdn_mixin.py::ProxmoxSDNMixin.get_network_instances": 13,
|
|
"napalm_proxmox/sdn_mixin.py::ProxmoxSDNMixin.get_vlans": 16,
|
|
"napalm_proxmox/sdn_mixin.py::ProxmoxSDNMixin.set_vlan": 13,
|
|
"napalm_proxmox/system_mixin.py::ProxmoxSystemMixin.get_disk_smart": 22,
|
|
"napalm_proxmox/system_mixin.py::ProxmoxSystemMixin.get_packages": 16,
|
|
"napalm_proxmox/utils.py::addresses_from_node_network": 15,
|
|
"napalm_proxmox/vm_contract_mixin.py::parse_vm_config": 16,
|
|
"napalm_proxmox/vm_mixin.py::ProxmoxVMMixin._get_vm_disk_and_boot": 16,
|
|
"napalm_proxmox/vm_mixin.py::ProxmoxVMMixin.get_vm_interfaces": 37,
|
|
"napalm_proxmox/vm_mixin.py::ProxmoxVMMixin.get_vms": 21,
|
|
"napalm_proxmox/vm_provision_mixin.py::ProxmoxVMProvisionMixin.create_vm_from_cloud_init": 18,
|
|
"napalm_proxmox/vm_provision_mixin.py::ProxmoxVMProvisionMixin.get_vm_status": 16
|
|
},
|
|
"function_lines": {
|
|
"napalm_proxmox/driver.py::ProxmoxDriver.get_facts": 82,
|
|
"napalm_proxmox/interfaces_mixin.py::ProxmoxInterfaceMixin.get_mac_address_table": 71,
|
|
"napalm_proxmox/lldp_mixin.py::ProxmoxLLDPMixin.get_lldp_neighbors_detail": 52,
|
|
"napalm_proxmox/routing_mixin.py::ProxmoxRoutingMixin.ping": 78,
|
|
"napalm_proxmox/sdn_mixin.py::ProxmoxSDNMixin._get_vm_vlan_tags": 54,
|
|
"napalm_proxmox/sdn_mixin.py::ProxmoxSDNMixin.get_vlans": 66,
|
|
"napalm_proxmox/sdn_mixin.py::ProxmoxSDNMixin.set_vlan": 70,
|
|
"napalm_proxmox/system_mixin.py::ProxmoxSystemMixin.get_disk_smart": 74,
|
|
"napalm_proxmox/system_mixin.py::ProxmoxSystemMixin.get_packages": 66,
|
|
"napalm_proxmox/system_mixin.py::ProxmoxSystemMixin.set_hostname": 114,
|
|
"napalm_proxmox/vm_mixin.py::ProxmoxVMMixin.get_vm_interfaces": 179,
|
|
"napalm_proxmox/vm_mixin.py::ProxmoxVMMixin.get_vms": 114,
|
|
"napalm_proxmox/vm_provision_mixin.py::ProxmoxVMProvisionMixin.create_vm_from_cloud_init": 220,
|
|
"napalm_proxmox/vm_provision_mixin.py::ProxmoxVMProvisionMixin.destroy_vm": 56,
|
|
"napalm_proxmox/vm_provision_mixin.py::ProxmoxVMProvisionMixin.get_vm_status": 92
|
|
},
|
|
"mypy_relaxed": [
|
|
"napalm_proxmox.config_mixin",
|
|
"napalm_proxmox.driver",
|
|
"napalm_proxmox.interfaces_mixin",
|
|
"napalm_proxmox.lldp_mixin",
|
|
"napalm_proxmox.routing_mixin",
|
|
"napalm_proxmox.sdn_mixin",
|
|
"napalm_proxmox.system_mixin",
|
|
"napalm_proxmox.utils",
|
|
"napalm_proxmox.vm_contract_mixin",
|
|
"napalm_proxmox.vm_mixin",
|
|
"napalm_proxmox.vm_provision_mixin"
|
|
],
|
|
"python_file_lines": {},
|
|
"untyped_public": [
|
|
"napalm_proxmox/sdn_mixin.py::ProxmoxSDNMixin.set_vlan",
|
|
"napalm_proxmox/system_mixin.py::ProxmoxSystemMixin.get_snmp_config"
|
|
]
|
|
}
|