feat(time-sync): servers and zone on Proxmox VE and Backup Server #63

Merged
christianmanivong merged 1 commits from feature/time-sync-2365 into main 2026-11-11 14:26:16 +00:00
Owner

Summary

  • Both drivers implement napalm-device-types' TimeSyncMixin (4.35.0); time_sync_writes = {"ntp_servers", "timezone"}.
  • Neither API keeps time servers (/nodes/{node}/time knows only the zone; both products run chrony on Debian), so the servers are PosixTimeSyncMixin's over the driver's existing SSH session (run_command, root): read from chrony's configuration, written to /etc/chrony/sources.d/netork.sources with every other source commented out (Debian's vendor pool, the DHCP sourcedir), then a reload or a restart of chrony.
  • The zone is read from the host with them (timedatectl, the zone the clock really runs in), and from GET /nodes/{node}/time only where the host names none. It is written through PUT /nodes/{node}/time (PBS: /nodes/localhost/time) rather than timedatectl set-timezone: Proxmox's own call validates the name and keeps /etc/timezone, which its web UI and API show, in step with /etc/localtime. Writing it needs Sys.Modify (PVE on /nodes/{node}, PBS on /system/time); a refusal fails the step with the API's message.
  • One device is one node: in a PVE cluster only the node this connection resolved is read and written.
  • Fix: get_ntp_servers() read GET /nodes/{node}/ntp, a path Proxmox VE does not have, so it always reported no servers. It now reports what get_time_sync() reads, on the backup server too.
  • Dependency floor napalm_device_types>=4.35.0; changelog under Unreleased (the version is bumped in the release PR, as before).

Related Issue

NetOrk/netork#2365 (part of NetOrk/netork#2360)

Testing

  • tests/test_time_sync.py (21): reading on both drivers, the API fallback for the zone, the zone write per node (cluster: only pve2 addressed), a 403 and a 400 from the API, verify failing on a zone not taken, the chrony write (sources file, lines 8 and 11 of Debian's chrony.conf commented out, restart) and its no-churn repeat (same file, nothing commented, chronyc reload sources), the template's refusals.
  • Full suite 640 passed, ruff, mypy, bandit, napalm-standard check and ratchet locally.
## Summary - Both drivers implement napalm-device-types' `TimeSyncMixin` (4.35.0); `time_sync_writes = {"ntp_servers", "timezone"}`. - Neither API keeps time servers (`/nodes/{node}/time` knows only the zone; both products run chrony on Debian), so the servers are `PosixTimeSyncMixin`'s over the driver's existing SSH session (`run_command`, root): read from chrony's configuration, written to `/etc/chrony/sources.d/netork.sources` with every other source commented out (Debian's vendor pool, the DHCP `sourcedir`), then a reload or a restart of chrony. - The zone is read from the host with them (`timedatectl`, the zone the clock really runs in), and from `GET /nodes/{node}/time` only where the host names none. It is written through `PUT /nodes/{node}/time` (PBS: `/nodes/localhost/time`) rather than `timedatectl set-timezone`: Proxmox's own call validates the name and keeps `/etc/timezone`, which its web UI and API show, in step with `/etc/localtime`. Writing it needs `Sys.Modify` (PVE on `/nodes/{node}`, PBS on `/system/time`); a refusal fails the step with the API's message. - One device is one node: in a PVE cluster only the node this connection resolved is read and written. - Fix: `get_ntp_servers()` read `GET /nodes/{node}/ntp`, a path Proxmox VE does not have, so it always reported no servers. It now reports what `get_time_sync()` reads, on the backup server too. - Dependency floor `napalm_device_types>=4.35.0`; changelog under Unreleased (the version is bumped in the release PR, as before). ## Related Issue NetOrk/netork#2365 (part of NetOrk/netork#2360) ## Testing - `tests/test_time_sync.py` (21): reading on both drivers, the API fallback for the zone, the zone write per node (cluster: only `pve2` addressed), a 403 and a 400 from the API, verify failing on a zone not taken, the chrony write (sources file, lines 8 and 11 of Debian's `chrony.conf` commented out, restart) and its no-churn repeat (same file, nothing commented, `chronyc reload sources`), the template's refusals. - Full suite 640 passed, ruff, mypy, bandit, `napalm-standard check` and `ratchet` locally.
christianmanivong added 1 commit 2026-11-11 14:18:36 +00:00
feat(time-sync): servers and zone on Proxmox VE and Backup Server
driver / standard (pull_request) Successful in 14s
driver / lint (pull_request) Successful in 14s
driver / types (pull_request) Successful in 56s
driver / test (3.12) (pull_request) Successful in 1m2s
driver / test (3.13) (pull_request) Successful in 59s
driver / lowest (pull_request) Successful in 32s
driver / build (pull_request) Successful in 31s
driver / security (pull_request) Successful in 1m11s
CI / driver (pull_request) Successful in 2m41s
driver / publish (pull_request) Skipped
410d34bdee
netOrk keeps one list of NTP servers and a time zone per site and aligns
a device that differs (NetOrk/netork#2360, #2365). Both drivers now
implement napalm-device-types' TimeSyncMixin (4.35.0) and write both
values.

Neither API keeps time servers: /nodes/{node}/time knows only the zone,
and both products run chrony on Debian. The servers are therefore
PosixTimeSyncMixin's, over the driver's existing SSH session
(run_command, root): read from chrony's configuration, written to
/etc/chrony/sources.d/netork.sources with every other source commented
out, then a reload or a restart of chrony.

The zone is read with them from the host (timedatectl: the zone the
clock really runs in), and from GET /nodes/{node}/time only where the
host names none. It is written through PUT /nodes/{node}/time rather
than timedatectl set-timezone: Proxmox's own call validates the name and
keeps /etc/timezone, which its web UI and API show, in step with
/etc/localtime.

One device is one node: in a PVE cluster every node has its own clock,
and only the node this connection resolved is read and written.

get_ntp_servers() read GET /nodes/{node}/ntp, a path Proxmox VE does not
have, so it always reported no servers. It now reports what
get_time_sync() reads, on the backup server too.
christianmanivong merged commit 042b21d3d9 into main 2026-11-11 14:26:16 +00:00
christianmanivong deleted branch feature/time-sync-2365 2026-11-11 14:26:16 +00:00
Sign in to join this conversation.