NAPALM/napalm-proxmox

0 Fork 0

chore: adopt the NAPALM driver standard #33

Merged

christianmanivong merged 4 commits from chore/driver-standard into main

2026-10-23 12:17:27 +00:00

Author	SHA1	Message	Date
Christian Manivong	711d5f2705	chore(release): 0.8.0 driver / standard (pull_request) Successful in 15s Details driver / lint (pull_request) Successful in 12s Details driver / types (pull_request) Successful in 59s Details driver / test (3.10) (pull_request) Successful in 1m13s Details driver / test (3.11) (pull_request) Successful in 1m18s Details driver / test (3.12) (pull_request) Successful in 1m6s Details driver / test (3.13) (pull_request) Successful in 59s Details driver / lowest (pull_request) Successful in 45s Details driver / build (pull_request) Successful in 30s Details driver / security (pull_request) Successful in 1m9s Details CI / driver (pull_request) Successful in 3m29s Details driver / publish (pull_request) Skipped Details	2026-10-23 12:02:11 +02:00
Christian Manivong	457c1ca7ed	chore: adopt the NAPALM driver standard driver / standard (pull_request) Successful in 14s Details driver / lint (pull_request) Successful in 14s Details driver / types (pull_request) Failing after 53s Details driver / test (3.10) (pull_request) Failing after 44s Details driver / test (3.11) (pull_request) Failing after 1m6s Details driver / test (3.12) (pull_request) Failing after 47s Details driver / test (3.13) (pull_request) Failing after 36s Details driver / lowest (pull_request) Failing after 19s Details driver / security (pull_request) Failing after 46s Details driver / build (pull_request) Successful in 22s Details CI / driver (pull_request) Failing after 6m3s Details driver / publish (pull_request) Skipped Details - CI moves to .gitea/workflows/ci.yml and calls the shared driver workflow of NAPALM/driver-standard; .github/ is gone. napalm-device-types comes from git until 4.22.0 (AptProxyMixin) is on PyPI; the floor stays at 4.22.0. - requires-python >=3.10 (napalm-device-types needs it), py.typed, SPDX license string, a dev extra with floors (pytest-mock and responses are dropped: no test uses them), links to git.netork.io (README included). pytest no longer adds --cov by itself; CI passes it. - mypy strict for the package; exempt for now, with 204 errors between them: napalm_proxmox.config_mixin, .driver, .interfaces_mixin, .lldp_mixin, .routing_mixin, .sdn_mixin, .system_mixin, .utils, .vm_contract_mixin, .vm_mixin and .vm_provision_mixin. They are recorded in the quality baseline with the long and complex functions and the two unannotated public methods. - Coverage floor 68 % (measured 68.94 %).	2026-10-23 08:40:41 +02:00
Christian Manivong	3365207c98	fix: what bandit and the remaining lint rules found - driver.py: the logger is defined after the imports (E402). The lazy paramiko client is annotated Any, as _node_ssh already is; the quoted paramiko.SSHClient named a module that is never imported there (F821). - Unused locals are gone: get_facts' hostname, get_users' groups (both read a value nobody used), the ARP flags column is _flags; the output is unchanged. - Long lines are wrapped: the apt-get and snmpd.conf commands are split into adjacent string literals, the power-action error message and the system mixin's docstring are wrapped; the text is unchanged. - get_vm_status re-raises with raise ... from e (B904). - The two except Exception: pass (closing the SSH session, the is_alive probe) now log at debug level (B110), so a swallowed failure leaves a trace. - nosec for the empty "password" field of NAPALM's get_users shape and the ssh_password_auth flag (B105); all three are false positives. - tests: unused loop variables.	2026-10-23 08:39:01 +02:00
Christian Manivong	3b873d91fe	style: ruff format and the lint rules of the driver standard Mechanical: ruff format, and ruff check --fix with the rule set every NAPALM driver uses (E, F, I, UP, B at line length 100, Python 3.10). What ruff cannot fix comes in the next commit.	2026-10-23 08:37:27 +02:00