feat!: fix templates with the caller's values replace run_device_action (0.3.0) #25

Merged

christianmanivong merged 2 commits from feat/fix-templates into master 2026-10-17 06:48:19 +00:00

Conversation 0 Commits 2 Files Changed 5

+217 -119

christianmanivong commented 2026-10-17 06:28:51 +00:00

Owner

Copy link

Copy source

Step 4 of NetOrk/netork#1105.

• configure_snmp_agent(settings): net-snmp, snmpd.conf with one rocommunity per allowed source (mktemp + install, no fixed /tmp/netork_snmpd.conf), ufw only for those sources (pve-firewall untouched), snmpd enabled/restarted.
• get_management_peer() from SSH_CONNECTION.
• install_package(name) per contract (raises on apt failure) → ensure_package from the base package replaces install_lldpd.
• Every step reads its exit status (_exec_ssh_command has none, so a marker).
• run_device_action, _action_fix_snmp, _action_install_lldpd gone.

netOrk asks for the templates first (NetOrk/netork#1130), so this needs only the pin bump.

Part of #24 (the transport rework #17 and the provisioning/warnings parts stay open).

Step 4 of NetOrk/netork#1105. - `configure_snmp_agent(settings)`: net-snmp, `snmpd.conf` with one `rocommunity` per allowed source (mktemp + install, no fixed `/tmp/netork_snmpd.conf`), ufw only for those sources (pve-firewall untouched), snmpd enabled/restarted. - `get_management_peer()` from `SSH_CONNECTION`. - `install_package(name)` per contract (raises on apt failure) → `ensure_package` from the base package replaces `install_lldpd`. - Every step reads its exit status (`_exec_ssh_command` has none, so a marker). - `run_device_action`, `_action_fix_snmp`, `_action_install_lldpd` gone. netOrk asks for the templates first (NetOrk/netork#1130), so this needs only the pin bump. Part of #24 (the transport rework #17 and the provisioning/warnings parts stay open).

christianmanivong added 1 commit 2026-10-17 06:28:51 +00:00

feat!: fix templates with the caller's values replace run_device_action (0.3.0) ... 890e84ca6b

fix_snmp overwrote snmpd.conf with an application's values (community
"public", "Managed by netOrk", netork@localhost) through a fixed
/tmp/netork_snmpd.conf, and opened ufw for a /24 guessed from ss;
install_lldpd was an action of its own. Neither read an exit status.

The driver implements napalm-device-types 4.13's templates instead:
- configure_snmp_agent(settings): net-snmp installed, snmpd.conf with
  one rocommunity line per allowed source (mktemp, install as root),
  ufw opened for those sources only (pve-firewall stays the
  operator's), snmpd enabled and restarted;
- get_management_peer() from SSH_CONNECTION;
- install_package(name), as the contract says (raises when apt fails),
  so ensure_package comes from the base package.
Every step reads its exit status.

BREAKING CHANGE: run_device_action is removed. Requires
napalm-device-types 4.13.

Part of #24.

christianmanivong added 1 commit 2026-10-17 06:29:06 +00:00

docs: changelog for 0.3.0 377e849237

christianmanivong merged commit 8cf334aaf5 into master 2026-10-17 06:48:19 +00:00

christianmanivong deleted branch feat/fix-templates 2026-10-17 06:48:19 +00:00

christianmanivong referenced this pull request 2026-10-18 12:44:03 +00:00

Agnostic structure: fix templates, guest profile from the caller, napalm-unix transport #24

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something is broken

enhancement

New feature or request

tech-debt

Refactoring / cleanup / deferred debt

prio

P0

Road blocker: blocks other work, drop everything

prio

P1

Critical

prio

P2

Important and urgent

prio

P3

Important, not urgent

prio

P4

Neither important nor urgent

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

christianmanivong

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: NAPALM/napalm-proxmox#25