fix(connection): is_alive probes the host and port of base_url (scheme default when no port) (#15).
fix(dns): a failed host-override read raises before sync_dns_zone writes anything, instead of re-adding every override; get_dns_entries() raises too (netOrk's poll already treats that as "unknown", #1458) (#14).
fix(dhcp): Kea reservations are matched on address and MAC. Create raises RuntimeError when another MAC holds the address and writes nothing; delete removes only the given MAC's reservation and lease and reports another host's MAC in the new key reservation_other_mac (#26). Note: netOrk's VM provisioning will now fail a job whose address is reserved for another MAC.
Three bug fixes, one commit each.
- `fix(connection)`: `is_alive` probes the host and port of `base_url` (scheme default when no port) (#15).
- `fix(dns)`: a failed host-override read raises before `sync_dns_zone` writes anything, instead of re-adding every override; `get_dns_entries()` raises too (netOrk's poll already treats that as "unknown", #1458) (#14).
- `fix(dhcp)`: Kea reservations are matched on address **and** MAC. Create raises `RuntimeError` when another MAC holds the address and writes nothing; delete removes only the given MAC's reservation and lease and reports another host's MAC in the new key `reservation_other_mac` (#26). Note: netOrk's VM provisioning will now fail a job whose address is reserved for another MAC.
Already fixed on main, no code touched: #24/#25 (bb0810d, age `-1.0`), #2 (960aaef), #1 (1f29d9d).
Tested: fixtures only. pytest 480 passed, ruff, mypy, `napalm-standard check`/`ratchet` green (baseline only shrank).
Closes #15
Closes #14
Closes #26
is_alive always opened port 443 on the hostname, so a firewall whose API
is reached through base_url on another port (https://fw:8443) read as
dead. The probe now takes host and port from base_url, falling back to
the scheme's default port.
Closes#15
The Unbound and Dnsmasq override reads logged any error and returned an
empty list. sync_dns_zone took that for "no overrides": it deleted
nothing and added every record again, so a transient API error left
each record twice on the firewall. The reads now raise, which stops the
sync before it writes and lets get_dns_entries callers tell a failed
read from an empty one.
Closes#14
create_dhcp_reservation and delete_dhcp_reservation_and_lease looked a
reservation up by its address alone. A reservation another MAC held for
the address, made by hand or left from an earlier host, was overwritten
on create and removed on delete, together with that host's lease.
Create now raises instead of taking it over, and delete leaves another
MAC's reservation and lease in place and names that MAC in the new
reservation_other_mac field. The matching lives in kea_reservations, a
module under strict typing.
Closes#26
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Three bug fixes, one commit each.
fix(connection):is_aliveprobes the host and port ofbase_url(scheme default when no port) (#15).fix(dns): a failed host-override read raises beforesync_dns_zonewrites anything, instead of re-adding every override;get_dns_entries()raises too (netOrk's poll already treats that as "unknown", #1458) (#14).fix(dhcp): Kea reservations are matched on address and MAC. Create raisesRuntimeErrorwhen another MAC holds the address and writes nothing; delete removes only the given MAC's reservation and lease and reports another host's MAC in the new keyreservation_other_mac(#26). Note: netOrk's VM provisioning will now fail a job whose address is reserved for another MAC.Already fixed on main, no code touched: #24/#25 (
bb0810d, age-1.0), #2 (960aaef), #1 (1f29d9d).Tested: fixtures only. pytest 480 passed, ruff, mypy,
napalm-standard check/ratchetgreen (baseline only shrank).Closes #15
Closes #14
Closes #26