NAPALM/napalm-openwrt
1
0 Fork 0
Code Issues 8 Pull Requests Actions Packages Projects Releases Wiki Activity

feat: reboot_host (0.5.0) #17

Merged
christianmanivong merged 1 commits from feat/reboot-host into master 2026-10-18 12:48:21 +00:00
Conversation 0 Commits 1 Files Changed 3
+52 -1
christianmanivong commented 2026-10-18 12:45:44 +00:00
Owner
Copy link
Copy source

reboot_host() (napalm-device-types HostRebootMixin, carried by AccessPointDriver) over run_command: reboot detached with trap '' HUP and two seconds late, the pattern napalm-linux uses, so the answer comes back before the session goes down. A refusal (exit code) raises RuntimeError; a login other than root is refused before anything runs.

netOrk sent /sbin/reboot through the private _send_command and treated any answer as success (NetOrk/netork#1113).

Part of #13

`reboot_host()` (napalm-device-types `HostRebootMixin`, carried by `AccessPointDriver`) over `run_command`: `reboot` detached with `trap '' HUP` and two seconds late, the pattern napalm-linux uses, so the answer comes back before the session goes down. A refusal (exit code) raises `RuntimeError`; a login other than root is refused before anything runs. netOrk sent `/sbin/reboot` through the private `_send_command` and treated any answer as success (NetOrk/netork#1113). Part of #13
christianmanivong added 1 commit 2026-10-18 12:45:44 +00:00
feat: reboot_host (0.5.0)
CI / test (3.10) (push) Successful in 26s
Details
CI / test (3.11) (push) Successful in 23s
Details
CI / test (3.12) (push) Successful in 26s
Details
CI / test (3.10) (pull_request) Successful in 25s
Details
CI / test (3.11) (pull_request) Successful in 24s
Details
CI / test (3.12) (pull_request) Successful in 25s
Details
d89bb38688 
HostRebootMixin's reboot_host over the command channel: reboot detached
and two seconds late, so the answer comes back before the session goes
down, and a refusal is raised instead of being mistaken for the dropped
session. netOrk sent /sbin/reboot through the private _send_command and
could not tell the two apart (netOrk #1113). A login other than root is
refused before anything runs.
christianmanivong merged commit fddb5c6772 into master 2026-10-18 12:48:21 +00:00
christianmanivong deleted branch feat/reboot-host 2026-10-18 12:48:21 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is broken
 enhancement
New feature or request
 tech-debt
Refactoring / cleanup / deferred debt
prio
P0
Road blocker: blocks other work, drop everything
prio
P1
Critical
prio
P2
Important and urgent
prio
P3
Important, not urgent
prio
P4
Neither important nor urgent
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
christianmanivong
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-openwrt#17