fix(wireless): refuse an unknown MAC ACL mode before sending anything
driver / standard (pull_request) Successful in 17s
driver / lint (pull_request) Successful in 15s
driver / types (pull_request) Successful in 1m0s
driver / test (3.12) (pull_request) Successful in 1m0s
driver / test (3.13) (pull_request) Successful in 55s
driver / lowest (pull_request) Successful in 30s
driver / build (pull_request) Successful in 32s
driver / security (pull_request) Successful in 1m9s
CI / driver (pull_request) Successful in 2m41s
driver / publish (pull_request) Skipped
driver / standard (pull_request) Successful in 17s
driver / lint (pull_request) Successful in 15s
driver / types (pull_request) Successful in 1m0s
driver / test (3.12) (pull_request) Successful in 1m0s
driver / test (3.13) (pull_request) Successful in 55s
driver / lowest (pull_request) Successful in 30s
driver / build (pull_request) Successful in 32s
driver / security (pull_request) Successful in 1m9s
CI / driver (pull_request) Successful in 2m41s
driver / publish (pull_request) Skipped
push_mac_acl wrote macfilter='allow' for "whitelist" and 'deny' for any other mode but "off", so a mode the driver does not know -- a typo, or a new mode from the caller -- became a deny list. It now raises ValueError naming the mode before the first command is sent. Closes #39
This commit is contained in:
1 parent
780b635174
commit
17d9bead50
3 files changed
+20
-1
No files matched your search
@@ -293,3 +293,13 @@ def test_a_failed_wifi_restart_raises_naming_it():
|
||||
ap = _Ap({"wifi": CommandResult("", "", 1)})
|
||||
with pytest.raises(CommandErrorException, match="`wifi`.*exit status 1"):
|
||||
_driver(ap).push_radio_channel("radio0", 6)
|
||||
|
||||
|
||||
@pytest.mark.parametrize("mode", ["deny", "Blacklist", "disable", ""])
|
||||
def test_an_unknown_mode_raises_before_anything_is_sent(mode):
|
||||
"""A mode the driver does not know was written as a deny list (#39)."""
|
||||
ap = _Ap()
|
||||
with pytest.raises(ValueError, match=repr(mode)):
|
||||
_driver(ap).push_mac_acl("CorpWiFi", mode, ["00:00:5E:00:53:0A"])
|
||||
|
||||
assert ap.commands == []
|
||||
Reference in new issue
Block a user