Found while fixing #35 (PR #38). _mac_acl_changes (napalm_openwrt/wireless_mixin.py) handles off, and otherwise writes macfilter='allow' for whitelist and 'deny' for anything else. A mode the driver does not know (a typo, a new mode from the caller) is silently written as a deny list instead of being refused.
Expected: an unknown mode raises ValueError naming it, before anything is sent.
Priority: P3 (important, not urgent).
Found while fixing #35 (PR #38). `_mac_acl_changes` (`napalm_openwrt/wireless_mixin.py`) handles `off`, and otherwise writes `macfilter='allow'` for `whitelist` and `'deny'` for anything else. A mode the driver does not know (a typo, a new mode from the caller) is silently written as a deny list instead of being refused.
Expected: an unknown mode raises `ValueError` naming it, before anything is sent.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Priority: P3 (important, not urgent).
Found while fixing #35 (PR #38).
_mac_acl_changes(napalm_openwrt/wireless_mixin.py) handlesoff, and otherwise writesmacfilter='allow'forwhitelistand'deny'for anything else. A mode the driver does not know (a typo, a new mode from the caller) is silently written as a deny list instead of being refused.Expected: an unknown mode raises
ValueErrornaming it, before anything is sent.