push_mac_acl writes an unknown mode as a deny list #39

Closed
opened 2026-11-12 18:14:28 +00:00 by christianmanivong · 0 comments
Owner

Priority: P3 (important, not urgent).

Found while fixing #35 (PR #38). _mac_acl_changes (napalm_openwrt/wireless_mixin.py) handles off, and otherwise writes macfilter='allow' for whitelist and 'deny' for anything else. A mode the driver does not know (a typo, a new mode from the caller) is silently written as a deny list instead of being refused.

Expected: an unknown mode raises ValueError naming it, before anything is sent.

Priority: P3 (important, not urgent). Found while fixing #35 (PR #38). `_mac_acl_changes` (`napalm_openwrt/wireless_mixin.py`) handles `off`, and otherwise writes `macfilter='allow'` for `whitelist` and `'deny'` for anything else. A mode the driver does not know (a typo, a new mode from the caller) is silently written as a deny list instead of being refused. Expected: an unknown mode raises `ValueError` naming it, before anything is sent.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-openwrt#39